From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751520AbdFFOb2 (ORCPT ); Tue, 6 Jun 2017 10:31:28 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:33939 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbdFFOb0 (ORCPT ); Tue, 6 Jun 2017 10:31:26 -0400 Subject: Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO To: Niklas Cassel , Giuseppe Cavallaro , Alexandre Torgue Cc: Niklas Cassel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170606072501.16560-1-niklas.cassel@axis.com> From: Florian Fainelli Message-ID: <284161d4-760f-0dd9-0363-c8e13750fba8@gmail.com> Date: Tue, 6 Jun 2017 07:31:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170606072501.16560-1-niklas.cassel@axis.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2017 12:25 AM, Niklas Cassel wrote: > stmmac_tso_allocator can fail to set the Last Descriptor bit > on a descriptor that actually was the last descriptor. > > This happens when the buffer of the last descriptor ends > up having a size of exactly TSO_MAX_BUFF_SIZE. > > When the IP eventually reaches the next last descriptor, > which actually has the bit set, the DMA will hang. > > When the DMA hangs, we get a tx timeout, however, > since stmmac does not do a complete reset of the IP > in stmmac_tx_timeout, we end up in a state with > completely hung TX. > > Signed-off-by: Niklas Cassel This should have: Fixes: f748be531d70 ("stmmac: support new GMAC4") right? > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 68a188e74c54..440bea049a7f 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -2723,7 +2723,7 @@ static void stmmac_tso_allocator(struct stmmac_priv *priv, unsigned int des, > > priv->hw->desc->prepare_tso_tx_desc(desc, 0, buff_size, > 0, 1, > - (last_segment) && (buff_size < TSO_MAX_BUFF_SIZE), > + (last_segment) && (tmp_len <= TSO_MAX_BUFF_SIZE), > 0, 0); > > tmp_len -= TSO_MAX_BUFF_SIZE; > -- Florian