From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Luis Henriques <luis.henriques@canonical.com>
Cc: Len Brown <lenb@kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / battery: ensure acpi_battery_init() has finish
Date: Fri, 15 May 2015 01:59:24 +0200 [thread overview]
Message-ID: <2846184.p0deZ4nZzp@vostro.rjw.lan> (raw)
In-Reply-To: <1431380945-2923-1-git-send-email-luis.henriques@canonical.com>
On Monday, May 11, 2015 10:49:05 PM Luis Henriques wrote:
> Make sure that async function scheduled with async_schedule() has already
> been executed.
>
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Queued up for 4.2 (along with the other two battery patches of yours), thanks!
> ---
> drivers/acpi/battery.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 9c676a6f32ce..547e627611e0 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -70,6 +70,7 @@ MODULE_AUTHOR("Alexey Starikovskiy <astarikovskiy@suse.de>");
> MODULE_DESCRIPTION("ACPI Battery Driver");
> MODULE_LICENSE("GPL");
>
> +static async_cookie_t async_cookie;
> static int battery_bix_broken_package;
> static int battery_notification_delay_ms;
> static unsigned int cache_time = 1000;
> @@ -1313,12 +1314,13 @@ static int __init acpi_battery_init(void)
> if (acpi_disabled)
> return -ENODEV;
>
> - async_schedule(acpi_battery_init_async, NULL);
> + async_cookie = async_schedule(acpi_battery_init_async, NULL);
> return 0;
> }
>
> static void __exit acpi_battery_exit(void)
> {
> + async_synchronize_cookie(async_cookie);
> acpi_bus_unregister_driver(&acpi_battery_driver);
> #ifdef CONFIG_ACPI_PROCFS_POWER
> acpi_unlock_battery_dir(acpi_battery_dir);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-05-14 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 21:49 Luis Henriques
2015-05-14 23:59 ` Rafael J. Wysocki [this message]
2015-05-15 23:09 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2846184.p0deZ4nZzp@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=arjan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.henriques@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®