From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763032AbdAKOaC (ORCPT ); Wed, 11 Jan 2017 09:30:02 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:44819 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762687AbdAKOaA (ORCPT ); Wed, 11 Jan 2017 09:30:00 -0500 X-AuditID: b6c32a37-f79606d000005083-ae-58764165d710 From: Bartlomiej Zolnierkiewicz To: Sascha Hauer , Martin Kaiser Cc: kernel@pengutronix.de, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: imxfb: always allocate 256 entries for the color map Date: Wed, 11 Jan 2017 15:29:49 +0100 Message-id: <2846203.pYN6Pvhiy7@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170109125942.tk6iutwdnzzxysix@pengutronix.de> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRmVeSWpSXmKPExsWy7bCmnm6qY1mEwfcl6harpu5ksTjR94HV 4vKuOWwWG99FWvzdvonFgdWj6/oWFo/+vwYenzfJBTBHcdmkpOZklqUW6dslcGW82NrEVnCE t+L9jEMsDYwXuLoYOTkkBEwkTs76zQRhi0lcuLeerYuRi0NIYAejxNVvm9khnHYmiYkvTjDD dOw+dgGqajmjxIrZq5ghnK+MEk+XzmEEqWITsJKY2L4KzBYR8JY4OrsPqIiDg1kgTOL2kxyQ sLBAkMS6o29YQGwWAVWJxu1tYDavgKbEi5aX7CC2qICXxJZ97WDncQrYSixY2soGUSMo8WPy PbB6ZgF5iX37p7JC2DoSZ4+tYwS5R0KgnV1i7oolTCB7JQRkJTYdYIYwXSSuvSqA+EVY4tXx LewQtrTEqn+3oCExnVFi+28JiDGbGSVW7Z4AVWQtcfj4RahdfBLvvvawQszklehoE4Io8ZC4 3badDcJ2lNh89i4rJHiOMUo8/7aJZQKj/CwkL8xC8sIsJC8sYGRexSiWWlCcm55abFhgrFec mFtcmpeul5yfu4kRnCa0zHcwbjjnc4hRgINRiYdXwL4sQog1say4MvcQowQHs5IIbwtIiDcl sbIqtSg/vqg0J7X4EKM0B4uSOO/iRusIIYH0xJLU7NTUgtQimCwTB6dUAyN3YKfmdUcNzWku a5YXltzJeahbreXs9ueplRtT4dfqtgdnz3Y5r4wJcpXZF69d3XkkJqLVzqXOgmGKXy5/R+eG +7fE9m9albTmWqjX0ulJP14K8IfrH7Ri6l6wriVjSw/7t7WRj+78+Boq1Lp1Htu9A/HZPWWn ePgjbKWtF31ySFbqtFrxXYmlOCPRUIu5qDgRAGlm6o4PAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t9jAd0Ux7IIg/0brSxWTd3JYnGi7wOr xeVdc9gsNr6LtPi7fROLA6tH1/UtLB79fw08Pm+SC2COcrPJSE1MSS1SSM1Lzk/JzEu3VQoN cdO1UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dglvGi61NbAVHeCvezzjE0sB4 gauLkZNDQsBEYvexC2wQtpjEhXvrgWwuDiGBpYwS76bsZodwvjJK/F2+hB2kik3ASmJi+ypG EFtEwFvi6Ow+5i5GDg5mgTCJE8dMQcLCAgESt6fPYwWxWQRUJRq3t7GA2LwCmhIvWl6CjREV 8JLYsq+dCcTmFLCVWLC0FWrxMUaJrQc/M0M0CEr8mHwPrJlZQF5i3/6prBC2lsT6nceZJjAK zEJSNgtJ2SwkZQsYmVcxSqQWJBcUJ6XnGuallusVJ+YWl+al6yXn525iBEfOM6kdjAd3uR9i FOBgVOLhffCiJEKINbGsuDL3EKMEB7OSCG+LfVmEEG9KYmVValF+fFFpTmrxIUZToA8nMkuJ JucDozqvJN7QxNzE3NjAwtzS0sRISZy3cfazcCGB9MSS1OzU1ILUIpg+Jg5OqQbGNpH7R27G zLLMaUurj9pZyimwX032gYS1X8nZ/jM97/1mb+Mqe8YRWnJ07ffZ6oualvUXphgqaJWsTOn2 3coktPHbynNdyieivdwuzzDqKxNkPcxyu8NIVoFvz+cb0/QzLy3cIhuutLw7aP0cbWHPBKUi /m4Tp+T8uBrN9Re5JlluOety+4cSS3FGoqEWc1FxIgDGReyKsgIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111142956epcas1p18604ca42b92eca609c00b6ca8d22d3e0 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170109130015epcas3p460b58a2b926f3af37a62a1dbe73d291f X-RootMTR: 20170109130015epcas3p460b58a2b926f3af37a62a1dbe73d291f References: <1483395604-6931-1-git-send-email-martin@kaiser.cx> <20170109125942.tk6iutwdnzzxysix@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday, January 09, 2017 01:59:42 PM Sascha Hauer wrote: > On Mon, Jan 02, 2017 at 11:24:02PM +0100, Martin Kaiser wrote: > > The current code calculates the number of color map entries as > > 1 << info->var.bits_per_pixel. For 32bpp modes, 1 << 32 is 0 when > > written to an int variable. As a consequence, the subsequent copying > > of the default (non-empty) color map into our newly allocated color map > > fails and imxfb's probe function returns an error. > > > > On both imx1 and imx21 platforms, the color map is used only for modes > > with <= 8bpp. By allocating 256 entries for the color map, we're on the > > safe side. > > > > Signed-off-by: Martin Kaiser > > Acked-by: Sascha Hauer Thanks, patch queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > Sascha > > > --- > > Re-sending: corrected a typo in the LKML address, sorry for that. > > > > drivers/video/fbdev/imxfb.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c > > index fe0c4ee..1b0faad 100644 > > --- a/drivers/video/fbdev/imxfb.c > > +++ b/drivers/video/fbdev/imxfb.c > > @@ -985,7 +985,11 @@ static int imxfb_probe(struct platform_device *pdev) > > */ > > imxfb_check_var(&info->var, info); > > > > - ret = fb_alloc_cmap(&info->cmap, 1 << info->var.bits_per_pixel, 0); > > + /* > > + * For modes > 8bpp, the color map is bypassed. > > + * Therefore, 256 entries are enough. > > + */ > > + ret = fb_alloc_cmap(&info->cmap, 256, 0); > > if (ret < 0) > > goto failed_cmap;