From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Peter Chen <Peter.Chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@kernel.org>,
Matt Merhar <mattmerhar@protonmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Peter Geis <pgwipeout@gmail.com>, Ion Agorria <ion@agorria.com>,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/8] usb: chipidea: tegra: Support runtime PM
Date: Thu, 17 Dec 2020 16:45:03 +0300 [thread overview]
Message-ID: <28468e30-a832-9774-bed3-ac986aef8831@gmail.com> (raw)
In-Reply-To: <X9tgD+KSU1bIvht5@ulmo>
17.12.2020 16:41, Thierry Reding пишет:
> On Thu, Dec 17, 2020 at 12:40:05PM +0300, Dmitry Osipenko wrote:
>> Tegra PHY driver now supports waking up controller from a low power mode.
>> Enable runtime PM in order to put controller into the LPM during idle.
>>
>> Tested-by: Matt Merhar <mattmerhar@protonmail.com>
>> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
>> Tested-by: Peter Geis <pgwipeout@gmail.com>
>> Tested-by: Ion Agorria <ion@agorria.com>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> drivers/usb/chipidea/ci_hdrc_tegra.c | 13 ++++++++++---
>> 1 file changed, 10 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
>> index 5fccdeeefc64..655671159511 100644
>> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
>> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
>> @@ -38,21 +38,24 @@ struct tegra_usb_soc_info {
>>
>> static const struct tegra_usb_soc_info tegra20_ehci_soc_info = {
>> .flags = CI_HDRC_REQUIRES_ALIGNED_DMA |
>> - CI_HDRC_OVERRIDE_PHY_CONTROL,
>> + CI_HDRC_OVERRIDE_PHY_CONTROL |
>> + CI_HDRC_SUPPORTS_RUNTIME_PM,
>> .dr_mode = USB_DR_MODE_HOST,
>> .txfifothresh = 10,
>> };
>>
>> static const struct tegra_usb_soc_info tegra30_ehci_soc_info = {
>> .flags = CI_HDRC_REQUIRES_ALIGNED_DMA |
>> - CI_HDRC_OVERRIDE_PHY_CONTROL,
>> + CI_HDRC_OVERRIDE_PHY_CONTROL |
>> + CI_HDRC_SUPPORTS_RUNTIME_PM,
>> .dr_mode = USB_DR_MODE_HOST,
>> .txfifothresh = 16,
>> };
>>
>> static const struct tegra_usb_soc_info tegra_udc_soc_info = {
>> .flags = CI_HDRC_REQUIRES_ALIGNED_DMA |
>> - CI_HDRC_OVERRIDE_PHY_CONTROL,
>> + CI_HDRC_OVERRIDE_PHY_CONTROL |
>> + CI_HDRC_SUPPORTS_RUNTIME_PM,
>> .dr_mode = USB_DR_MODE_UNKNOWN,
>> };
>>
>> @@ -323,6 +326,10 @@ static int tegra_usb_probe(struct platform_device *pdev)
>> usb->data.hub_control = tegra_ehci_hub_control;
>> usb->data.notify_event = tegra_usb_notify_event;
>>
>> + /* Tegra PHY driver currently doesn't support LPM for ULPI */
>> + if (of_usb_get_phy_mode(pdev->dev.of_node) == USBPHY_INTERFACE_MODE_ULPI)
>> + usb->data.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM;
>> +
>
> Does this prevent the wakeup_enabled from being set for ULPI PHYs?
Yes
next prev parent reply other threads:[~2020-12-17 13:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 9:39 [PATCH v2 0/8] Support Runtime PM and host mode by Tegra ChipIdea USB driver Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 1/8] usb: phy: tegra: Add delay after power up Dmitry Osipenko
2020-12-17 13:25 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 2/8] usb: phy: tegra: Support waking up from a low power mode Dmitry Osipenko
2020-12-17 13:33 ` Thierry Reding
2020-12-17 13:47 ` Dmitry Osipenko
2020-12-17 15:04 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 3/8] usb: chipidea: tegra: Remove MODULE_ALIAS Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 4/8] usb: chipidea: tegra: Rename UDC to USB Dmitry Osipenko
2020-12-17 13:36 ` Thierry Reding
2020-12-17 14:00 ` Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 5/8] usb: chipidea: tegra: Support host mode Dmitry Osipenko
2020-12-17 13:40 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 6/8] usb: chipidea: tegra: Support runtime PM Dmitry Osipenko
2020-12-17 13:41 ` Thierry Reding
2020-12-17 13:45 ` Dmitry Osipenko [this message]
2020-12-17 15:02 ` Thierry Reding
2020-12-17 19:51 ` Dmitry Osipenko
2020-12-17 15:02 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 7/8] usb: host: ehci-tegra: Remove the driver Dmitry Osipenko
2020-12-17 13:42 ` Thierry Reding
2020-12-17 15:50 ` Alan Stern
2020-12-17 19:43 ` Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 8/8] ARM: tegra_defconfig: Enable USB_CHIPIDEA and remove USB_EHCI_TEGRA Dmitry Osipenko
2020-12-17 13:45 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28468e30-a832-9774-bed3-ac986aef8831@gmail.com \
--to=digetx@gmail.com \
--cc=Peter.Chen@nxp.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ion@agorria.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=pgwipeout@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®