From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: peterz@infradead.org, eranian@google.com, acme@kernel.org,
mark.rutland@arm.com, jolsa@kernel.org, irogers@google.com,
bp@alien8.de, x86@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, sandipan.das@amd.com,
ananth.narayan@amd.com, santosh.shukla@amd.com,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v2 2/3] perf/ibs: Fix interface via core pmu events
Date: Mon, 13 Mar 2023 18:05:24 +0530 [thread overview]
Message-ID: <284dddaf-86ea-f8f2-f2a8-5b7c41a4ca87@amd.com> (raw)
In-Reply-To: <CAM9d7ci_dRrjq==hu5O0wD2kdN5tSJRNFf2ZtDsQ_X6UXZM3CA@mail.gmail.com>
>> + /*
>> + * pmu->event_init() should return -ESRCH only when it
>> + * wants to forward the event to other pmu.
>> + */
>
> Can we add this to the comment in the struct pmu? There is a
> description already for other error codes.
Sure. I'll update there if we continue with this approach.
>
> Otherwise looks good.
Thanks,
Ravi
next prev parent reply other threads:[~2023-03-13 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 10:11 [PATCH v2 0/3] " Ravi Bangoria
2023-03-09 10:11 ` [PATCH v2 1/3] perf/ibs: Introduce ibs_core_pmu_event() Ravi Bangoria
2023-03-09 10:11 ` [PATCH v2 2/3] perf/ibs: Fix interface via core pmu events Ravi Bangoria
2023-03-11 0:32 ` Namhyung Kim
2023-03-13 12:35 ` Ravi Bangoria [this message]
2023-03-12 14:54 ` Peter Zijlstra
2023-03-13 12:29 ` Ravi Bangoria
2023-03-13 14:21 ` Peter Zijlstra
2023-03-13 15:40 ` Ravi Bangoria
2023-03-09 10:11 ` [PATCH v2 3/3] perf test: Add selftest to test IBS invocation " Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=284dddaf-86ea-f8f2-f2a8-5b7c41a4ca87@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®