From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751334AbdEHV6O (ORCPT ); Mon, 8 May 2017 17:58:14 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33542 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdEHV6N (ORCPT ); Mon, 8 May 2017 17:58:13 -0400 Subject: Re: [PATCH v2 3/4] perf config: Correctly check whether it is from system config To: Arnaldo Carvalho de Melo References: <1494241665-32472-1-git-send-email-treeze.taeung@gmail.com> <20170508163952.GJ7891@kernel.org> Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim From: Taeung Song Message-ID: <284fa039-9dd0-3fc2-05e0-2d4c0dc61758@gmail.com> Date: Tue, 9 May 2017 06:58:08 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170508163952.GJ7891@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On 05/09/2017 01:39 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, May 08, 2017 at 08:07:45PM +0900, Taeung Song escreveu: >> Currently section's from_system_config was checked twice. > > you mean: > > "The item->from_system_config is not being checked when iterating over > section->items, instead section->from_system_config is being checked > multiple times, fix this" > > ? Yes, it is. Change the commit message to be more proper ? Thanks, Taeung > >> So adjust it in order to correctly check not only section's >> but also item's from_system_config. >> >> Cc: Jiri Olsa >> Cc: Namhyung Kim >> Signed-off-by: Taeung Song >> --- >> tools/perf/builtin-config.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c >> index 0d38599..2a6ca0d 100644 >> --- a/tools/perf/builtin-config.c >> +++ b/tools/perf/builtin-config.c >> @@ -56,7 +56,7 @@ static int set_config(struct perf_config_set *set, const char *file_name) >> fprintf(fp, "[%s]\n", section->name); >> >> perf_config_items__for_each_entry(§ion->items, item) { >> - if (!use_system_config && section->from_system_config) >> + if (!use_system_config && item->from_system_config) >> continue; >> if (item->value) >> fprintf(fp, "\t%s = %s\n", >> -- >> 2.7.4