From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933064AbbESN4z (ORCPT ); Tue, 19 May 2015 09:56:55 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:54059 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933039AbbESN4u (ORCPT ); Tue, 19 May 2015 09:56:50 -0400 From: Arnd Bergmann To: James Bottomley Cc: linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RESEND] SCSI: ips: remove pointless #warning Date: Tue, 19 May 2015 15:56:15 +0200 Message-ID: <2850783.725LtIIUFq@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1432043572.3007.14.camel@HansenPartnership.com> References: <3121960.dnOqT9LCth@wuerfel> <1432043572.3007.14.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jJ71vAPLr9cM95esXkp5J3TDNRIiRZ/CojGBteM6PvsVtMoXUAJ m4QxvgnZ6HoLsokjyGy+GQdapQNu/ujus5HI12QZDLJpDxqoH6tNqxBE20mJNMvodGI++H5 Iq1is5z2D4Lq2oxJRUuCvdGcw3zgeAdNuAv49qeFbOb/CifQHwggx1E+/wnkY7oeHPlFxOc j5SICbvFkVDJ83DeO7FJA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 19 May 2015 06:52:52 James Bottomley wrote: > On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote: > > The ips driver contains > > > > #warning "This driver has only been tested on the x86/ia64/x86_64 platforms" > > > > which gets printed by the compiler every time this driver gets > > build for something other than those three architectures. The same > > is true for most other drivers, but none of them prints a warning like > > this. > > > > Let's remove the warning now to reduce the amount of clutter. > > > > FWIW, I've reviewed the driver and found a few oddities, but nothing > > that needs to be fixed or that would be architecture specific. > > In principle I don't disagree. However this warning was a specific > request of the driver writers. Since the driver is pretty much dead, > I'm not sure anyone is going to check or fix it for non-intel any time > soon. My main interest here is to get a clean build of ARM 'allmodconfig'. If you prefer another approach, we could also add 'depends on X86 || IA64' into Kconfig, which would also avoid that warning. Arnd