From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbdHBSe2 (ORCPT ); Wed, 2 Aug 2017 14:34:28 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:50349 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbdHBSe0 (ORCPT ); Wed, 2 Aug 2017 14:34:26 -0400 Subject: Re: [PATCH v6 5/7] PCI: dwc: qcom: Use block IP version for operations To: Varadarajan Narayanan , bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, kishon@ti.com, sboyd@codeaurora.org, vivek.gautam@codeaurora.org, fengguang.wu@intel.com, weiyongjun1@huawei.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <1501482857-14100-1-git-send-email-varada@codeaurora.org> <1501482857-14100-6-git-send-email-varada@codeaurora.org> From: Stanimir Varbanov Message-ID: <285396b4-cadb-6f4a-8cca-d781503b9d49@mm-sol.com> Date: Wed, 2 Aug 2017 21:34:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501482857-14100-6-git-send-email-varada@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 31.07.2017 09:34, Varadarajan Narayanan wrote: > Presently, when support for a new SoC is added, the driver ops > structures and functions are versioned with plain 1, 2, 3 etc. > Instead use the block IP version number. > > Signed-off-by: Varadarajan Narayanan > --- > drivers/pci/dwc/pcie-qcom.c | 133 +++++++++++++++++++++++--------------------- > 1 file changed, 71 insertions(+), 62 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c > +/* > + * Declare one of_device_id entry > + * c - Compatible string > + * d - Associated data > + * w - SoC wrapper version (ignored) > + * s - Synopsys core version (ignored) > + */ > +#define QCOM_DECL(c, d, w, s) { .compatible = c, .data = &d } Please don't introduce this macro, just add a comment with qcom version and corresponding synopsys version. regards, Stan