mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Till Harbaum <till@harbaum.org>
To: Andi Shyti <andi.shyti@kernel.org>,
	"Dustin L. Howett" <dustin@howett.net>
Cc: Whinis <whinis@whinis.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Dustin L. Howett" <dustin@howett.net>
Subject: Re: [PATCH] i2c-tiny-usb: add support for the Oops Electronics SFP Media Buddy
Date: Mon, 26 Oct 2026 20:06:40 +0100	[thread overview]
Message-ID: <2856078.mvXUDI8C0e@titan> (raw)
In-Reply-To: <20261017-i2c-oops-electronics-v1-1-ce960f8f1b7a@howett.net>

Hi,

I am fine with that.

Regards,
  Till

On Samstag, 17. Oktober 2026 19:56:04 Mitteleuropäische Normalzeit Dustin L. 
Howett wrote:
> The Oops Electronics "SFP Media Buddy" is an open-source USB device that
> provides i2c access, among other things, to a SFP+ network module.
> 
> It exposes a vendor protocol which is compatible with the i2c-tiny-usb
> kernel module. Due to a bug in prior firmware versions, that protocol
> can only be used with devices reporting bcdDevice >= 0x0101[^2].
> 
> [^1]: https://oopselectronics.com/product/SFPB and
>       https://gitlab.whinis.com/oops-electronics/sfp-media-buddy
> 
> [^2]: Devices without the fix will crash and drop off the bus when this
>       module is loaded, which prevents them from being updated.
> 
> ---
> Signed-off-by: Dustin L. Howett <dustin@howett.net>
> ---
>  drivers/i2c/busses/i2c-tiny-usb.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-tiny-usb.c
> b/drivers/i2c/busses/i2c-tiny-usb.c index 73355a56aabf..92a2633a028e 100644
> --- a/drivers/i2c/busses/i2c-tiny-usb.c
> +++ b/drivers/i2c/busses/i2c-tiny-usb.c
> @@ -162,6 +162,15 @@ static const struct i2c_algorithm usb_algorithm = {
>  static const struct usb_device_id i2c_tiny_usb_table[] = {
>  	{ USB_DEVICE(0x0403, 0xc631) },   /* FTDI */
>  	{ USB_DEVICE(0x1c40, 0x0534) },   /* EZPrototypes */
> +	{
> +		/* OopsElectronics SFP Media Buddy v1.01+ */
> +		.match_flags = USB_DEVICE_ID_MATCH_VENDOR |
> +			USB_DEVICE_ID_MATCH_PRODUCT | 
USB_DEVICE_ID_MATCH_DEV_LO,
> +		.idVendor = 0xc2f9,
> +		.idProduct = 0x0004,
> +		.bcdDevice_lo = 0x0101
> +	},
> +
>  	{ }                               /* Terminating entry */
>  };
> 
> 
> ---
> base-commit: 58161ead29e50d70a317ea26b472e0c7508e69da
> change-id: 20261017-i2c-oops-electronics-5dd3659782da
> 
> Best regards,
> --
> Dustin L. Howett <dustin@howett.net>


-- 
Dr. Till Harbaum <till@harbaum.org>



  parent reply	other threads:[~2026-10-26 19:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17 17:56 Dustin L. Howett
2026-10-26 18:51 ` Dustin Howett
2026-10-26 19:06 ` Till Harbaum [this message]
2026-10-27  9:55 ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2856078.mvXUDI8C0e@titan \
    --to=till@harbaum.org \
    --cc=andi.shyti@kernel.org \
    --cc=dustin@howett.net \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=whinis@whinis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®