From: Qiang Yu <quic_qianyu@quicinc.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: <manivannan.sadhasivam@linaro.org>, <vkoul@kernel.org>,
<kishon@kernel.org>, <robh@kernel.org>, <andersson@kernel.org>,
<konradybcio@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <abel.vesa@linaro.org>,
<quic_msarkar@quicinc.com>, <quic_devipriy@quicinc.com>,
<dmitry.baryshkov@linaro.org>, <kw@linux.com>,
<lpieralisi@kernel.org>, <neil.armstrong@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-clk@vger.kernel.org>,
Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH v6 6/8] PCI: qcom: Fix the ops for SC8280X family SoC
Date: Tue, 15 Oct 2024 10:46:15 +0800 [thread overview]
Message-ID: <28567b77-9d0c-421a-8c2e-88a310a20704@quicinc.com> (raw)
In-Reply-To: <20241014171807.GA612411@bhelgaas>
On 10/15/2024 1:18 AM, Bjorn Helgaas wrote:
> [+cc Johan; if you tag a commit with Fixes:, please cc the author of
> that commit!]
>
> On Fri, Oct 11, 2024 at 03:41:40AM -0700, Qiang Yu wrote:
>> On SC8280X family SoC, PCIe controllers are connected to SMMUv3, hence
>> they don't need the config_sid() callback in ops_1_9_0 struct. Fix it by
>> introducing a new ops struct, namely ops_1_21_0, so that BDF2SID mapping
>> won't be configured during init.
> Can you make the subject line say something specific about what this
> patch does? "Fix the ops" really doesn't include any useful
> information.
Sure, will directly say Remove BDF2SID mapping config for SC8280XP in
subject.
>
> Based on the Fixes: below, this has to do with ASPM, so the subject
> line (and the commit log) should probably say something about ASPM.
>
> I don't see the connection between your mention of SMMUv3 and ASPM.
> Are there two logical changes here that should be two separate
> patches?
This patch is to remove config_sid callback for sc8280x as it
supports SMMUv3.
This patch is not related to ASPM. Look like using
70574511f3f ("PCI: qcom: Add support for SC8280XP")
in Fixes tag is better. Sorry for the confusion.
Thanks,
Qiang
>> Fixes: d1997c987814 ("PCI: qcom: Disable ASPM L0s for sc8280xp, sa8540p and sa8295p")
>> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
>> ---
>> drivers/pci/controller/dwc/pcie-qcom.c | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
>> index 88a98be930e3..468bd4242e61 100644
>> --- a/drivers/pci/controller/dwc/pcie-qcom.c
>> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
>> @@ -1367,6 +1367,16 @@ static const struct qcom_pcie_ops ops_2_9_0 = {
>> .ltssm_enable = qcom_pcie_2_3_2_ltssm_enable,
>> };
>>
>> +/* Qcom IP rev.: 1.21.0 */
>> +static const struct qcom_pcie_ops ops_1_21_0 = {
>> + .get_resources = qcom_pcie_get_resources_2_7_0,
>> + .init = qcom_pcie_init_2_7_0,
>> + .post_init = qcom_pcie_post_init_2_7_0,
>> + .host_post_init = qcom_pcie_host_post_init_2_7_0,
>> + .deinit = qcom_pcie_deinit_2_7_0,
>> + .ltssm_enable = qcom_pcie_2_3_2_ltssm_enable,
>> +};
>> +
>> static const struct qcom_pcie_cfg cfg_1_0_0 = {
>> .ops = &ops_1_0_0,
>> };
>> @@ -1405,7 +1415,7 @@ static const struct qcom_pcie_cfg cfg_2_9_0 = {
>> };
>>
>> static const struct qcom_pcie_cfg cfg_sc8280xp = {
>> - .ops = &ops_1_9_0,
>> + .ops = &ops_1_21_0,
>> .no_l0s = true,
>> };
>>
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2024-10-15 2:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 10:41 [PATCH v6 0/8] Add support for PCIe3 on x1e80100 Qiang Yu
2024-10-11 10:41 ` [PATCH v6 1/8] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the X1E80100 QMP PCIe PHY Gen4 x8 Qiang Yu
2024-10-12 4:14 ` Manivannan Sadhasivam
2024-10-11 10:41 ` [PATCH v6 2/8] dt-bindings: PCI: qcom: Move OPP table to qcom,pcie-common.yaml Qiang Yu
2024-10-11 10:41 ` [PATCH v6 3/8] dt-bindings: PCI: qcom,pcie-x1e80100: Add 'global' interrupt Qiang Yu
2024-10-11 14:33 ` Krzysztof Kozlowski
2024-10-11 14:36 ` Krzysztof Kozlowski
2024-10-11 15:42 ` Manivannan Sadhasivam
2024-10-11 15:44 ` Krzysztof Kozlowski
2024-10-11 15:51 ` Manivannan Sadhasivam
2024-10-11 16:06 ` Krzysztof Kozlowski
2024-10-14 7:50 ` Qiang Yu
2024-10-14 8:25 ` Krzysztof Kozlowski
2024-10-14 13:09 ` Qiang Yu
2024-10-14 9:02 ` Manivannan Sadhasivam
2024-10-14 9:26 ` Krzysztof Kozlowski
2024-10-14 9:41 ` Manivannan Sadhasivam
2024-10-14 13:09 ` Qiang Yu
2024-10-11 10:41 ` [PATCH v6 4/8] phy: qcom: qmp: Add phy register and clk setting for x1e80100 PCIe3 Qiang Yu
2024-10-11 10:41 ` [PATCH v6 5/8] clk: qcom: gcc-x1e80100: Fix halt_check for pipediv2 clocks Qiang Yu
2024-10-11 10:41 ` [PATCH v6 6/8] PCI: qcom: Fix the ops for SC8280X family SoC Qiang Yu
2024-10-11 13:36 ` Dmitry Baryshkov
2024-10-12 4:23 ` Manivannan Sadhasivam
2024-10-14 17:18 ` Bjorn Helgaas
2024-10-15 2:46 ` Qiang Yu [this message]
2024-10-11 10:41 ` [PATCH v6 7/8] PCI: qcom: Fix the cfg for X1E80100 SoC Qiang Yu
2024-10-11 13:37 ` Dmitry Baryshkov
2024-10-12 5:36 ` Manivannan Sadhasivam
2024-10-14 17:20 ` Bjorn Helgaas
2024-10-11 10:41 ` [PATCH v6 8/8] arm64: dts: qcom: x1e80100: Add support for PCIe3 on x1e80100 Qiang Yu
2024-10-16 20:42 ` (subset) [PATCH v6 0/8] " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28567b77-9d0c-421a-8c2e-88a310a20704@quicinc.com \
--to=quic_qianyu@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=helgaas@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_devipriy@quicinc.com \
--cc=quic_msarkar@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®