From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010004.outbound.protection.outlook.com [40.93.198.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14DC35DA6C for ; Wed, 20 May 2026 17:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.4 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298785; cv=fail; b=kHdSNosGhAxYt0pMGT9oLgbzvHM2wMSsVVaPhlRE15FcY8zlVK0txixm8UkHC4sjAlXXgFA/w2u+VUa7Rq5MtxIgkLgaAcHFZZExDDCg8R5pDsD7wirDmTIgpg3xi8TawbEcJq2DtvWHHpOu6OEbW8U5T5PnpA7KRxSHivdKlMU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298785; c=relaxed/simple; bh=GStUHq2BvqEwIiZP+3SVmJWzih0adPJ/pZO3S44LFWs=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=JPv4uHXEjMSnDkgnWvdXyz4uBNoeu7ktstld3YGMUsMEOOs72Qy6tgAKWXUVd5GzaWgNRKeSMAKpNzzTSuUqwxU+8GTiDELBFyp4PFSh5sreoDeLpq4FJV4BRI/alQmvAI9ujBZgBG4Snnzh04KyxlkLNvdt2YEtA393EqmbRVc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=OTYuFc4C; arc=fail smtp.client-ip=40.93.198.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="OTYuFc4C" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jv3jR/tVHreezaOEc5ZMyBiznj2FlZavAILegbtrfHaB8OESUsyiqB83bxQf/m+E2IQMB68B1K8VuFpQyn7h49txOgwmb1ZN5O92+VfQ2GfDiHjjT/iqrrHIN23oRzfxZTZEIiKwJ74CTHgZvWlRoIv/yK8BfhMrKYCzqFfSoU6cnCgc2sqb9H1gqauNAuctvGuEwFcsPpgeEwLQQ4ch72/GWmEwV9dZeZkEx1iNzuNdyl+djhENXHCFuSPHIssgPKqgxIRwR/0/dxrFTcEAUM5rwCLC2LCH4TvfUvUUYB0ray/bzucb7P/aAPWYN+Ah4+xMKQ3jb3MIYQzqxtx/8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tLmeL3p4aop1JppIm1DdausGyIhNXO8LKUA45QLJEq0=; b=lajhFJEU1nLwari1/IyMn+vqEpGWYkP0rkd/mnDVEWzwWbUU7K1c0XzvLdCcOqB4gJv3Ss4ZoWwACXQnXWOWBbLcHO6crVxXySm2q4AZisy+zOce9RtGitV0kIhkYXkSVk9wgWXJk5INW8D7vqeCWWa4yYDZq3nilDsMY5h8h+pM3jminXbMo2H0e5vg9iuNIWkMFMRpk1MSFAZ9M6MNYjEq9afPOU/knoOSFKGbjNGAHAPi35BewsmlVaaHJg8zLO7RacgIBmhufvk/LVMAxIIo3zYxVC2wnPO4BprtneAs1zIPR6RYHVCp7dmL09SGLF9p+LtIuRYGxFLGRaL1VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tLmeL3p4aop1JppIm1DdausGyIhNXO8LKUA45QLJEq0=; b=OTYuFc4CuAUAIJmXrRzhcxYXEfSTzp1s1Xj8ewpRhxCdeR0zxml870++iC8yUojHRDeB68v8cFvbOU87bXCGDiYEcffIHiHEvrw4aL6COmv7z1JkeeKPZ6rqtFh05r/HVvVM0xvvkKzZWpXvQeR03RgFv6vFfDrkAeNA251UZ58= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) by MW4PR12MB5604.namprd12.prod.outlook.com (2603:10b6:303:18d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.16; Wed, 20 May 2026 17:39:40 +0000 Received: from DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::f3f2:852c:78d5:9353]) by DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::f3f2:852c:78d5:9353%4]) with mapi id 15.20.9870.023; Wed, 20 May 2026 17:39:40 +0000 Message-ID: <2860d88e-3f29-487a-985d-2c94af0373f9@amd.com> Date: Wed, 20 May 2026 12:39:37 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] x86/mm: Disable broadcast TLB flush when PCID is disabled From: Tom Lendacky To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Nadav Amit , Rik van Riel , Dave Hansen References: Content-Language: en-US Autocrypt: addr=thomas.lendacky@amd.com; keydata= xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmkbaKgFCRZQah8ACgkQ 3v+a5E8wTVPFyg//UYANiuHfxxJET8D6p/vIV0xYcf1SXCG78M+5amqcE/4cCIJWyAT3A1nP zwyQIaIjUlGsXQtNgC1uVteCnMNJCjVQm0nLlJ9IVtXxzRg0QKjuSdZxuL5jrIon4xW9hTJR 94i2v3Fx5UWyP2TB6qZOcB0jgh0l01GHF9/DVJbmQlpvQB4Z1uNv09Q7En6EXi28TSv0Ffd1 p8vKqxwz7CMeAeZpn5i7s1QE/mQtdkyAmhuGD12tNbWzFamrDD1Kq3Em4TIFko0+k5+oQAAf JFaZc1c0D4GtXwvv4y+ssI0eZuOBXapUHeNNVf3JGuF6ZPLNPAe5gMQrmsJinEArVYRQCuDA BZakbKw9YJpGhnSVeCl2zSHcVgXuDs4J2ONxdsGynYv5cjPb4XTYPaE1CZH7Vy1tqma8eErG rcCyP1seloaC1UQcp8UDAyEaBjh3EqvTvgl+SppHz3im0gPJgR9km95BA8iGx9zqDuceATBc +A007+XxdFIsifMGlus0DKPmNAJaLkEEUMedBBxH3bwQ+z8tmWHisCZQJpUeGkwttD1LK/xn KRnu8AQpSJBB2oKAX1VtLRn8zLQdGmshxvsLUkKdrNE6NddhhfULqufNBqul0rrHGDdKdTLr cK5o2dsf9WlC4dHU2PiXP7RCjs1E5Ke0ycShDbDY5Zeep/yhNWLOwU0EVo1liQEQAL7ybY01 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+ LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe /5rkTzBNUwUCaRto5wUJFlBqXgAKCRDe/5rkTzBNUw4/EAClG106SeHXiJ+ka6aeHysDNVgZ 8pUbB2f8dWI7kzD5AZ5kLENnsi1MzJRYBwtg/vVVorZh6tavUwcIvsao+TnV57gXAWr6sKIc xyipxRVEXmHts22I6vL1DirLAoOLAwWilkM+JzbVE3MMvC+cCVnMzzchrMYDTqn1mjCCwiIe u5oop+K/RgeHYPsraumyA9/kj8iazrLM+lORukCNM7+wlRClcY8TGX+VllANym9B6FMxsJ5z Q7JeeXIgyGlcBRME+m3g40HfIl+zM674gjv2Lk+KjS759KlX27mQfgnAPX4tnjLcmpSQJ77I Qg+Azi/Qloiw7L/WsmxEO5ureFgGIYDQQUeM1Qnk76K5Z3Nm8MLHtjw3Q7kXHrbYn7tfWh4B 7w5Lwh6NoF88AGpUrosARVvIAd93oo0B9p40Or4c5Jao1qqsmmCCD0dl7WTJCboYTa2OWd99 oxS7ujw2t1WMPD0cmriyeaFZnT5cjGbhkA+uQGuT0dMQJdLqW3HRwWxyiGU/jZUFjHGFmUrj qFAgP+x+ODm6/SYn0LE0VLbYuEGfyx5XcdNnSvww1NLUxSvuShcJMII0bSgP3+KJtFqrUx9z l+/NCGvn/wMy6NpYUpRSOmsqVv0N71LbtXnHRrJ42LzWiRW2I5IWsb1TfdMAyVToHPNaEb0i WiyqywZI5g== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR03CA0403.namprd03.prod.outlook.com (2603:10b6:610:11b::13) To DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5070:EE_|MW4PR12MB5604:EE_ X-MS-Office365-Filtering-Correlation-Id: 228395dc-6683-4b21-b6ab-08deb696c4f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|7416014|22082099003|18002099003|56012099003|11063799006; X-Microsoft-Antispam-Message-Info: OMQqxbSsIat7gOFgALC2o6woViZPdl1oYOYuxpeIyQ8zjC4Tq8aYtiROLqp8WEUIWB6IN6MYpnilcx3M3TobYcxA9HkQt9dy3RWQBRDv40RowvmI1FnH/qriaM24JR/Jh9irqTMNEpFTkpLcPxC5f+uYBzX67s0VnH7NEPOO3i40WwD5olOfRbQ8ISf0afn7TEo2nR2p9t2qWVr4suYDl4sMnr4swtGUP+qMXVL2tcINkjgAPywCIpniwypN+jXWsW9taTZMaH0GaY7C2xlJEhyUHKYefvTMVqE6pDDdoCb0ojJCIG3qSIGGCqsOuXlCLxcLu5lYpujEpfSn9W/qowTQe5cXqAOtESVuMm5VKvw0QY6M7DgT+0AUQ+WKINNFKY5C2YydKKFoyVpxKMlemmhd8rIuNshGURCaJiZok7kiXtgY6Cl+0HKkfDds/OHisvQg7JSbGPEbmkVub4Jj7GWNl8UdaDqO9J0L8hay6yQJqhbqLVZu2csNRbAMdE7KT4KAsZzZAd3d4IkJ8jHPYIEcGtt/eBuxoy4gAtd9CEaam66uo/dQQbKv3cQgnsHRJFwjM73HPmha8h3L5Kpqu1+6WBLPpsAP7sFbB6WhWWvP1YD13GXVmm1huqnOhadQrHfkb1+GWNJsowA7yeGGU/vITYh6yxecJnmXUIY1IUdlgcncAMD1L2BPq/4vNkUp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5070.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(7416014)(22082099003)(18002099003)(56012099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDZzdUhlNXBxbTIzeVE3Tk9FeHVTNXBvNVJ0NG1FdTZsdEJ2d2ZMSlFRNnQy?= =?utf-8?B?cDJqa1Q2VWZid3FTdU9qSU1manNQdUFZMUVtZ01ISkMwTW16Z2lPemFQRjJN?= =?utf-8?B?VE9jcXZjT2VsZVYxMGJhYXM3YXpNNis2dkgzWVY3QWdWTUVKTWNlSndjeCtV?= =?utf-8?B?Zmcxdmx5c2tvZWxqazNqbHEwRERhZnM2Z3Ntays0b3FmWktDQ0hETzB5S0FP?= =?utf-8?B?VUZOZXN4YzBuRjlubmNkc3duVE5HV0lGQkp0MmNWd3lRODZ3L1Y5LzY3WXNh?= =?utf-8?B?b1RRc3dKeWF1MzZEL3hKZFpOS1dZSXYxWGd2c2ZTSkZEb3RYRUZvQWQ1OEZu?= =?utf-8?B?RDNObExiU1JqaUtlaWRIUnh3MnUvRkZQdzAvbE42RXkwQ1JpbFBzUThQamRZ?= =?utf-8?B?em1nNE11SERvWS9oY0hodWorbFlYTk5VM2hrcG04VDh2UXJiSkZqT002Vnpk?= =?utf-8?B?dVNKRXpJN3E5dFh5RTlBV0hwYW8zWnJTQlNyOTFOSVEwd1JCRmxLNlJuYVpo?= =?utf-8?B?bzhORWk0eTNKdUtFajdXTGdpOE1EZHZiamZ2NlpiQ21ZMSt0OXhwN3ZTWEQy?= =?utf-8?B?YTZacDhKYWhNaUVSM1BGbFhYQ2RtekNlVmlVT0tncFovRUVTMkFyWlRzOFg1?= =?utf-8?B?UDlZMURqQ29KYnAxbStObktqa1ptaW1TWkJWb3NkbXRINzZIbnBTRzRmTlZM?= =?utf-8?B?QzNWejhKVjBRREVmZDkySU41ejVNaFIrY2sxYUEyVXFLd2dBdk1keTNtT3Nm?= =?utf-8?B?THY3UnVURmROVDRXL2NvUXh4djNBQWhDbk92eWhzT3A2SEM1cElzQUZFbXZI?= =?utf-8?B?dUdIcUZFVHZ1MkxTWjJybzRZRzZwNUg0NjZSK0hlSmtTWUdtblIvRUtQWTVp?= =?utf-8?B?QzRKQVpLL3lRbURaODFpTkk0R21CZEVVenR0akZrQ09GTFFVMXFzV0lQT3RP?= =?utf-8?B?akxSaEZCZUNJOGx1NXRpSExRcGtxYnVZVHA3SDB5SmZVT0lRSGFhK0EvUmky?= =?utf-8?B?RmVlRUhhOFhNbm9YbzlPdTBXcW8rK2RYTWhxbG1KQ3hENlAva0ZwOWJTVHg4?= =?utf-8?B?VERyUWJQRkQ0M1lrTy81TG54OFduVWkvRHpJdGs5OStCQVN0TGFRMTR0bTBs?= =?utf-8?B?T3Jad2YyRWxGVzJ5L1R1YVBnUUFsT3V1QnRBRUJldWM1b1hiaUNhSzkzUnIx?= =?utf-8?B?MVFWWGoxZ1VIWmFEcXJJRG1rUFA0eUE4Q0ZWN1F5THJieXN2bXRLUXRzUTIw?= =?utf-8?B?Z2U3bE9DazVPc0lpSlN2aUZvckFXODVCQ3dlenpBY3h6SVF4L05qSGR0ODVY?= =?utf-8?B?RGZNSW1UNFdvaDcwcWwwVUdKTkZwQk5NM0pnditZSFFadTZyZGFmN3BsVUxJ?= =?utf-8?B?U3M2UHp1M2FveG1tTUo1clhOdWhNYW8zV3pUVEtQSXdQUGZNdVhvSTdUM1dO?= =?utf-8?B?VGFlYXZQREltekFydkUyRGRvZTZxdk92OUhiczBXQWNaYXZoUmUraW9handa?= =?utf-8?B?a2F2dDZMUGN3TFljSDNmM1R5RjRrTWtYYkFqU1p3OGJGOXlYTnI4TW1pclFB?= =?utf-8?B?bG1lTk50WDJSUFJMY2pyaitZMkVWVUFCOENoN1BHbFQwN0pSdHRBb1VyWjUz?= =?utf-8?B?dHhkbW1HbkhWdEFPV3J4RFFuRUxETkRNc3N4cWRTNlZ1NXkybXhxVFJ2dUhK?= =?utf-8?B?WDlmSDNSM094S1lSamNDQm50MllNdjMwaHFsUnZDYUQ5ckl1bjVSejhaYXdB?= =?utf-8?B?blhVSW1tcEZtZXJ5elFZcktleWZrZDdxVC9DTGVGelQ5anZNZUs3bTJvNXFD?= =?utf-8?B?U3YyaFF1NkNMc1ZQbkowSXVkcGV3Qlp2K0ZrV21pRkJOdE1XUkwrMjhyWFB4?= =?utf-8?B?cUpLdCtNOHlhRG1sdjd1bVI0SmlJaVlQSnJuNVNOMW5wT0tidXoxRm1NYXdy?= =?utf-8?B?cUxCS3ZtcWE4NlA4TG8zU2tZdmJZOHZQMnkxNUxyWXhFK3p1QXBOYlVLNjJq?= =?utf-8?B?a244a2FtWmovOU1zR2JoWFM4cFZISFpTZ2FHNmhtZjBsNG9MUm5DeUlpRkNT?= =?utf-8?B?Q3VZYU52VW0xM2hGK2dvMEkxVm5IbHp0bENQOGxkc3lLbHgrengwZHdNMnpR?= =?utf-8?B?WCtaMTFwQWJ4enlPcnlMWVlBN1dXU0RpYXZ5SE5leWF3b3B2YWFidS8zdTNJ?= =?utf-8?B?clVlWDJyYVJIS0NwRXV4bHBUKzlleDhCekN0UkZhUHdHNjR1N3ZWeGhES3I3?= =?utf-8?B?c3V1bUVhK0x6OW8vbEl3VGswSCtmaFZmVmplWVFuRXNweTQxTWJhM3dDTno1?= =?utf-8?B?RThoU0U2Q05HMXNhU21QaUVNTTc4aElFVTNqL3JNZTNUUTRQWlpIdz09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 228395dc-6683-4b21-b6ab-08deb696c4f2 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5070.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2026 17:39:40.0072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sKPOKSJUNZyfP3n+uCYIDDXRT7utIjqDWa5EDNgu5RCA9cWqIOYhUqlPsTXtYN2FwnYfi5BcrkvqzDo9lNgd0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5604 On 5/20/26 12:00, Tom Lendacky wrote: > Booting with "nopcid" clears X86_FEATURE_PCID and keeps CR4.PCIDE from > being set to one. On AMD CPUs that support INVLPGB, broadcast TLB > flushing remains enabled. > > There are two checks that decide whether the global ASID code runs, > mm_global_asid() and consider_global_asid(), that key off of the > X86_FEATURE_INVLPGB feature. Once an mm becomes active on more than > three CPUs, consider_global_asid() assigns it a global ASID, after which > flush_tlb_mm_range() takes the broadcast_tlb_flush() path using a non-zero > PCID. Issuing an INVLPGB with a non-zero PCID while CR4.PCIDE is not set > results in a #GP: > > Oops: general protection fault, kernel NULL pointer dereference 0x1: 0000 [#1] SMP NOPTI > CPU: 158 UID: 0 PID: 3119 Comm: snap Not tainted 7.1.0-rc3 #1 PREEMPT(full) > Hardware name: ... > RIP: 0010:broadcast_tlb_flush+0x9d/0x210 > Code: ... 89 da 48 83 c8 07 <0f> 01 fe eb 08 cc cc cc ... > RSP: 0000:ffa0000031217cb0 EFLAGS: 00010202 > RAX: 00007f8ee8540007 RBX: 0000000008070000 RCX: 0000000000000000 > RDX: 0000000000070000 RSI: 0000000000000001 RDI: 00007f8ee8540000 > RBP: ff110001189a0700 R08: 00007f8ee8541000 R09: 000000000000000c > R10: 000000000000000c R11: 0000000000070000 R12: ff1100c0433aec80 > R13: 0000000000000000 R14: 0000000000000008 R15: 0000000000000007 > FS: 00007f8ed3fff6c0(0000) GS:ff1100c0b7b8a000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f8ee8540058 CR3: 00080001433af000 CR4: 0000000000751ef0 > PKRU: 55555554 > Call Trace: > > flush_tlb_mm_range+0xd8/0x220 > ptep_clear_flush+0x56/0x60 > wp_page_copy+0x293/0x6c0 > ? _raw_spin_unlock+0x15/0x30 > __handle_mm_fault+0x512/0x6d0 > handle_mm_fault+0x145/0x2a0 > do_user_addr_fault+0x187/0x6f0 > exc_page_fault+0x6a/0x180 > asm_exc_page_fault+0x22/0x30 > RIP: 0033:0x55c553ebc639 > Code: ... > RSP: 002b:00007f8ed3ffeaa8 EFLAGS: 00010246 > RAX: 00007f8ee8540058 RBX: 000055c554ff77b8 RCX: 00007f8ee853c1c8 > RDX: 0000000000000000 RSI: 000000c000062b20 RDI: 00007f8ee8540040 > RBP: 00007f8ed3ffeb00 R08: 0000000000006040 R09: 0000000000000005 > R10: 0000000000000004 R11: 00000000000001c0 R12: 0000000000000001 > R13: 0000005990100204 R14: 000000c000624fc0 R15: 3fffffffffffffff > > Modules linked in: ... > ---[ end trace 0000000000000000 ]--- > > All processors that support broadcast TLB invalidation also have PCID > support, so it is only the "nopcid" scenario that is of concern. In > this situation just disable the broadcast TLB support using the CPUID > dependency support by making X86_FEATURE_INVLPGB dependent on > X86_FEATURE_PCID. > > Fixes: 4afeb0ed1753 ("x86/mm: Enable broadcast TLB invalidation for multi-threaded processes") > Assisted-by: Claude:claude-opus-4.7 > Suggested-by: Dave Hansen > Signed-off-by: Tom Lendacky Sorry, I missed Rik's Acked-by: to the v2 patch. Thanks, Tom > > --- > > Changes from v2: > - Update commit message. (Dave) > > Changes from v1: > - Disable broadcast TLB support when PCID support is not available > instead of adding PCID support checks to mm_global_asid() and > consider_global_asid(). (Dave) > --- > arch/x86/kernel/cpu/cpuid-deps.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kernel/cpu/cpuid-deps.c b/arch/x86/kernel/cpu/cpuid-deps.c > index 146f6f8b0650..99801e844b30 100644 > --- a/arch/x86/kernel/cpu/cpuid-deps.c > +++ b/arch/x86/kernel/cpu/cpuid-deps.c > @@ -92,6 +92,7 @@ static const struct cpuid_dep cpuid_deps[] = { > { X86_FEATURE_FRED, X86_FEATURE_LKGS }, > { X86_FEATURE_SPEC_CTRL_SSBD, X86_FEATURE_SPEC_CTRL }, > { X86_FEATURE_LASS, X86_FEATURE_SMAP }, > + { X86_FEATURE_INVLPGB, X86_FEATURE_PCID }, > {} > }; > > > base-commit: 2fb123664e61027830a6752a8e9235e7f7712504