mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] scsi: ufs: Add HCI capabilities sysfs group
Date: Wed, 7 Aug 2024 13:55:58 -0700	[thread overview]
Message-ID: <28624a6d-fdc7-4458-8e8f-f8d764cd4b5b@acm.org> (raw)
In-Reply-To: <20240804072109.2330880-3-avri.altman@wdc.com>

On 8/4/24 12:21 AM, Avri Altman wrote:
> +What:		/sys/bus/platform/drivers/ufshcd/ufshci_capabilities/capabilities

That path seems wrong to me. I think that "ufshcd" should be changed
into something like ${host_driver_name}/${ufshci_instance_name}. An 
example from a Pixel 8 device:

$ adb shell ls /sys/bus/platform/drivers/*ufs*
/sys/bus/platform/drivers/exynos-ufs:
13200000.ufs
module
uevent

/sys/bus/platform/drivers/ufshcd-hisi:
bind
uevent
unbind

> +What:		/sys/bus/platform/devices/*.ufs/ufshci_capabilities/capabilities
> +Date:		August 2024
> +Contact:	Avri Altman <avri.altman@wdc.com>
> +Description:
> +		Host Capabilities register group: host controller capabiities register.
> +		Symbol - CAP.  Offset: 0x00 - 0x03.

Please fix the spelling error that was already reported by Keoseong
Park. Otherwise this patch looks good to me.

Thanks,

Bart.

  reply	other threads:[~2024-08-07 20:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-04  7:21 [PATCH v2 0/2] scsi: ufs: Add host " Avri Altman
2024-08-04  7:21 ` [PATCH v2 1/2] scsi: ufs: Prepare to add HCI capabilities sysfs Avri Altman
2024-08-06 22:01   ` Bart Van Assche
2024-08-07  5:41     ` Avri Altman
2024-08-07 20:48   ` Bart Van Assche
2024-08-04  7:21 ` [PATCH v2 2/2] scsi: ufs: Add HCI capabilities sysfs group Avri Altman
2024-08-07 20:55   ` Bart Van Assche [this message]
2024-08-08 11:32     ` Avri Altman
2024-08-08 17:08       ` Bart Van Assche
     [not found] ` <CGME20240804072309epcas2p2309ebc15f20ca598a91fe30a3245200f@epcms2p1>
2024-08-06  2:04   ` [PATCH v2 1/2] scsi: ufs: Prepare to add HCI capabilities sysfs Keoseong Park
     [not found] ` <CGME20240804072321epcas2p3fbbda7858fe25be16ef6acb64b7a524e@epcms2p3>
2024-08-06  2:06   ` [PATCH v2 2/2] scsi: ufs: Add HCI capabilities sysfs group Keoseong Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28624a6d-fdc7-4458-8e8f-f8d764cd4b5b@acm.org \
    --to=bvanassche@acm.org \
    --cc=avri.altman@wdc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®