From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C5D1C433E0 for ; Tue, 16 Jun 2020 21:25:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 410D420679 for ; Tue, 16 Jun 2020 21:25:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pGXke/vH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbgFPVZq (ORCPT ); Tue, 16 Jun 2020 17:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725967AbgFPVZl (ORCPT ); Tue, 16 Jun 2020 17:25:41 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65699C06174E; Tue, 16 Jun 2020 14:25:41 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id t74so6690lff.2; Tue, 16 Jun 2020 14:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hVdt6AXODFboWYabzNYMUEMNfFhxWDLJgJNzupuDcUc=; b=pGXke/vHvJbeYRKgVgjKaAGVVWlGt2Zlyo2sdvyXiMnK0Z2k8tgv2lOmK3fZQ5hdsI U4DNuVOz26tSkoxV4Ag5qMiLAyX4PcDc4Kwb+qmh37FoEIuz6kLdjs8xZeQW/TddmCaz VqubvdibZYToYvyAx2s73doWSZTWfyqCWWYxynDtbAS/kceU1iF/iPq7spKDD1F++TR2 tqpVmFBKfTyiWTJJWSfSty29m2Cw2Zu8zCGrgWv27paZjVfmqoLuj6ecp79wYKFE5Rsq raFGS92UaPIIwTD9+eOyMB8H1nWKgBqT5eZR53OC+oCM6hXIibX60d5YZN4fE8H1M/1P hXRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hVdt6AXODFboWYabzNYMUEMNfFhxWDLJgJNzupuDcUc=; b=cOg5NjSYlMwIrA6da8cbCtfGXL91wa4qoR+vtOQTGywBQOiykwAxQ4wGLyL2iygU/M CdB0eagAWYDWM8DcvCuqk9Zo18vkDcMzVqHwYQvePd+Or+PkwlzzA5UghULNkkt/b+fr OuOyBTQ74pVLBVsdcOGpG4ArDUR7O5+l1lIZiud+PyGQVcZlXPKD41wubL6p1H9xwp+K hYDZ5y26atw3LV0GvGFqx4Dnsc7S2JkYjUcn9m06ykFVupHucT9ZrLG5N1cwmNZMIFFJ SUod8cH4xcrmp2sBSaGSiWCYnCBNkvmqbPra6zP30cAWJNIQ5ZpK938r/V7qG7kXuOy3 e12A== X-Gm-Message-State: AOAM533EVVhB5SSQQzSLhAPJGiTkM59MuGz8aRekQ6vNKFpKBBuHh+Q7 k22e63ouAJcwIpnyv40nsYs= X-Google-Smtp-Source: ABdhPJxJ16gTDiEqo2xtKJxQd/8rm2iOA6GJb7n/d5HI200HY+0KKnM4psUU1+k67xApqZgL9p/Cqg== X-Received: by 2002:ac2:544b:: with SMTP id d11mr2714926lfn.157.1592342739859; Tue, 16 Jun 2020 14:25:39 -0700 (PDT) Received: from [192.168.2.145] (79-139-237-54.dynamic.spd-mgts.ru. [79.139.237.54]) by smtp.googlemail.com with ESMTPSA id 11sm1336289lfz.78.2020.06.16.14.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 14:25:39 -0700 (PDT) Subject: Re: [PATCH v2 0/5] 180 degrees rotation support for NVIDIA Tegra DRM To: Laurent Pinchart Cc: Emil Velikov , Thierry Reding , Thomas Zimmermann , Derek Basehore , Sam Ravnborg , Sean Paul , linux-tegra@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel References: <20200614200121.14147-1-digetx@gmail.com> <8f789ef5-bebf-c869-784d-afda70fc1fb8@gmail.com> <646b3f37-0f72-7f3b-388f-f71dbcdd5c84@gmail.com> <20200616174558.GA913@pendragon.ideasonboard.com> From: Dmitry Osipenko Message-ID: <2862a842-322e-34d6-6826-3b3352f98230@gmail.com> Date: Wed, 17 Jun 2020 00:25:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200616174558.GA913@pendragon.ideasonboard.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 16.06.2020 20:45, Laurent Pinchart пишет: > On Tue, Jun 16, 2020 at 08:20:57PM +0300, Dmitry Osipenko wrote: >> 16.06.2020 18:48, Emil Velikov пишет: >>> On Tue, 16 Jun 2020 at 12:40, Dmitry Osipenko wrote: >>>> >>>> 16.06.2020 01:26, Emil Velikov пишет: >>>>> Hi Dmitry, >>>>> >>>>> On Mon, 15 Jun 2020 at 08:28, Dmitry Osipenko wrote: >>>>>> >>>>>> Hello! >>>>>> >>>>>> This series adds 180° display plane rotation support to the NVIDIA Tegra >>>>>> DRM driver which is needed for devices that have display panel physically >>>>>> mounted upside-down, like Nexus 7 tablet device for example [1]. Since >>>>>> DRM panel rotation is a new thing for a userspace, currently only >>>>>> Opentegra Xorg driver handles the rotated display panel [2], but this >>>>>> is good enough for the start. >>>>>> >>>>>> Note that later on it should be possible to implement a transparent 180° >>>>>> display rotation for Tegra DRM driver which will remove the need to have >>>>>> a bleeding edge userspace that knows how to rotate display planes and I'm >>>>>> slowly working on it. For the starter we can go with the minimal rotation >>>>>> support, so it's not a blocker. >>>>>> >>>>>> This series is based on the work that was made by Derek Basehore for the >>>>>> Mediatek driver [3], his patch is included into this patchset. I added >>>>>> my tested-by tag to the Derek's patch. >>>>>> >>>>>> Please review and apply, thanks in advance! >>>>>> >>>>>> [1] https://patchwork.ozlabs.org/project/linux-tegra/patch/20200607154327.18589-3-digetx@gmail.com/ >>>>>> [2] https://github.com/grate-driver/xf86-video-opentegra/commit/28eb20a3959bbe5bc3a3b67e55977093fd5114ca >>>>>> [3] https://lkml.org/lkml/2020/3/5/1119 >>>>>> >>>>>> Changelog: >>>>>> >>>>>> v2: - Dropped "drm/panel: Set display info in panel attach" patch, which >>>>>> turned out to be obsolete now. >>>>>> >>>>>> - Renamed the cover-latter, hopefully this will fix the bouncing emails. >>>>>> >>>>>> Derek Basehore (1): >>>>>> drm/panel: Add helper for reading DT rotation >>>>>> >>>>>> Dmitry Osipenko (4): >>>>>> drm/panel: lvds: Set up panel orientation >>>>> >>>>> IMHO it's perfectly reasonable to report the panel orientation to >>>>> userspace, which can apply plane rotation as needed. >>>>> >>>>> Although I see that this series, alike Derek's, has a couple of issues: >>>>> - only a single panel driver is updated >>>>> - rotation is _not_ listed as supported property, in said panel >>>>> driver device-tree bindings >>>>> >>>>> My personal inclination is that we should aim for a comprehensive solution: >>>>> - wire all panel drivers, as currently documented (quick grep list below) >>>>> - document and wire-up the lvds and boe panels - as proposed by you >>>>> and Derek respectively >>>>> >>>>> HTH >>>>> Emil >>>>> >>>>> Documentation/devicetree/bindings/display/himax,hx8357d.txt:2 >>>>> Documentation/devicetree/bindings/display/ilitek,ili9225.txt:2 >>>>> Documentation/devicetree/bindings/display/ilitek,ili9341.txt:2 >>>>> Documentation/devicetree/bindings/display/ilitek,ili9486.yaml:2 >>>>> Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt:2 >>>>> Documentation/devicetree/bindings/display/panel/panel-common.yaml:2 >>>>> Documentation/devicetree/bindings/display/sitronix,st7586.txt:1 >>>>> Documentation/devicetree/bindings/display/sitronix,st7735r.yaml:2 >>>> >>>> Rotation is a common DT panel property that is described in the >>>> panel-common.yaml. >>> The property was introduced almost exclusively for tiny drm panels. >>> Those ones are a bit different from the rest (in panel/) - >>> MIPI-DBI/SPI w/o (not connected at least) an actual GPU. >>> >>> To make it a bit better, the rotation is seemingly performed in the >>> tiny driver itself ouch. >>> >>>> This property is supported by all panel bindings >>>> because these bindings inherent the common properties from the >>>> panel-common.yaml. >>>> >>> Seems like that was an unintentional change with the conversion to YAML. >>> Beforehand only a few selected panels had rotation. Upon closer look - >>> some panels do have follow-up fixes, to remove/limit the implicit >>> inclusion. >> >> Interesting.. my understanding that the rotation property is supposed to >> be a generic property which represents physical orientation of a display >> panel and hence it should be applicable to all panels. > > Adding a bit more food for thoughts, the DT rotation property for camera > sensor modules has recently been documented with lots of details. See > https://lore.kernel.org/linux-media/20200509090456.3496481-3-jacopo@jmondi.org/, > part of the documentation may be useful for panels. Thanks!