From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752625AbcLLNfs (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Dec 2016 08:35:48 -0500
Received: from mailout3.samsung.com ([203.254.224.33]:46641 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751798AbcLLNfq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Dec 2016 08:35:46 -0500
X-AuditID: cbfee61a-f79916d0000062de-a5-584ea7afaa6e
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kukjin Kim <kgene@kernel.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Sangbeom Kim <sbkim73@samsung.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: samsung: Remove tests of member address
Date: Mon, 12 Dec 2016 14:35:41 +0100
Message-id: <2863148.52BcI6omVF@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <1481363471-21364-1-git-send-email-krzk@kernel.org>
References: <1481363471-21364-1-git-send-email-krzk@kernel.org>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset=us-ascii
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t9jAd0Ny/0iDHoXsltcuXiIyWLqwyds
        Fm/ermGy6H/8mtni/PkN7BbfrnQwWWx6fI3V4vKuOWwWM87vY7I4/Kad1eLiii9MDtweGz43
        sXnsnHWX3WPTqk42j81L6j229AN5fVtWMXp83iQXwB7lZpORmpiSWqSQmpecn5KZl26rFBri
        pmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZGaABB+cA92AlfbsEt4zpTz6yFOxir5hybzZ7A+MU
        ti5GTg4JAROJW3PPMUHYYhIX7q0HinNxCAksZZTY3/yZFSQhJPCVUWL5DAMQm03ASmJi+ypG
        EFtEQFPi+t/vrCANzAK/mSTaj31kAUkICzhJHNp6FmwDi4CqxOaFTWAbeEEaWvrAhooKeEls
        2dcOFucUcJA4+GMfM8Qye4mpPVeh6gUlfky+BzaTWUBeYt/+qawQtpbE+p3HmSYwCsxCUjYL
        SdksJGULGJlXMUqkFiQXFCel5xrmpZbrFSfmFpfmpesl5+duYgTH5zOpHYwHd7kfYhTgYFTi
        4XVI9Y0QYk0sK67MPcQowcGsJMI7eZlfhBBvSmJlVWpRfnxRaU5q8SFGU6AHJzJLiSbnA1NH
        Xkm8oYm5ibmxgYW5paWJkZI4b+PsZ+FCAumJJanZqakFqUUwfUwcnFINjDtmhbV0hq7dqr+9
        /XDq+aQZVq4mp6U0Q8snPXi+ru2hGdvXSN6zUu/DalKv7HkwWfJmmP2lO7ukhGfs2spzeNW1
        5Yz2UhmP8kuUni+t03f9pPXWKZtfyVgzt7m6KOnMmYubz5hVfNwc/4nN6MHvObWZB0z2zvN4
        t+C91F6ZX1eidym/5ZnltV+JpTgj0VCLuag4EQC7z41a5QIAAA==
X-MTR: 20000000000000000@CPGS
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi,

On Saturday, December 10, 2016 11:51:11 AM Krzysztof Kozlowski wrote:
> The driver was checking for non-NULL address of struct's members:
>  - s3c_audio_pdata->type (union),
>  - s3c_audio_pdata->type.i2s (embedded struct).
> 
> This is pointless as these will be always non-NULL.  The 's3c_audio_pdata'
> is always initialized in static memory so it will be zeroed.
> Additionally the 'type' member was an union with only one member.
> 
> It is safe to reorganize the structures to get rid of useless union and
> checks for addresses to fix the coccinelle warning:
> 	>> sound/soc/samsung/i2s.c:1270:2-4: ERROR: test of a variable/field address
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics