From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7506221B9F6 for ; Sun, 26 Apr 2026 21:48:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777240085; cv=none; b=RUanHRs/ikSLkSpPqyeSS3PWEA23Y+wUiEY6jZOK9V1BYf21bLxPUQNsY+tQscpwFNBHWYS7vIh9s4oxQgbDixiOuh9y/3/78AmkphuOv4ZzucVOp6Jnl64oKUYejsaoTlqUEiuGWELzIpXuSwAdV68rqvY5l7kGle1HI1yMDag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777240085; c=relaxed/simple; bh=NvzxDfyhBY8HhpKlujoOhD2X7P7j0RP/UcBg8w+dASc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sm4nbWhRKnmXt1EJl7xCtoNRKbRk9NPvhKyrzi/UjkzqgeCTwc6eq7QPEO1w/LWc01K0x6fsMOCbcoWIjFn3gsUAfBz4zowca3ToVHLQ4YaTgK1HY7bu6UaG/3JBFGy2eRD5BULSBFKGEGa5qTyHGGwa6iUfCgOeXmc2yqyuOiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YCfr5suO; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IkKLt60a; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YCfr5suO"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IkKLt60a" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777240082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lya+idGqxu4DlV/pLONwdjLPocorK4fxVlb4E+6fg/I=; b=YCfr5suOEKP7qfopaJIw10JGnMAPzUp40TQk3hKE8HSvSjSPR7uk0ulo19R3AxqDOMtMj4 GE34EJ6MWLJt4RGhNu4TayF+h6aFEx4wDtrWN4nZaA2Idb/zSxdzPiuAa9DwpVA0Dlx9Ww t+B3nZXqMh4UllMhkl/QGKt5fStF50k= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-AW2CRkq4OCmshpJLgKPXWg-1; Sun, 26 Apr 2026 17:48:01 -0400 X-MC-Unique: AW2CRkq4OCmshpJLgKPXWg-1 X-Mimecast-MFC-AGG-ID: AW2CRkq4OCmshpJLgKPXWg_1777240080 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-43d1dea12aaso15818f8f.1 for ; Sun, 26 Apr 2026 14:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777240080; x=1777844880; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lya+idGqxu4DlV/pLONwdjLPocorK4fxVlb4E+6fg/I=; b=IkKLt60at9chVdJNk30U/f8SbSscrkRIpVRxLgLd6eETY+Q3zuYVTGzi21RiVjKq1a TS0eGG7sK6UXc9HYPV3hy5RN5B3nu312ui+b9ZOPmtsBMGPOGDBWv4uGOFLRnW6qTesS BrUvDQqK5LlM0MPmyP27aifXK+jP6Lcd4wsqj2exV1EKCKbUnLoON7zh3Hk8tSw42qsG Z/sN9Qzb2bBGyYMleAdcNtYR3Ysibef02JGeIu60yaSfdJfGg6eonhXIxDgCCHRItf3x DWRduwTtsezX3R4dVRBlJsuZFt73S42Yqbw96rzV8H9WWPIsiUdYtcwT0JnPXEeWjO4D CG9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777240080; x=1777844880; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lya+idGqxu4DlV/pLONwdjLPocorK4fxVlb4E+6fg/I=; b=bDnu+YUPejEE+cI+JK0oQhtDMG5iNUBPSLY3SpbZgZf8SW7Hs9tBBdAV5TlBR8shCF TVUIM6L8mtYD2iJV4Ra+RN5zcl+j5hm99FrF3VYEzcXComNNlRzc/ouSm3+jO9b8AExV C6KQ/WuWBiBhSwp7zAjg5BP7/xu8gKlf4Vfkm3Nqwq2CDdWw+ikVsteaAGriC5+A/Mzj Kw3sQZTUs5GqGMVJuvqToXgHaFM1gFDOBSMczRklPp4L/NEpKwUHME1EfcVXTj9gxJdB 8X3Qs33TTx8tS4bVM9qDLTgw+5IpTmRUtmrJVvgxjmimXUG0x2B08SY44+w2ffpgAnol mBPQ== X-Gm-Message-State: AOJu0Ywzi/2y18dQ+biujjNP0idRiWaLkh55ADPCiYM98pfAYP3Y4NDx DbxWPCiok4L82TzkFtNc/+ekQDc3PeoVuqDdsCMMmz+tXA6AlRO3ULMWasMrjhyXL2rJiDOt1Vv 5Y6cH1KbHhfFQLzqIAt3GKQSqqbv+Cwu94k62qZMh9D6qW0e3CVnyDJmhy/MR6kXWdpRX2D9a19 cBYFFvWSMdIc9QyBIDD+8BbjVUNBwlNxk2y+XrymeK3Rc= X-Gm-Gg: AeBDieteLw26RvsVlR9RN5PiJlLGqKwWcYuqXNMq52uW6zjLs30YDtfqj4jflC1cwha PE4d7cxgowQFoMUvYrI49qi0V+5zassBHwVFRsyRtEe2ZewIYPLgrpZr6t9Z1DicGGp5j0wW0bv aPEHrNubgJ66DDn6N4WimG3WQ6ORs0ve573X4LzxBm7K/jG8yrg3yt9Mg8QJNpoTpR3ywF4eRI/ B8qZBuJO+M9oRbJbIViHnYTPViK/dkkXBKyaB1f0581CCa1OKEXcFGc1mTTiYna3JqfdNxlg0PT 2LhHKV6C6jMvCUfaJXwGA0mWYksf8Eczrfl8fKBJredNQY/3z2xRejAEeWf+V5A94qG43miAV3c 4Yt4YwfiNq/xiSvhZhi10RG1ffCeim4ggk1XvVwPfiIlE1jgpT9SWMxUK X-Received: by 2002:a05:6000:420a:b0:43d:773d:78ff with SMTP id ffacd0b85a97d-43fe3e0b61bmr62764575f8f.27.1777240079920; Sun, 26 Apr 2026 14:47:59 -0700 (PDT) X-Received: by 2002:a05:6000:420a:b0:43d:773d:78ff with SMTP id ffacd0b85a97d-43fe3e0b61bmr62764530f8f.27.1777240079334; Sun, 26 Apr 2026 14:47:59 -0700 (PDT) Received: from redhat.com (IGLD-80-230-47-179.inter.net.il. [80.230.47.179]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e46898sm81019233f8f.27.2026.04.26.14.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 14:47:58 -0700 (PDT) Date: Sun, 26 Apr 2026 17:47:56 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Andrew Morton , David Hildenbrand , Vlastimil Babka , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Jason Wang , Andrea Arcangeli , Gregory Price , linux-mm@kvack.org, virtualization@lists.linux.dev, Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport Subject: [PATCH RFC v4 08/22] mm: use __GFP_ZERO in alloc_anon_folio Message-ID: <28642fd392362fff6d84d7d16acf9653c43cbcb3.1777223007.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Convert alloc_anon_folio() to pass __GFP_ZERO instead of zeroing at the callsite. Use vma_alloc_folio_user_addr() to pass the folio-aligned address for NUMA policy and the raw vmf->address for cache-friendly zeroing. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 --- mm/memory.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 07778814b4a8..83ec73791fae 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4662,7 +4662,8 @@ static struct folio *alloc_swap_folio(struct vm_fault *vmf) gfp = vma_thp_gfp_mask(vma); while (orders) { addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); - folio = vma_alloc_folio(gfp, order, vma, addr); + folio = vma_alloc_folio_user_addr(gfp, order, vma, addr, + vmf->address); if (folio) { if (!mem_cgroup_swapin_charge_folio(folio, vma->vm_mm, gfp, entry)) @@ -5176,10 +5177,11 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) goto fallback; /* Try allocating the highest of the remaining orders. */ - gfp = vma_thp_gfp_mask(vma); + gfp = vma_thp_gfp_mask(vma) | __GFP_ZERO; while (orders) { addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); - folio = vma_alloc_folio(gfp, order, vma, addr); + folio = vma_alloc_folio_user_addr(gfp, order, vma, addr, + vmf->address); if (folio) { if (mem_cgroup_charge(folio, vma->vm_mm, gfp)) { count_mthp_stat(order, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE); @@ -5187,15 +5189,6 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) goto next; } folio_throttle_swaprate(folio, gfp); - /* - * When a folio is not zeroed during allocation - * (__GFP_ZERO not used) or user folios require special - * handling, folio_zero_user() is used to make sure - * that the page corresponding to the faulting address - * will be hot in the cache after zeroing. - */ - if (user_alloc_needs_zeroing()) - folio_zero_user(folio, vmf->address); return folio; } next: -- MST