Re: [PATCH 1/2 RESEND v8] x86/kdump: always reserve the low 1M when the crashkernel option is specified

[lijiang <lijiang@redhat.com>]

在 2019年10月31日 18:47, Borislav Petkov 写道:
> On Thu, Oct 31, 2019 at 05:40:35PM +0800, lijiang wrote:
>> Maybe it should be a separate patch to fix the old compile warnings as follow.
>> And i should put the patch into this series.
> 
> Yes, maybe.
> 
>> commit d2091d1f4f67f1c38293b0e93fdbfefa766940cf (HEAD -> master)
>> Author: Lianbo Jiang <lijiang@redhat.com>
>> Date:   Thu Oct 31 15:48:02 2019 +0800
>>
>>     kexec: Fix i386 build warnings that missed declaration of struct kimage
>>     
>>     Kbuild test robot reported some build warnings, please refer to the
>>     Link below for details.
> 
> Explain here what the warnings are, why they trigger and how you're
> fixing it. How a commit message should look like is also explained in
> that document I pointed you at.
> 

OK, looks better('what-why-how'). I will improve the above log.

> Refering to some link is not what we do in commit messages.
> 
>>     Add a declaration of struct kimage to fix these compile warnings.
>>     
>>     Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
>>     Reported-by: kbuild test robot <lkp@intel.com>
>>     Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
>>     Link: https://lkml.org/lkml/2019/10/30/833
> 
> *NEVER* use lkml.org or any other external URL for refering to mail
> threads but *always* use our own
> 
> lkml.kernel.org/r/<Message-ID>
> 
> redirector. See other tip commits for an example.
> 

It's useful to me. Thanks.

>>> You can read
>>>
>>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>>>
>>> in the meantime, especially section
>>>
>>> "9) Don't get discouraged - or impatient"
>>>
>>> while waiting.
>>
>> OK. Thanks.
> 
> And make sure to read that whole document and also have a look at the
> process document
> 

I will read the above document carefully. But some of the rules in the document are
still easy to be forgot, maybe need to practice repeatedly.

> https://www.kernel.org/doc/html/latest/process/index.html
> 
> so that you can avoid such mistakes in the future.
> 

Good suggestions. Thank you so much.

Lianbo

> Thx.
>