mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael Niewöhner" <linux@mniewoehner.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>,
	"open list:ACPI" <linux-acpi@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI: utils: include UUID in _DSM evaluation warning
Date: Tue, 17 May 2022 20:25:43 +0200	[thread overview]
Message-ID: <28686e8d994c297a78fb816805cd3652a8f8c90a.camel@mniewoehner.de> (raw)
In-Reply-To: <CAJZ5v0h+kKwdntGPC5PP6N0ZRbRzLxuwcwTGm-PNBH6Z3mnETg@mail.gmail.com>

On Tue, 2022-05-17 at 16:49 +0200, Rafael J. Wysocki wrote:
> On Mon, May 16, 2022 at 7:25 PM Michael Niewöhner <linux@mniewoehner.de>
> wrote:
> > 
> > The _DSM evaluation warning in its current form is not very helpful, as
> > it lacks any specific information:
> >   ACPI: \: failed to evaluate _DSM (0x1001)
> > 
> > Thus, include the UUID of the missing _DSM:
> >   ACPI: \: failed to evaluate _DSM bf0212f2-... (0x1001)
> > 
> > Signed-off-by: Michael Niewöhner <linux@mniewoehner.de>
> > ---
> >  drivers/acpi/utils.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> > index d5cedffeeff9..7da993f5b6c3 100644
> > --- a/drivers/acpi/utils.c
> > +++ b/drivers/acpi/utils.c
> > @@ -681,7 +681,8 @@ acpi_evaluate_dsm(acpi_handle handle, const guid_t
> > *guid,
> > u64 rev, u64 func,
> > 
> >         if (ret != AE_NOT_FOUND)
> >                 acpi_handle_warn(handle,
> > -                               "failed to evaluate _DSM (0x%x)\n", ret);
> > +                               "failed to evaluate _DSM %pUb (0x%x)\n",
> > +                               ret, guid);
> 
> Shouldn't this be "guid, ret" ?

Ouch, yes ofc.

> Also, don't you want to print the
> value of the GUID rather than the address of its location?

Not sure what you mean tbh. Documentation/core-api/printk-formats.rst states
%pUb being the right format. lib/test_printf.c implements it that way, too.

> 
> And I don't think you need to break the line here.
> 
> > 
> >         return NULL;
> >  }
> > --
> > 2.34.1
> > 
> > 


  reply	other threads:[~2022-05-17 18:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 17:25 Michael Niewöhner
2022-05-17 14:49 ` Rafael J. Wysocki
2022-05-17 18:25   ` Michael Niewöhner [this message]
2022-05-17 18:28     ` Rafael J. Wysocki
2022-05-17 18:40       ` [PATCH v2] " Michael Niewöhner
2022-05-19 18:09         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28686e8d994c297a78fb816805cd3652a8f8c90a.camel@mniewoehner.de \
    --to=linux@mniewoehner.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®