mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Maulik Shah <maulik.shah@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] soc: qcom: rpmh-internal: fix kernel-doc issues in rpmh-internal.h
Date: Tue, 18 Aug 2026 13:50:26 +0200	[thread overview]
Message-ID: <286f9938-1cd7-4015-8971-1f6f4e23dbff@oss.qualcomm.com> (raw)
In-Reply-To: <20260802-b4b4-rpmh-kdoc-v1-1-0f5026293d9a@oss.qualcomm.com>

On 8/2/26 3:28 PM, Maulik Shah wrote:
> kernel-doc emits two warnings for rpmh-internal.h:
> 
>   Warning: drivers/soc/qcom/rpmh-internal.h:136 struct member 'ver' not described in 'rsc_drv'
>   Warning: drivers/soc/qcom/rpmh-internal.h:136 struct member 'regs' not described in 'rsc_drv'
> 
> Fix them by adding @ver and @regs entries to the struct rsc_drv
> documentation.
> 
> While at it, add a missing kernel-doc block for struct rsc_ver, and
> update the remaining struct kernel-doc comments (struct tcs_group,
> struct rpmh_request, struct rpmh_ctrlr, struct rsc_drv) to use the
> 'struct name -' format documented in
> Documentation/doc-guide/kernel-doc.rst.
> 
> No functional impact.
> 
> Assisted-by: Claude:claude-sonnet-5
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  reply	other threads:[~2026-08-18 11:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-02 13:28 [PATCH 0/3] soc: qcom: rpmh: fix kernel-doc issues Maulik Shah
2026-08-02 13:28 ` [PATCH 1/3] soc: qcom: rpmh-internal: fix kernel-doc issues in rpmh-internal.h Maulik Shah
2026-08-18 11:50   ` Konrad Dybcio [this message]
2026-08-02 13:28 ` [PATCH 2/3] soc: qcom: rpmh: fix kernel-doc issues in rpmh.c Maulik Shah
2026-08-18 11:53   ` Konrad Dybcio
2026-08-02 13:28 ` [PATCH 3/3] soc: qcom: rpmh-rsc: fix kernel-doc issues in rpmh-rsc.c Maulik Shah
2026-08-18 11:54   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=286f9938-1cd7-4015-8971-1f6f4e23dbff@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maulik.shah@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®