mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, linux-spdx@vger.kernel.org
Subject: Re: [GIT PULL] SPDX update for 5.2-rc3 - round 2
Date: Sun, 02 Jun 2019 08:04:11 -0700	[thread overview]
Message-ID: <2870be25585850e8968ed0e1237ac381a85b878c.camel@perches.com> (raw)
In-Reply-To: <20190602063905.GA14513@kroah.com>

On Sun, 2019-06-02 at 08:39 +0200, Greg KH wrote:
> The second patch fixes up a number of places in the tree where people
> mistyped the string "SPDX-License-Identifier".  Given that people can
> not even type their own name all the time without mistakes, this was
> bound to happen, and odds are, we will have to add some type of check
> for this to checkpatch.pl to catch this happening in the future.
[]
>  arch/arm/kernel/bugs.c                | 2 +-
>  drivers/crypto/ux500/cryp/Makefile    | 2 +-
>  drivers/phy/st/phy-stm32-usbphyc.c    | 2 +-
>  drivers/pinctrl/sh-pfc/pfc-r8a77980.c | 2 +-
>  lib/test_stackinit.c                  | 2 +-
>  sound/soc/codecs/max9759.c            | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)

checkpatch already gives a warning for each of these files
except the Makefile as it has no filename extension.
Filenames without extensions are not checked.

$ ./scripts/checkpatch.pl -f --types=SPDX_LICENSE_TAG --nosummary --terse \
	arch/arm/kernel/bugs.c \
	drivers/crypto/ux500/cryp/Makefile \
	drivers/phy/st/phy-stm32-usbphyc.c \
	drivers/pinctrl/sh-pfc/pfc-r8a77980.c \
	lib/test_stackinit.c \
	sound/soc/codecs/max9759.c
arch/arm/kernel/bugs.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
drivers/phy/st/phy-stm32-usbphyc.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
drivers/pinctrl/sh-pfc/pfc-r8a77980.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
lib/test_stackinit.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
sound/soc/codecs/max9759.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1



  parent reply	other threads:[~2019-06-02 15:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02  6:39 Greg KH
2019-06-02 12:03 ` Masahiro Yamada
2019-06-02 17:15   ` Greg KH
2019-06-03  0:15     ` Masahiro Yamada
2019-06-03  7:38       ` Greg KH
2019-06-02 15:04 ` Joe Perches [this message]
2019-06-02 17:25 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2870be25585850e8968ed0e1237ac381a85b878c.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spdx@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®