From: "Zhu, Lingshan" <lingshan.zhu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, dan.daly@intel.com,
cunming.liang@intel.com, tiwei.bie@intel.com,
jason.zeng@intel.com, zhiyuan.lv@intel.com
Subject: Re: [RFC 1/2] vhost: IFC VF hardware operation layer
Date: Tue, 29 Oct 2019 15:36:22 +0800 [thread overview]
Message-ID: <2879733b-8b5f-3740-7b61-3f2043d3eaca@intel.com> (raw)
In-Reply-To: <20191015190649.54ddc91c@hermes.lan>
On 10/16/2019 10:06 AM, Stephen Hemminger wrote:
> On Wed, 16 Oct 2019 09:03:17 +0800 Zhu Lingshan
> <lingshan.zhu@intel.com> wrote:
>> + IFC_INFO(&dev->dev, "PCI capability mapping:\n" + "common cfg:
>> %p\n" + "notify base: %p\n" + "isr cfg: %p\n" + "device cfg: %p\n" +
>> "multiplier: %u\n", + hw->common_cfg, + hw->notify_base, + hw->isr, +
>> hw->dev_cfg, + hw->notify_off_multiplier);
> Since kernel messages go to syslog, syslog does not handle multi-line
> messages very well. This should be a single line. Also, this is the
> kind of message that should be at the debug level; something that is
> useful to the driver developers but not something that needs to be
> filling up every end users log.
Hi Stephen
Thanks for your comments, I have changed them in RFC V2, will send the
patchset soon.
Thanks,
BR
Zhu Lingshan
next prev parent reply other threads:[~2019-10-29 7:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 1:03 [RFC 0/2] Intel IFC VF driver for vdpa Zhu Lingshan
2019-10-16 1:03 ` [RFC 1/2] vhost: IFC VF hardware operation layer Zhu Lingshan
2019-10-16 2:04 ` Stephen Hemminger
2019-10-16 2:06 ` Stephen Hemminger
2019-10-29 7:36 ` Zhu, Lingshan [this message]
2019-10-16 1:03 ` [RFC 2/2] vhost: IFC VF vdpa layer Zhu Lingshan
2019-10-16 9:53 ` Simon Horman
2019-10-21 8:48 ` Zhu, Lingshan
2019-10-16 1:10 [RFC 0/2] Intel IFC VF driver for vdpa Zhu Lingshan
2019-10-16 1:10 ` [RFC 1/2] vhost: IFC VF hardware operation layer Zhu Lingshan
2019-10-16 9:53 ` Simon Horman
2019-10-21 9:55 ` Zhu, Lingshan
2019-10-21 16:31 ` Simon Horman
2019-10-22 1:32 ` Jason Wang
2019-10-22 6:48 ` Zhu Lingshan
2019-10-23 10:13 ` Simon Horman
2019-10-23 10:36 ` Jason Wang
2019-10-23 17:11 ` Simon Horman
2019-10-16 1:30 [RFC 0/2] Intel IFC VF driver for vdpa Zhu Lingshan
2019-10-16 1:30 ` [RFC 1/2] vhost: IFC VF hardware operation layer Zhu Lingshan
2019-10-16 8:40 ` Jason Wang
2019-10-21 10:00 ` Zhu, Lingshan
2019-10-21 10:35 ` Jason Wang
2019-10-16 8:45 ` Jason Wang
2019-10-21 9:57 ` Zhu, Lingshan
2019-10-21 10:21 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2879733b-8b5f-3740-7b61-3f2043d3eaca@intel.com \
--to=lingshan.zhu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=cunming.liang@intel.com \
--cc=dan.daly@intel.com \
--cc=jason.zeng@intel.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®