From: Pedro Tammela <pctammela@mojatatu.com>
To: Min-Hua Chen <minhuadotchen@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE
Date: Fri, 2 Jun 2023 22:07:17 -0300 [thread overview]
Message-ID: <28802979-d237-1c9c-ad05-10aaa8f46b48@mojatatu.com> (raw)
In-Reply-To: <20230602235210.91262-1-minhuadotchen@gmail.com>
On 02/06/2023 20:52, Min-Hua Chen wrote:
> This patch fixes the following sparse warning:
>
> net/sched/sch_api.c:2305:1: sparse: warning: symbol 'tc_skip_wrapper' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
LGTM,
Acked-by: Pedro Tammela <pctammela@mojatatu.com>
> ---
> net/sched/sch_api.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
> index 014209b1dd58..9ea51812b9cf 100644
> --- a/net/sched/sch_api.c
> +++ b/net/sched/sch_api.c
> @@ -2302,7 +2302,9 @@ static struct pernet_operations psched_net_ops = {
> .exit = psched_net_exit,
> };
>
> +#if IS_ENABLED(CONFIG_RETPOLINE)
> DEFINE_STATIC_KEY_FALSE(tc_skip_wrapper);
> +#endif
>
> static int __init pktsched_init(void)
> {
next prev parent reply other threads:[~2023-06-03 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 23:52 Min-Hua Chen
2023-06-03 1:07 ` Pedro Tammela [this message]
2023-06-04 16:58 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28802979-d237-1c9c-ad05-10aaa8f46b48@mojatatu.com \
--to=pctammela@mojatatu.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minhuadotchen@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®