mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>,
	linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Cc: Joe Perches <joe@perches.com>, "Andrew F. Davis" <afd@ti.com>,
	Arvind Yadav <arvind.yadav.cs@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions
Date: Tue, 28 Nov 2017 11:15:37 +0100	[thread overview]
Message-ID: <28816ce9-9d62-7d61-1889-64407eececca@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1711281026410.3443@hadrien>

>>> Many people do not know that a generic kmalloc does a
>>> dump_stack() on OOM.
>>
>> This is another interesting information, isn't it?
>>
>> It is expected that the function “devm_kzalloc” has got a similar property.
> 
> 
> You don't have to expect this.  Go look at the definition of devm_kzalloc
> and see whether it has the property or not.

I find that the corresponding documentation of these programming interfaces
is incomplete for a desired format which could be different than C source code.

https://elixir.free-electrons.com/linux/v4.15-rc1/source/include/linux/device.h#L657
https://elixir.free-electrons.com/linux/v4.15-rc1/source/drivers/base/devres.c#L763
https://www.kernel.org/doc/html/latest/driver-api/basics.html#c.devm_kmalloc

Can the Coccinelle software help more to determine desired function properties?


>> For which hardware and software combinations would you like to see
>> facts there?
> 
> This is not for Joe to decide,

This view is fine in principle.


> it's for the person who receives the patch to decide.

I am curious on further comments from these contributors.


> You could start with the ones for which the code actually compiles,
> using the standard make file and no special options, and a
> recent version of gcc.

The variation space could become too big to handle for me (alone).
How will this aspect evolve further?

Regards,
Markus

  reply	other threads:[~2017-11-28 10:17 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-26 18:55 [PATCH] " SF Markus Elfring
2017-11-27 16:43 ` Andrew F. Davis
2017-11-27 17:27   ` SF Markus Elfring
2017-11-27 17:44     ` Ladislav Michl
2017-11-27 18:12       ` SF Markus Elfring
2017-11-27 18:56         ` Geert Uytterhoeven
2017-11-27 19:22         ` Ladislav Michl
2017-11-27 22:20           ` Ladislav Michl
2017-11-27 19:07   ` [PATCH] " Joe Perches
2017-11-27 21:33     ` Andrew F. Davis
2017-11-27 21:45       ` Ladislav Michl
2017-11-27 21:48     ` SF Markus Elfring
2017-11-28  1:45       ` Joe Perches
2017-11-28  7:41         ` SF Markus Elfring
2017-11-28  7:49           ` Julia Lawall
2017-11-28  8:49             ` SF Markus Elfring
2017-11-28  9:26               ` Julia Lawall
2017-11-28  9:56                 ` SF Markus Elfring
2017-11-28  8:04           ` Joe Perches
2017-11-28  8:49             ` Ladislav Michl
2017-11-28  9:11             ` SF Markus Elfring
2017-11-28  9:28               ` Julia Lawall
2017-11-28 10:15                 ` SF Markus Elfring [this message]
2017-11-28 10:23                   ` Ladislav Michl
2017-11-28 10:50                     ` SF Markus Elfring
2017-11-28 11:41                       ` Ladislav Michl
2017-11-28 12:13                         ` SF Markus Elfring
2017-11-28 17:50                           ` Ladislav Michl
2017-11-28 18:09                             ` SF Markus Elfring
2017-11-28 14:36                     ` Joe Perches
2017-12-03 18:20             ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28816ce9-9d62-7d61-1889-64407eececca@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=afd@ti.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=joe@perches.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome