From: sasa bogicevic <brutallesale@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: bhelgaas@google.com, lenb@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:pci:hotplug Fix space prohibited between function name and open parenthesis '('
Date: Sun, 29 Nov 2015 09:45:27 +0100 [thread overview]
Message-ID: <2881C4B7-AF00-42BD-A16E-6FFD3EC9A93C@gmail.com> (raw)
In-Reply-To: <1448566598.18647.12.camel@perches.com>
> On Nov 26, 2015, at 8:36 PM, Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2015-11-26 at 16:50 +0100, Bogicevic Sasa wrote:
>> This fixes all errors "space prohibited between function name and
>> open parenthesis '(' " in all files in drivers/pci/hotplug folder
>
> It's good when sending this sort of patch to add a bit of
> description like "git diff -w shows no differences" and that
> using scripts/objdiff also shows no difference.
>
> Doing so shows that you've done a bit more than a mechanical
> transformation using something like:
>
> $ ./scripts/checkpatch -f --types=spacing --fix-inplace <files>
>
> and that you have verified your changes too.
> Ah ok, thanks for the info. Ill explore some more on what else can checkpatch.pl can do and resend all that needs to be corrected in that folder.
Thanks, Sasa
prev parent reply other threads:[~2015-11-29 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 15:50 Bogicevic Sasa
2015-11-26 19:36 ` Joe Perches
2015-11-29 8:45 ` sasa bogicevic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2881C4B7-AF00-42BD-A16E-6FFD3EC9A93C@gmail.com \
--to=brutallesale@gmail.com \
--cc=bhelgaas@google.com \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®