From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, robin.randhawa@arm.com,
Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
charles.garcia-tobin@arm.com, arvind.chauhan@arm.com, nm@ti.com
Subject: Re: [PATCH] cpufreq: cpu0: Free parent node for error cases
Date: Thu, 02 May 2013 13:58:09 +0200 [thread overview]
Message-ID: <2882677.ddYllFuZlK@vostro.rjw.lan> (raw)
In-Reply-To: <20130502024849.GF3442@S2101-09.ap.freescale.net>
On Thursday, May 02, 2013 10:48:50 AM Shawn Guo wrote:
> On Wed, May 01, 2013 at 10:34:43AM +0530, Viresh Kumar wrote:
> > We are freeing parent node in success cases but not in failure cases. Lets do
> > it.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > drivers/cpufreq/cpufreq-cpu0.c | 13 ++++++++-----
> > 1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
> > index 3ab8294..c025714 100644
> > --- a/drivers/cpufreq/cpufreq-cpu0.c
> > +++ b/drivers/cpufreq/cpufreq-cpu0.c
> > @@ -189,7 +189,8 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
> >
> > if (!np) {
> > pr_err("failed to find cpu0 node\n");
> > - return -ENOENT;
> > + ret = -ENOENT;
> > + goto out_put_parent;
> > }
> >
> > cpu_dev = &pdev->dev;
> > @@ -199,7 +200,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
> > if (IS_ERR(cpu_clk)) {
> > ret = PTR_ERR(cpu_clk);
> > pr_err("failed to get cpu0 clock: %d\n", ret);
> > - goto out_put_node;
> > + goto out_put_np;
> > }
> >
> > cpu_reg = devm_regulator_get(cpu_dev, "cpu0");
> > @@ -211,13 +212,13 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
> > ret = of_init_opp_table(cpu_dev);
> > if (ret) {
> > pr_err("failed to init OPP table: %d\n", ret);
> > - goto out_put_node;
> > + goto out_put_np;
> > }
> >
> > ret = opp_init_cpufreq_table(cpu_dev, &freq_table);
> > if (ret) {
> > pr_err("failed to init cpufreq table: %d\n", ret);
> > - goto out_put_node;
> > + goto out_put_np;
> > }
> >
> > of_property_read_u32(np, "voltage-tolerance", &voltage_tolerance);
> > @@ -262,8 +263,10 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
> >
> > out_free_table:
> > opp_free_cpufreq_table(cpu_dev, &freq_table);
> > -out_put_node:
> > +out_put_np:
>
> Unnecessary renaming brings unnecessary diffstat?
Yeah, I'd prefer only changes that are essential here.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2013-05-02 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 5:04 Viresh Kumar
2013-05-02 2:48 ` Shawn Guo
2013-05-02 11:58 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2882677.ddYllFuZlK@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=arvind.chauhan@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=patches@linaro.org \
--cc=robin.randhawa@arm.com \
--cc=shawn.guo@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®