mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Siddh Raman Pant <siddh.raman.pant@oracle.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "cve@kernel.org" <cve@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gregkh@kernel.org" <gregkh@kernel.org>
Subject: Re: CVE-2026-63985: ethtool: eeprom: add more safeties to EEPROM Netlink fallback
Date: Thu, 30 Jul 2026 12:45:14 +0000	[thread overview]
Message-ID: <288bcae3fed67bac04b90922cca0f03d7bbfdfcf.camel@oracle.com> (raw)
In-Reply-To: <2026071903-CVE-2026-63985-56d0@gregkh>

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

On Sun, 19 Jul 2026 16:57:25 +0200, Greg Kroah-Hartman wrote:
> ethtool: eeprom: add more safeties to EEPROM Netlink fallback
> 
> The Netlink fallback path for reading module EEPROM
> (fallback_set_params()) validates that offset < eeprom_len,
> but does not check that offset + length stays within eeprom_len.
> The ioctl equivalent (ethtool_get_any_eeprom() in ioctl.c) has
> always enforced both bounds:
> 
>   if (eeprom.offset + eeprom.len > total_len)
>       return -EINVAL;
> 
> This could lead to surprises in both drivers and device FW.
> Add the missing offset + length validation to fallback_set_params(),
> mirroring the ioctl.
> 
> Similarly - ethtool core in general, and ethtool_get_any_eeprom()
> in particular tries to zero-init all buffers passed to the drivers
> to avoid any extra work of zeroing things out. eeprom_fallback()
> uses a plain kmalloc(), change it to zalloc.
> 
> The Linux kernel CVE team has assigned CVE-2026-63985 to this issue.

IIUC this is a defensive fix. Does it fix any reported problem for it
to be a CVE?

Thanks,
Siddh

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

       reply	other threads:[~2026-07-30 12:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2026071903-CVE-2026-63985-56d0@gregkh>
2026-07-30 12:45 ` Siddh Raman Pant [this message]
2026-07-30 12:49   ` gregkh
2026-07-31  5:14     ` Siddh Raman Pant
2026-07-31  5:39       ` gregkh
2026-07-31  7:11         ` Siddh Raman Pant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=288bcae3fed67bac04b90922cca0f03d7bbfdfcf.camel@oracle.com \
    --to=siddh.raman.pant@oracle.com \
    --cc=cve@kernel.org \
    --cc=gregkh@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®