From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Siddh Raman Pant <code@siddh.me>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Suman Ghosh <sumang@marvell.com>, netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
syzbot+bbe84a4010eeea00982d
<syzbot+bbe84a4010eeea00982d@syzkaller.appspotmail.com>
Subject: Re: [PATCH net-next v3 1/2] nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local
Date: Wed, 6 Dec 2023 09:48:46 +0100 [thread overview]
Message-ID: <288fa09c-a140-4939-bdfb-767f8ff98f14@linaro.org> (raw)
In-Reply-To: <18c3b245f39.5eac9b5898943.4628342226240608054@siddh.me>
On 05/12/2023 19:01, Siddh Raman Pant wrote:
> On Tue, 05 Dec 2023 22:57:28 +0530, Krzysztof Kozlowski wrote:
>>>> Mismatched order with get. Unwinding is always in reversed order. Or
>>>> maybe other order is here on purpose? Then it needs to be explained.
>>>
>>> Yes, local_release() will free local, so local->dev cannot be accessed.
>>> Will add a comment.
>>
>> So the problem is just storing the pointer? That's not really the valid
>> reason.
>
> Oops, my bad. What would be the valid reason? (if any)
Just store the local->dev pointer and use correct order.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-06 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 13:08 [PATCH net-next v3 0/2] nfc: Fix UAF during datagram sending caused by missing refcounting Siddh Raman Pant
2023-12-04 13:08 ` [PATCH net-next v3 1/2] nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local Siddh Raman Pant
2023-12-05 11:04 ` [EXT] " Suman Ghosh
2023-12-05 16:40 ` Krzysztof Kozlowski
2023-12-05 17:21 ` Siddh Raman Pant
2023-12-05 17:24 ` Siddh Raman Pant
2023-12-05 17:27 ` Krzysztof Kozlowski
2023-12-05 18:01 ` Siddh Raman Pant
2023-12-06 8:48 ` Krzysztof Kozlowski [this message]
2023-12-04 13:08 ` [PATCH net-next v3 2/2] nfc: Do not send datagram if socket state isn't LLCP_BOUND Siddh Raman Pant
2023-12-05 11:04 ` [EXT] " Suman Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288fa09c-a140-4939-bdfb-767f8ff98f14@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=code@siddh.me \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sumang@marvell.com \
--cc=syzbot+bbe84a4010eeea00982d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®