From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E84C43334 for ; Thu, 2 Jun 2022 06:37:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231270AbiFBGhD (ORCPT ); Thu, 2 Jun 2022 02:37:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231250AbiFBGhB (ORCPT ); Thu, 2 Jun 2022 02:37:01 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96BE21E4521 for ; Wed, 1 Jun 2022 23:36:57 -0700 (PDT) Received: from kwepemi500007.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LDGTt2WN3zgYkH; Thu, 2 Jun 2022 14:35:14 +0800 (CST) Received: from kwepemm600013.china.huawei.com (7.193.23.68) by kwepemi500007.china.huawei.com (7.221.188.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 2 Jun 2022 14:36:55 +0800 Received: from [10.174.178.46] (10.174.178.46) by kwepemm600013.china.huawei.com (7.193.23.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 2 Jun 2022 14:36:54 +0800 Subject: Re: [PATCH -next] ubifs: Fix some kernel-doc comments To: Yang Li , CC: , , "Abaci Robot" References: <20220602055233.26161-1-yang.lee@linux.alibaba.com> From: Zhihao Cheng Message-ID: <2890dd1a-76a9-2345-d955-84f9888de4bd@huawei.com> Date: Thu, 2 Jun 2022 14:36:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20220602055233.26161-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600013.china.huawei.com (7.193.23.68) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, maybe we should change them like this: > diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c > index 75dab0ae3939..16857d4e9aa8 100644 > --- a/fs/ubifs/journal.c > +++ b/fs/ubifs/journal.c > @@ -1201,9 +1201,12 @@ int ubifs_jnl_xrename(struct ubifs_info *c, const struct inode *fst_dir, > * ubifs_jnl_rename - rename a directory entry. > * @c: UBIFS file-system description object > * @old_dir: parent inode of directory entry to rename > - * @old_dentry: directory entry to rename > + * @old_inode: parent inode to rename old_inode: directory entry's inode to rename > + * @old_nm: name of old inode to rename old_nm: name of the old directory entry to rename > * @new_dir: parent inode of directory entry to rename > - * @new_dentry: new directory entry (or directory entry to replace) > + * @new_inode: new inode to rename new_inode: new directory entry's inode (or directory entry's inode to replace) > + * @new_nm: name of new inode to rename new_name: name of the new directory entry to rename > + * @whiteout: whiteout inode > * @sync: non-zero if the write-buffer has to be synchronized > * > * This function implements the re-name operation which may involve writing up >