From: David Brownell <david-b@pacbell.net>
To: "Alan Stern" <stern@rowland.harvard.edu>,
"Michał Nazarewicz" <m.nazarewicz@samsung.com>
Cc: Greg KH <greg@kroah.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kernel development list <linux-kernel@vger.kernel.org>,
Dries Van Puymbroeck <Dries.VanPuymbroeck@dekimo.com>
Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number
Date: Tue, 20 Jul 2010 08:01:37 -0700 (PDT) [thread overview]
Message-ID: <289287.8629.qm@web180303.mail.gq1.yahoo.com> (raw)
In-Reply-To: <op.vf4vrwa67p4s8u@pikus>
--- On Tue, 7/20/10, Michał Nazarewicz <m.nazarewicz@samsung.com> wrote:
> > Plus, you seem to be overlooking the basic need
> > (for userspace) to manage these IDs so they're
> > properly unique. Two gadgets should never end
> up
> > using the same serial number.
>
> I'm not overlooking that. I simply consider that a
> separate issue.
> Driver should provide some kind of default
It can't do that and guarantee uniqueness.
(Unless you consult the random number system,
which may not be available that early, and is
in any case not appropriate for this task.
Your concept is (still/again) broken.
(just like File
> Storage
> Gadget) and the fact that user space should
> override it is another
> matter in my opinion.
The value must come from userspace in the first
place, else it can't be correctly managed!!
>
next prev parent reply other threads:[~2010-07-20 15:01 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 9:17 [PATCH 1/2] " Michal Nazarewicz
2010-07-01 9:17 ` [PATCH 2/2] " Michal Nazarewicz
2010-07-01 10:27 ` [PATCH 1/2] " Michał Nazarewicz
2010-07-01 13:42 ` [PATCHv2 " Michal Nazarewicz
2010-07-01 13:42 ` [PATCHv2 2/2] USB: gadget: g_multi: code clean up and refactoring Michal Nazarewicz
2010-07-08 18:34 ` [PATCHv2 1/2] USB: gadget: mass/file storage: set serial number Greg KH
2010-07-08 18:58 ` Michał Nazarewicz
2010-07-08 19:03 ` Greg KH
2010-07-08 19:31 ` David Brownell
2010-07-08 20:02 ` Michał Nazarewicz
2010-07-08 20:20 ` David Brownell
2010-07-08 20:27 ` Michał Nazarewicz
2010-07-08 20:52 ` [PATCHv3 1/3] " Michal Nazarewicz
2010-07-08 20:52 ` [PATCHv3 2/3] USB: Add a serial number parameter to g_file_storage module Michal Nazarewicz
2010-07-08 20:52 ` [PATCHv3 3/3] USB: gadget: g_multi: code clean up and refactoring Michal Nazarewicz
2010-07-09 19:04 ` [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number Greg KH
2010-07-17 23:01 ` Michał Nazarewicz
2010-07-17 23:57 ` David Brownell
2010-07-19 8:58 ` Michał Nazarewicz
2010-07-19 10:08 ` David Brownell
2010-07-19 12:07 ` Michał Nazarewicz
2010-07-19 14:19 ` Alan Stern
2010-07-19 15:02 ` Michał Nazarewicz
2010-07-19 16:14 ` Alan Stern
2010-07-19 16:26 ` Michał Nazarewicz
2010-07-19 17:06 ` Alan Stern
2010-07-19 17:21 ` Michał Nazarewicz
2010-07-19 17:41 ` David Brownell
2010-07-20 8:41 ` Michał Nazarewicz
2010-07-20 14:07 ` Alan Stern
2010-07-20 14:43 ` Michał Nazarewicz
2010-07-20 15:01 ` David Brownell [this message]
2010-07-20 15:45 ` Michał Nazarewicz
2010-07-19 18:37 ` Alan Stern
2010-07-20 9:57 ` Michał Nazarewicz
2010-07-20 14:08 ` Alan Stern
2010-07-20 14:40 ` Michał Nazarewicz
2010-07-20 14:52 ` David Brownell
2010-07-20 15:02 ` Alan Stern
2010-07-19 14:44 ` David Brownell
2010-07-19 15:01 ` Michał Nazarewicz
2010-07-22 12:16 ` [PATCHv4 1/5] USB: gadget: composite: Better string override handling Michal Nazarewicz
2010-07-22 12:16 ` [PATCHv4 2/5] USB: gadget: Use new composite features in some gadgets Michal Nazarewicz
2010-07-22 12:16 ` [PATCHv4 3/5] USB: gadget: g_multi: code clean up and refactoring Michal Nazarewicz
2010-07-22 12:16 ` [PATCHv4 4/5] USB: gadget: g_fs: code cleanup Michal Nazarewicz
2010-07-22 12:16 ` [PATCHv4 5/5] USB: gadget: file_storage: serial parameter even if not test mode Michal Nazarewicz
2010-07-22 14:14 ` Alan Stern
2010-07-22 23:46 ` [PATCHv4 1/5] USB: gadget: composite: Better string override handling Greg KH
2010-07-23 9:04 ` Michał Nazarewicz
2010-07-27 6:53 ` David Brownell
2010-07-26 21:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=289287.8629.qm@web180303.mail.gq1.yahoo.com \
--to=david-b@pacbell.net \
--cc=Dries.VanPuymbroeck@dekimo.com \
--cc=greg@kroah.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome