mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Lin Ma" <linma@zju.edu.cn>
To: "Stephen Rothwell" <sfr@canb.auug.org.au>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Next Mailing List" <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warnings after merge of the v4l-dvb-next tree
Date: Mon, 28 Nov 2022 15:30:21 +0800 (GMT+08:00)	[thread overview]
Message-ID: <28948ae.13ac1.184bd24def0.Coremail.linma@zju.edu.cn> (raw)
In-Reply-To: <20221128152645.245141b6@canb.auug.org.au>

Hi Stephen,

> Hi all,
> 
> After merging the v4l-dvb-next tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> include/media/dvbdev.h:193: warning: Function parameter or member 'ref' not described in 'dvb_device'
> include/media/dvbdev.h:207: warning: expecting prototype for dvb_device_get(). Prototype was for dvb_device_put() instead
> 
> Introduced by commit
> 
>   0fc044b2b5e2 ("media: dvbdev: adopts refcnt to avoid UAF")
> 
> -- 

Oh my bad, it seems that I leave a typo there as forgetting about the function name in comment.

/**
 * dvb_device_get - Decrease dvb_device reference
 *
 * @dvbdev:	pointer to struct dvb_device
 */
void dvb_device_put(struct dvb_device *dvbdev);

Also the 'ref' field is not described with comment. Will send the fix to the v4l-dvb-next soon.

Thanks
Lin

  reply	other threads:[~2022-11-28  7:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28  4:26 Stephen Rothwell
2022-11-28  7:30 ` Lin Ma [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-28  4:19 Stephen Rothwell
2022-03-08  8:15 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28948ae.13ac1.184bd24def0.Coremail.linma@zju.edu.cn \
    --to=linma@zju.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®