From: Harry Wentland <harry.wentland@amd.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Leo Li <sunpeng.li@amd.com>,
amd-gfx@lists.freedesktop.org, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/amd/display: fix kernel-doc issues in dc.h
Date: Thu, 17 Nov 2022 14:39:46 -0500 [thread overview]
Message-ID: <28960f0b-97b9-7a41-9da3-188be25dd886@amd.com> (raw)
In-Reply-To: <20221117172009.28207-1-rdunlap@infradead.org>
On 11/17/22 12:20, Randy Dunlap wrote:
> Fix these kernel-doc complaints:
>
> drivers/gpu/drm/amd/display/dc/dc.h:505: warning: cannot understand function prototype: 'struct dc_clocks '
> dc.h:472: warning: Enum value 'MPC_SPLIT_AVOID' not described in enum 'pipe_split_policy'
> dc.h:472: warning: Enum value 'MPC_SPLIT_AVOID_MULT_DISP' not described in enum 'pipe_split_policy'
> dc.h:532: warning: Incorrect use of kernel-doc format: * @fw_based_mclk_switching
>
> Fixes: ea76895ffab1 ("drm/amd/display: Document pipe split policy")
> Fixes: 1682bd1a6b5f ("drm/amd/display: Expand kernel doc for DC")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dc.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff -- a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -458,15 +458,15 @@ enum pipe_split_policy {
> MPC_SPLIT_DYNAMIC = 0,
>
> /**
> - * @MPC_SPLIT_DYNAMIC: Avoid pipe split, which means that DC will not
> + * @MPC_SPLIT_AVOID: Avoid pipe split, which means that DC will not
> * try any sort of split optimization.
> */
> MPC_SPLIT_AVOID = 1,
>
> /**
> - * @MPC_SPLIT_DYNAMIC: With this option, DC will only try to optimize
> - * the pipe utilization when using a single display; if the user
> - * connects to a second display, DC will avoid pipe split.
> + * @MPC_SPLIT_AVOID_MULT_DISP: With this option, DC will only try to
> + * optimize the pipe utilization when using a single display; if the
> + * user connects to a second display, DC will avoid pipe split.
> */
> MPC_SPLIT_AVOID_MULT_DISP = 2,
> };
> @@ -497,7 +497,7 @@ enum dcn_zstate_support_state {
> };
>
> /**
> - * dc_clocks - DC pipe clocks
> + * struct dc_clocks - DC pipe clocks
> *
> * For any clocks that may differ per pipe only the max is stored in this
> * structure
> @@ -528,7 +528,7 @@ struct dc_clocks {
> bool fclk_prev_p_state_change_support;
> int num_ways;
>
> - /**
> + /*
> * @fw_based_mclk_switching
> *
> * DC has a mechanism that leverage the variable refresh rate to switch
next prev parent reply other threads:[~2022-11-17 19:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 17:20 Randy Dunlap
2022-11-17 19:39 ` Harry Wentland [this message]
2022-11-17 22:41 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28960f0b-97b9-7a41-9da3-188be25dd886@amd.com \
--to=harry.wentland@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®