From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2299CC77B7E for ; Thu, 25 May 2023 08:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240235AbjEYItB (ORCPT ); Thu, 25 May 2023 04:49:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235393AbjEYIs6 (ORCPT ); Thu, 25 May 2023 04:48:58 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 301BC9E for ; Thu, 25 May 2023 01:48:57 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EE7A61FB; Thu, 25 May 2023 01:49:41 -0700 (PDT) Received: from [10.162.43.6] (unknown [10.162.43.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 60BAD3F67D; Thu, 25 May 2023 01:48:55 -0700 (PDT) Message-ID: <2898744e-1a67-5a8f-6adc-462d7f362b93@arm.com> Date: Thu, 25 May 2023 14:18:52 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] arm64/cpufeature: Use helper for ECV CNTPOFF cpufeature Content-Language: en-US To: Mark Brown , Catalin Marinas , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230523-arm64-ecv-helper-v1-1-506dfb5fb199@kernel.org> From: Anshuman Khandual In-Reply-To: <20230523-arm64-ecv-helper-v1-1-506dfb5fb199@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/23 03:19, Mark Brown wrote: > The newly added support for ECV CNTPOFF open codes the recently added > helper ARM64_CPUID_FIELDS(), make use of the helper. No functional > change. > > Signed-off-by: Mark Brown Reviewed-by: Anshuman Khandual > --- > arch/arm64/kernel/cpufeature.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 7d7128c65161..27326f35b646 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -2235,11 +2235,7 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > .capability = ARM64_HAS_ECV_CNTPOFF, > .type = ARM64_CPUCAP_SYSTEM_FEATURE, > .matches = has_cpuid_feature, > - .sys_reg = SYS_ID_AA64MMFR0_EL1, > - .field_pos = ID_AA64MMFR0_EL1_ECV_SHIFT, > - .field_width = 4, > - .sign = FTR_UNSIGNED, > - .min_field_value = ID_AA64MMFR0_EL1_ECV_CNTPOFF, > + ARM64_CPUID_FIELDS(ID_AA64MMFR0_EL1, ECV, CNTPOFF) > }, > #ifdef CONFIG_ARM64_PAN > { > > --- > base-commit: 44c026a73be8038f03dbdeef028b642880cf1511 > change-id: 20230523-arm64-ecv-helper-c1665690b8b0 > > Best regards,