From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 843A3310625 for ; Mon, 29 Dec 2025 12:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767012055; cv=none; b=k++K0BNbSLG9tENXOFSKmM4ge+4+DIu+kDyhr5zXetgccad0EGLy8LCPsVTvEdmZXH2My7BuBNMsEYK09VudwFsTF4jqyHQbqfyjVwXQkuYiLWDnNHhAoQ7YqfjQcqYP36WuXLTsAbwDZ0P1d9mWXEDUP066D5zYrXbIkGx/K+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767012055; c=relaxed/simple; bh=BMUA0semQPdQwWq8oYFbaXkbuaSWosd1Tj0NnhmMRcI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iZuQeZhtdIJc6979BArpIM4ASDo3N5c0YIJjg6MEPW6UjJCYwTNxmnazRYIA45Qs0JGQEQ2t6vRg6memmBoQvfxq7/TekCfDkOQfepsm9RX2ZOljLCL6f++aMlkYn1f7lqA0w8+liFaxUhzLqphykuTfLsrhOyhV0A1lPC89Bs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I0YpcLF+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f0OI+HFI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I0YpcLF+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f0OI+HFI" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BT9e6YR4069042 for ; Mon, 29 Dec 2025 12:40:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BMUA0semQPdQwWq8oYFbaXkbuaSWosd1Tj0NnhmMRcI=; b=I0YpcLF+l4xY7iLD x/Ighc+rit7fGsxMnBPJLCy2p33WgXkEzyYHkhdzeSxuCqj4iftjoUSUqNt1txO9 b+eN9lgLdLYaAqMwjo9pd2zfKTg6SWQMMK75WVArc2W9pMpZgBgRzehmV6+2yzlF t5rKsUibuA+TdDIH7urLC2dfdxSPsKCBP96v1c5YeYHf7NaMKPopSSm7VDVdv+fC G4HLC95+x8p6b+hQOdJSFhkCVceQ8x9LnRhgOPQhZyV09rKaf1n6aCFRNyBEBZNS Gj2wce1m6vLOdONjHGF5gJ+ShDZVVEghdhE8Drg/kf+u9LwoF1KXmVFSpTxRCjsi icD5mw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba7u5m9tn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 12:40:52 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f357ab5757so41524791cf.0 for ; Mon, 29 Dec 2025 04:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767012052; x=1767616852; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BMUA0semQPdQwWq8oYFbaXkbuaSWosd1Tj0NnhmMRcI=; b=f0OI+HFIX7he7tNbbGcJxf3N4qChEJ2S0NyKY75NySvenPd9i0MATenk4pF37zYuMd oJGAHVOl9W159tRzlYE4qgNNBR1A/3wsHfQeUcr15olW1Fo9IfEuaK9BD0V5S9RHNDrQ yyubXa8HyKYieoxCuYVoPCL5D6efPKEV5lg22RbLVSpl5kg+wjC6y8CFeEcMp562oyzF IgM+tgBwXvpXNwpZaszlpxFbWcp5yv+++/dfSU8mqZaeupIezuzbopkHn9O9WAXykLN4 usewMkIuuMnFInOD5WxQyjYoXvahwqZLLV1Dr2+AdORbvf9bvukaPYKjfpiSr5wqg7hH 84AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767012052; x=1767616852; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BMUA0semQPdQwWq8oYFbaXkbuaSWosd1Tj0NnhmMRcI=; b=G4wepykCzVp+GBmQD2vJSa/9DRrvUzQ/8twma4TTySepbJ6CfQWvHHCHiOb0dbd3hg TSK/H7biYO6s6zZ8g6dAu+NaxnD20bRCUoyZEFXAApbfMtYfsrj5jgmiJArPYlxK3NL1 kqJw8VPbvHxaZDzcgNCu7Dmeaz11ZIfF8X/fGZG22xjf2TvRte7Dml3eQe0QDPa/xsD7 U7ZT+Vt3JmCL1m3BesPwdQLWwFk+i/wiQM3tLLJZwLj8nYi/u7K73s8cbXbkixwD48gC 3KJb5ou3Ifre3d/yIQVBpmGVNEku9wkQxpwTHuK7EvAndsm+NumAvQJ6VTE5qT82aSFS BzVQ== X-Forwarded-Encrypted: i=1; AJvYcCWwXfSwQpUiu3o6fU+KSrU5Yxy9RLgvuZ+hC26dxqbumyJRSS3OuHTXDoMyykjN4fWug/IqEbMHQRUd0RE=@vger.kernel.org X-Gm-Message-State: AOJu0YyqcCV/RJdBCnAcVNETtb28RiXARTFy3M0V4ms0jJYlFlVTZKnE RlbgaXY1EObP9zPRsH2Xku5qhj+G6uRfXwa5nfDtEIA/iTvsNpOsbLdeb1X3mdKeAN50kNJYB8C 8EOvqhdy8x0hpEyxuv07/nI6lnEArYVc5/GTXyrAQqJifJUVEtKFzMM2ipge4wF2oVBY= X-Gm-Gg: AY/fxX7Gm3GD/iEuNl0TvxmaN2KcJjJ2yIUVaUrcL7ipMCoevx5+VfzHNLU7g9RmIsj rbU0gIie0Tt7mTIXnal/5283SyBRovnqIaDUKXm9fysytIZgjrxyDj2/bUEc9Nu+tMPtWOQP1eg 7Rw//X+EARLxEJQ21UMJJ6F+WFmv/RTvP8fwDp9QlcGvQFX+3TOGCfjGPwgYwTHF7zXo6nlxDML 6gi97LzlSgReIt7+BHIkiHHrCPEMblTvVuVmVRwdz4QrhpCVoha7/csOasjIplzd/FVl+nQem0M q5Tpi59s5CvhIdW6olEHDiT5DRhPvD+QjIiqBis7wwUyVBElzRRND+S+b3+Hs7An/b5l8AdKto8 8AyRPLR4w6n6lWyTXphyZr4dmR4KXUppQx5yoMsCViMuaZE2iaGfRZIhSItEoaTeyzg== X-Received: by 2002:ac8:7c49:0:b0:4ed:b409:ca27 with SMTP id d75a77b69052e-4f4abde36bemr329509041cf.10.1767012051773; Mon, 29 Dec 2025 04:40:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcUCaC84X8pN/KRSLuzLkKfRP2suKS1AS1nwLg0AIHCWbLw0pFnH+UQ9INhI04gcpYzXDCOg== X-Received: by 2002:ac8:7c49:0:b0:4ed:b409:ca27 with SMTP id d75a77b69052e-4f4abde36bemr329508671cf.10.1767012051304; Mon, 29 Dec 2025 04:40:51 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f4ef1fsm3382018066b.64.2025.12.29.04.40.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 04:40:50 -0800 (PST) Message-ID: <2898fde7-2b3b-471b-8f8f-a02cb6953aaf@oss.qualcomm.com> Date: Mon, 29 Dec 2025 13:40:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] remoteproc: qcom_q6v5_mss: Add MSM8917 To: barnabas.czeman@mainlining.org, Stephan Gerhold Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251228-mss-v1-0-aeb36b1f7a3f@mainlining.org> <20251228-mss-v1-4-aeb36b1f7a3f@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: ghJ_JPy3rsb7Nu9b5YVTlk7r47Kqfii5 X-Proofpoint-ORIG-GUID: ghJ_JPy3rsb7Nu9b5YVTlk7r47Kqfii5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDExOCBTYWx0ZWRfX153TenvXN/Gd IVa7iTgT1yUit0N/tys8l3FvVWl4EMoyWqU4997vTh58wklWarzKqMr8lKaam3AvjjdOHMiJHOr ekPi9Sm1piHblDmGdirqhqtSlkciu8UMoYSFY94UpFP78m7yiBYtQdfYbBXPeRKVL/g/KAJugTc gQ301AS56biu0FCD5QP33ArSosycpee60P++f2teOOKazEneKvRzbV3YHSiTqelwS/bE+pvFMzg lLu1H1AsrnMJoS3jRAHSTUlfUKDzSe5zV/dxvzdAVcEpqiuHW7Y9gZVilT6CmhTEDM2HW5ljXtR MlRPoLShW0O2FdiPpa4wZCbJ7u2/vfXFUBaeUdBc1HafhpYFWVgT+wRnxNvjauW/bgSpN27Uzjw +2uoEOJanRYaC838ueXQm6GRN+XV80ZyS1qepHNdNQYDQJIMXbp3CMk7yo6Zi8F+ghwf0uJy3CR 6J7rfF3NZmPXuSYk7jg== X-Authority-Analysis: v=2.4 cv=DptbOW/+ c=1 sm=1 tr=0 ts=695276d4 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Oh2cFVv5AAAA:8 a=OuZLqq7tAAAA:8 a=g6jOo_ygQZX2zdRKxuUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=7KeoIwV6GZqOttXkcoxL:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_04,2025-12-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290118 On 12/29/25 1:33 PM, barnabas.czeman@mainlining.org wrote: > On 2025-12-29 12:08, Stephan Gerhold wrote: >> On Sun, Dec 28, 2025 at 03:21:54PM +0100, Barnabás Czémán wrote: >>> Add support for MSM8917 MSS it is similar for MDM9607 MSS >>> only difference is the mss power domain. >>> >>> Signed-off-by: Barnabás Czémán >>> --- >>>  drivers/remoteproc/qcom_q6v5_mss.c | 46 ++++++++++++++++++++++++++++++++++++-- >>>  1 file changed, 44 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c >>> index ffafbe501a05..2579558fb567 100644 >>> --- a/drivers/remoteproc/qcom_q6v5_mss.c >>> +++ b/drivers/remoteproc/qcom_q6v5_mss.c >>> @@ -259,6 +259,7 @@ enum { >>>      MSS_MSM8226, >>>      MSS_MSM8909, >>>      MSS_MSM8916, >>> +    MSS_MSM8917, >>>      MSS_MSM8926, >>>      MSS_MSM8953, >>>      MSS_MSM8974, >>> @@ -749,13 +750,15 @@ static int q6v5proc_reset(struct q6v5 *qproc) >>>          goto pbl_wait; >>>      } else if (qproc->version == MSS_MDM9607 || >>>             qproc->version == MSS_MSM8909 || >>> +           qproc->version == MSS_MSM8917 || >>>             qproc->version == MSS_MSM8953 || >>>             qproc->version == MSS_MSM8996 || >>>             qproc->version == MSS_MSM8998 || >>>             qproc->version == MSS_SDM660) { >>> >>>          /* Override the ACC value if required */ >>> -        if (qproc->version == MSS_MDM9607) >>> +        if (qproc->version == MSS_MDM9607 || >>> +            qproc->version == MSS_MSM8917) >>>              writel(QDSP6SS_ACC_OVERRIDE_VAL_9607, >>>                     qproc->reg_base + QDSP6SS_STRAP_ACC); >>>          else if (qproc->version != MSS_MSM8909 && >>> @@ -817,6 +820,7 @@ static int q6v5proc_reset(struct q6v5 *qproc) >>> >>>              /* Turn on L1, L2, ETB and JU memories 1 at a time */ >>>              if (qproc->version == MSS_MDM9607 || >>> +                qproc->version == MSS_MSM8917 || >>>                  qproc->version == MSS_MSM8953 || >>>                  qproc->version == MSS_MSM8996) { >>>                  mem_pwr_ctl = QDSP6SS_MEM_PWR_CTL; >>> @@ -826,7 +830,8 @@ static int q6v5proc_reset(struct q6v5 *qproc) >>>                   * Set first 5 bits in reverse to avoid >>>                   * "inrush current" issues. >>>                   */ >>> -                if (qproc->version == MSS_MDM9607) >>> +                if (qproc->version == MSS_MDM9607 || >>> +                    qproc->version == MSS_MSM8917) >>>                      reverse = 6; >>>              } else { >>>                  /* MSS_MSM8998, MSS_SDM660 */ >>> @@ -2538,6 +2543,42 @@ static const struct rproc_hexagon_res msm8916_mss = { >>>      .version = MSS_MSM8916, >>>  }; >>> >>> +static const struct rproc_hexagon_res msm8917_mss = { >>> +    .hexagon_mba_image = "mba.mbn", >>> +    .proxy_supply = (struct qcom_mss_reg_res[]) { >>> +        { >>> +            .supply = "pll", >>> +            .uA = 100000, >>> +        }, >>> +        {} >>> +    }, >>> +    .proxy_clk_names = (char*[]){ >>> +        "xo", >>> +        NULL >>> +    }, >>> +    .active_clk_names = (char*[]){ >>> +        "iface", >>> +        "bus", >>> +        "mem", >>> +        NULL >>> +    }, >>> +    .proxy_pd_names = (char*[]) { >>> +        "cx", >>> +        "mx", >>> +        "mss", >> >> Are you sure mss/pm8937_s1 also works as a power domain? It seems to be >> a plain regulator downstream (similar to msm8226/msm8974). >> >> Same thing applies to MSM8953 as well though and there we seem to have >> decided to model it as a power domain ... > They have this at downstream, i guess this is why handled as a power domain. > vdd_mss-uV = ; It seems to be just a normal regulator on both 8917 and 8953 https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/arch/arm/boot/dts/qcom/msm8953-regulator.dtsi https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/arch/arm/boot/dts/qcom/msm8953.dtsi https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/arch/arm/boot/dts/qcom/msm8917-regulator.dtsi https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/arch/arm/boot/dts/qcom/msm8917.dtsi Konrad