mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <Martin.Bligh@us.ibm.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Rusty Russell <rusty@rustcorp.com.au>
Cc: anton@samba.org, davej@suse.de, marcelo@conectiva.com.br,
	linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: Linux 2.4.17-pre5
Date: Sun, 09 Dec 2001 18:10:23 -0800	[thread overview]
Message-ID: <2899076331.1007921423@[10.10.1.2]> (raw)
In-Reply-To: <E16DEVr-0008SW-00@the-village.bc.nu>

>> 	If you number each CPU so its two IDs are smp_num_cpus()/2
>> 	apart, you will NOT need to put some crappy hack in the
>> 	scheduler to pack your CPUs correctly.
> 
> Which is a major change to the x86 tree and an invasive one. Right now the
> X86 is doing a 1:1 mapping, and I can offer Marcelo no proof that somewhere
> buried in the x86 arch code there isnt something that assumes this or mixes
> a logical and physical cpu id wrongly in error. 

I don't think it matters if you do a 1:1 map or not, since the NUMA-Q boxes work 
fine without assuming this (I don't use physical APIC id's at all, except for from 
the I/O APIC to just broadcast), and I don't think anyone else does either after
we boostrap.

It shouldn't be all that hard to check. Mentally mark every time we look at the 
physical APIC id, and which variables are set from that and thus "tainted". I
did this once - I don't think it's very many at all.

I don't think changing the order we look at phys_cpu_present_map should
make much of a difference.

On the other hand, relying on the "arbitrary" cpu numbers either way doesn't
seem like the best of ideas ;-)

Martin.

  reply	other threads:[~2001-12-10  2:07 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-06 17:39 Marcelo Tosatti
2001-12-06 19:07 ` Alan Cox
2001-12-06 23:38   ` Dave Jones
2001-12-07  0:09     ` Alan Cox
2001-12-07 16:07     ` Marcelo Tosatti
2001-12-08 10:46     ` Rusty Russell
2001-12-09  0:17       ` Linux HMT analysis Anton Blanchard
2001-12-09  1:39         ` Alan Cox
2001-12-09  1:41           ` Alan Cox
2001-12-09  0:31       ` Linux 2.4.17-pre5 Alan Cox
2001-12-09  1:58         ` Rusty Russell
2001-12-09  2:35           ` Davide Libenzi
2001-12-09  6:20             ` Rusty Russell
2001-12-09 16:24             ` Alan Cox
2001-12-09 19:48               ` Davide Libenzi
2001-12-09 22:44               ` Mike Kravetz
2001-12-09 23:50                 ` Davide Libenzi
2001-12-09 23:57                 ` Alan Cox
2001-12-19 22:16               ` Pavel Machek
2001-12-20 19:10                 ` Davide Libenzi
2001-12-09 16:16           ` Alan Cox
2001-12-10  0:21             ` Rusty Russell
2001-12-10  0:41               ` Alan Cox
2001-12-10  2:10                 ` Martin J. Bligh [this message]
2001-12-10  5:40                   ` Rusty Russell
2001-12-10  5:31                 ` Rusty Russell
2001-12-10  8:28                   ` Alan Cox
2001-12-10 23:12                     ` James Cleverdon
2001-12-10 23:30                       ` Alan Cox
2001-12-11  9:16                         ` Robert Varga
2001-12-11  9:23                           ` David Weinehall
2001-12-11  9:00                 ` Eric W. Biederman
2001-12-11 23:14                   ` Alan Cox
2001-12-09 19:38           ` Marcelo Tosatti
2001-12-09  9:47       ` arjan
2001-12-06 19:18 ` Matthias Andree
2001-12-06 19:05   ` Marcelo Tosatti
2001-12-06 21:14     ` Ben Greear
2001-12-06 21:58     ` David S. Miller
2001-12-06 22:24       ` Matthias Andree
2001-12-09 10:10       ` Eran Man
2001-12-06 20:14   ` Rik van Riel
2001-12-06 20:22     ` Jeff Garzik
2001-12-06 20:58   ` David S. Miller
2001-12-08  4:56     ` M. Edward Borasky
2001-12-08  5:41     ` David S. Miller
2001-12-06 20:44 Luca Montecchiani
2001-12-07  0:12 ` Stephan von Krawczynski
2001-12-07  3:43   ` Keith Owens
2001-12-07 11:55   ` Stephan von Krawczynski
2001-12-07 13:35     ` Keith Owens
2001-12-07 14:25     ` Stephan von Krawczynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='2899076331.1007921423@[10.10.1.2]' \
    --to=martin.bligh@us.ibm.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=anton@samba.org \
    --cc=davej@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®