From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B3AC43217 for ; Sat, 26 Nov 2022 01:38:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230079AbiKZBiP (ORCPT ); Fri, 25 Nov 2022 20:38:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbiKZBiM (ORCPT ); Fri, 25 Nov 2022 20:38:12 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A83A41A060 for ; Fri, 25 Nov 2022 17:38:10 -0800 (PST) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NJvVf0V11zHw4x; Sat, 26 Nov 2022 09:37:30 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 26 Nov 2022 09:38:08 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 26 Nov 2022 09:38:08 +0800 Message-ID: <289aaacb-6c6f-b5f0-185c-9f41cd0d87b9@huawei.com> Date: Sat, 26 Nov 2022 09:38:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] pmem: use TestClearPageHWPoison() directly Content-Language: en-US To: Andrew Morton CC: Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , References: <20221125115308.104059-1-wangkefeng.wang@huawei.com> <20221125164101.7fad45f3906c9cfa6cb614aa@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20221125164101.7fad45f3906c9cfa6cb614aa@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/11/26 8:41, Andrew Morton wrote: > On Fri, 25 Nov 2022 19:53:08 +0800 Kefeng Wang wrote: > >> Add TESTSCFLAG_FALSE(HWPoison, hwpoison) for HWPoison in >> page flags, then drop privite test_and_clear_pmem_poison(). > Why? Just a cleanup,the TestClearPageHWPoison is used in pmem.c, but it has own stub when MEMORY_FAILURE not enabled, so add TESTSCFLAG_FALSE() for HWpoison in case similar scenario, if there are some rules about it,please ignore it. > .