From: Paolo Abeni <pabeni@redhat.com>
To: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Xiyu Yang <xiyuyang19@fudan.edu.cn>,
Xin Tan <tanxin.ctf@gmail.com>, Xin Xiong <xiongx18@fudan.edu.cn>,
Tom Parkin <tparkin@katalix.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] l2tp: fix possible use-after-free
Date: Tue, 14 Jun 2022 10:06:20 +0200 [thread overview]
Message-ID: <289be1e1392d5a0c9a90486be44ad09d10b70752.camel@redhat.com> (raw)
In-Reply-To: <20220610051633.8582-1-xiaohuizhang@ruc.edu.cn>
On Fri, 2022-06-10 at 13:16 +0800, Xiaohui Zhang wrote:
> Similar to the handling of l2tp_tunnel_get in commit a622b40035d1
> ("l2ip: fix possible use-after-free"), we thought a patch might
> be needed here as well.
>
> Before taking a refcount on a rcu protected structure,
> we need to make sure the refcount is not zero.
>
> Signed-off-by: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
I'm sorry for the late, trivial feedback, but we need a Fixes: tag
here. Since you need to repost, please insert the target tree
explicitly into the email subj.
Thanks!
Paolo
next prev parent reply other threads:[~2022-06-14 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 5:16 Xiaohui Zhang
2022-06-14 8:06 ` Paolo Abeni [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-05 11:35 Xiaohui Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=289be1e1392d5a0c9a90486be44ad09d10b70752.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tanxin.ctf@gmail.com \
--cc=tparkin@katalix.com \
--cc=xiaohuizhang@ruc.edu.cn \
--cc=xiongx18@fudan.edu.cn \
--cc=xiyuyang19@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®