From: Like Xu <like.xu.linux@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>,
Wanpeng Li <wanpengli@tencent.com>,
Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Jim Mattson <jmattson@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH RESEND v12 00/17] KVM: x86/pmu: Add basic support to enable guest PEBS via DS
Date: Wed, 25 May 2022 16:32:36 +0800 [thread overview]
Message-ID: <289d0c88-36a0-afd4-4d47-f2db3fb63654@gmail.com> (raw)
In-Reply-To: <0848a2da-c9cf-6973-c774-ff16c3e8a248@redhat.com>
On 25/5/2022 4:14 pm, Paolo Bonzini wrote:
> On 5/25/22 09:56, Like Xu wrote:
>> Thanks for the clarification.
>>
>> Some kvm x86 selftests have been failing due to this issue even after the last
>> commit.
>>
>> I blame myself for not passing the msr_info->host_initiated to the
>> intel_is_valid_msr(),
>> meanwhile I pondered further whether we should check only the MSR addrs range in
>> the kvm_pmu_is_valid_msr() and apply this kind of sanity check in the
>> pmu_set/get_msr().
>>
>> Vitaly && Paolo, any preference to move forward ?
>
> I'm not sure what I did wrong to not see the failure, so I'll fix it myself.
More info, some Skylake hosts fail the tests like x86_64/state_test due to this
issue.
>
> But from now on, I'll have a hard rule of no new processor features enabled
> without KVM unit tests or selftests. In fact, it would be nice if you wrote
> some for PEBS.
Great, my team (or at least me) is committed to contributing more tests on vPMU
features.
We may update the process document to the
Documentation/virt/kvm/review-checklist.rst.
>
> Paolo
>
next prev parent reply other threads:[~2022-05-25 8:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 10:19 Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 01/17] perf/x86/intel: Add EPT-Friendly PEBS for Ice Lake Server Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 02/17] perf/x86/intel: Handle guest PEBS overflow PMI for KVM guest Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 03/17] perf/x86/core: Pass "struct kvm_pmu *" to determine the guest values Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 04/17] KVM: x86/pmu: Set MSR_IA32_MISC_ENABLE_EMON bit when vPMU is enabled Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 05/17] KVM: x86/pmu: Introduce the ctrl_mask value for fixed counter Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 06/17] x86/perf/core: Add pebs_capable to store valid PEBS_COUNTER_MASK value Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 07/17] KVM: x86/pmu: Add IA32_PEBS_ENABLE MSR emulation for extended PEBS Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 08/17] KVM: x86/pmu: Reprogram PEBS event to emulate guest PEBS counter Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 09/17] KVM: x86/pmu: Adjust precise_ip to emulate Ice Lake guest PDIR counter Like Xu
2022-05-13 8:57 ` Like Xu
2022-05-13 9:26 ` [PATCH v13 " Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 10/17] KVM: x86/pmu: Add IA32_DS_AREA MSR emulation to support guest DS Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 11/17] KVM: x86/pmu: Add PEBS_DATA_CFG MSR emulation to support adaptive PEBS Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 12/17] KVM: x86: Set PEBS_UNAVAIL in IA32_MISC_ENABLE when PEBS is enabled Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 13/17] KVM: x86/pmu: Move pmc_speculative_in_use() to arch/x86/kvm/pmu.h Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 14/17] KVM: x86/pmu: Disable guest PEBS temporarily in two rare situations Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 15/17] KVM: x86/pmu: Add kvm_pmu_cap to optimize perf_get_x86_pmu_capability Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 16/17] KVM: x86/cpuid: Refactor host/guest CPU model consistency check Like Xu
2022-04-11 10:19 ` [PATCH RESEND v12 17/17] KVM: x86/pmu: Expose CPUIDs feature bits PDCM, DS, DTES64 Like Xu
2022-05-10 16:55 ` [PATCH RESEND v12 00/17] KVM: x86/pmu: Add basic support to enable guest PEBS via DS Paolo Bonzini
2022-05-19 12:14 ` Vitaly Kuznetsov
2022-05-19 13:31 ` Like Xu
2022-05-19 13:50 ` Like Xu
2022-05-19 14:46 ` Vitaly Kuznetsov
2022-05-25 7:56 ` Like Xu
2022-05-25 8:14 ` Paolo Bonzini
2022-05-25 8:32 ` Like Xu [this message]
2022-05-25 14:12 ` Maxim Levitsky
2022-05-25 14:13 ` Paolo Bonzini
2022-05-25 14:14 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=289d0c88-36a0-afd4-4d47-f2db3fb63654@gmail.com \
--to=like.xu.linux@gmail.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®