From: Andrew Lunn <andrew@lunn.ch>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com,
almasrymina@google.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, horms@kernel.org,
kernel-team@meta.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
pabeni@redhat.com, rmk+kernel@armlinux.org.uk
Subject: Re: [PATCH net-next] eth: fbnic: Configure RDE settings for pause frame
Date: Wed, 12 Nov 2025 21:53:44 +0100 [thread overview]
Message-ID: <289f4375-c569-44ca-86cb-18b48d17c9c3@lunn.ch> (raw)
In-Reply-To: <20251112180427.2904990-1-mohsin.bashr@gmail.com>
> @@ -36,8 +36,13 @@ int fbnic_phylink_set_pauseparam(struct net_device *netdev,
> struct ethtool_pauseparam *pause)
> {
> struct fbnic_net *fbn = netdev_priv(netdev);
> + int err;
> +
> + err = phylink_ethtool_set_pauseparam(fbn->phylink, pause);
> + if (!err)
> + fbn->tx_pause = pause->tx_pause ? true : false;
You should store this away in mac_link_up. Pause can be negotiated. It
could be the link partner does not want pause, does not support pause.
When phylink calls .mac_link_up this has all been determined and you
then know how to setup the hardware. Here is too early.
Andrew
next prev parent reply other threads:[~2025-11-12 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 18:04 Mohsin Bashir
2025-11-12 20:53 ` Andrew Lunn [this message]
2025-11-13 23:18 ` Mohsin Bashir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=289f4375-c569-44ca-86cb-18b48d17c9c3@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexanderduyck@fb.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®