From: Bart Van Assche <bvanassche@acm.org>
To: Jiaming Li <lijiamingsofine@gmail.com>,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
lijiaming3 <lijiaming3@xiaomi.com>
Subject: Re: [PATCH] scsi: ufs: ufsfbo: Introduce File Based Optimization feature
Date: Wed, 24 Aug 2022 09:35:48 -0700 [thread overview]
Message-ID: <28a43c43-79d0-3331-a067-0336270c4372@acm.org> (raw)
In-Reply-To: <20220824084633.14428-1-lijiamingsofine@gmail.com>
On 8/24/22 01:46, Jiaming Li wrote:
> +#include "../../../block/blk.h"
Without having taken a look at the rest of this patch, including a block
driver private header file in the UFS driver is unacceptable.
> +#define FBO_INFO_MSG(fbo, msg, args...) do { \
> + if (fbo->fbo_debug) \
> + pr_info("[info]%s:%d:" msg "\n", __func__, __LINE__, ##args); \
> + } while (0)
Please use pr_debug() instead.
> +#define FBO_ERR_MSG(msg, args...) \
> + pr_err("[err]%s:%d:" msg "\n", __func__, __LINE__, ##args)
Please use pr_err() directly and remove the function name and line
numbers from error messages.
> +#define FBO_WARN_MSG(msg, args...) \
> + pr_warn("[warn]%s:%d:" msg "\n", __func__, __LINE__, ##args)
Please use pr_warn directly and remove function name and line numbers
from warning messages.
Thanks,
Bart.
next prev parent reply other threads:[~2022-08-24 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 8:46 Jiaming Li
2022-08-24 14:16 ` Bean Huo
2022-08-24 15:26 ` 答复: [External Mail]Re: " 李佳铭
2022-08-24 16:17 ` Bean Huo
2022-08-24 16:40 ` Bart Van Assche
2022-08-24 16:35 ` Bart Van Assche [this message]
2022-08-25 8:42 ` Avri Altman
2022-08-25 8:56 ` Avri Altman
2022-08-25 12:10 ` 答复: [External Mail]RE: " 李佳铭
2022-08-25 12:16 ` Avri Altman
2022-08-26 22:00 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28a43c43-79d0-3331-a067-0336270c4372@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=jejb@linux.ibm.com \
--cc=lijiaming3@xiaomi.com \
--cc=lijiamingsofine@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®