Re: [PATCH] net/dsa: remove unused macros to tame gcc warning

[Alex Shi <alex.shi@linux.alibaba.com>]

在 2020/11/6 下午4:52, Joe Perches 写道:
> On Fri, 2020-11-06 at 16:28 +0800, Alex Shi wrote:
>>
>> 在 2020/11/6 下午2:36, Joe Perches 写道:
>>> On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
>>>> There are some macros unused, they causes much gcc warnings. Let's
>>>> remove them to tame gcc.
>>>
>>> I believe these to be essentially poor warnings.
>>>
>>> Aren't these warnings generated only when adding  W=2 to the make
>>> command line?
>>>
>>> Perhaps it's better to move the warning to level 3
>>> ---
>>> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
>>> index 95e4cdb94fe9..5c3c220ddb32 100644
>>> --- a/scripts/Makefile.extrawarn
>>> +++ b/scripts/Makefile.extrawarn
>>> @@ -68,7 +68,6 @@ KBUILD_CFLAGS += $(call cc-option, -Wlogical-op)
>>>  KBUILD_CFLAGS += -Wmissing-field-initializers
>>>  KBUILD_CFLAGS += -Wtype-limits
>>>  KBUILD_CFLAGS += $(call cc-option, -Wmaybe-uninitialized)
>>> -KBUILD_CFLAGS += $(call cc-option, -Wunused-macros)
>>
>> This changed too much, and impact others. May not good. :)
> 
> Can you clarify what you mean?
> 

Uh, change in this file will impact all kernels not only for net/dsa.
If you want to keep these unused macros, maybe better to put them into comments?

Thanks!
Alex