From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15027C04FE0 for ; Sat, 24 Jun 2023 07:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232388AbjFXH7J (ORCPT ); Sat, 24 Jun 2023 03:59:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232235AbjFXH7E (ORCPT ); Sat, 24 Jun 2023 03:59:04 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 624CD2941 for ; Sat, 24 Jun 2023 00:59:01 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-988aefaa44eso179106566b.2 for ; Sat, 24 Jun 2023 00:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687593540; x=1690185540; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2RPXidMTrzBctnlI68UKYA3FxvKEi+gyM/+eAniSxHU=; b=biIFt0+5HLIeQJNObq9fw50IfGs4F5DFXzw8WQaXnv6Hdp3USYZJNL8PssYy6o2vEe uTNazxcXxlW9nYoOgc1ECAXqLXI0Fy6OTpXxKHrO5KBGlvJvfFS0T1Yy1tTOfdnYqT7s cMkaa3hPEAmXD6ANC4ih3z1UVMiivHFKHKNCNhNRtq9hQ7bMkaNVdI+n4Hlx2BE7yzQO jx50D2lQ67d60SVIUDBnCbxdMAAwJOdFf8iKs6wYFG3VWtA2pwPKLl5H6eldXBBdXINm rY7xzFgOPvVvf6qqwYEsEXTKFvEIRltIXoBmYft7pQBxV4w1cue28E4Voq0fdjydEvEn MpcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687593540; x=1690185540; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2RPXidMTrzBctnlI68UKYA3FxvKEi+gyM/+eAniSxHU=; b=ZCJa3e575i8IpZn/vUuX9BIgbxeXEGPA4rlJa/gX+VUd3+zLJvS9hwpur8xvhftumq V2Sbu8pBJjXDd0dAwbicNlHcpaWbn1MD7ntVlhu/eqOZgEPfVsjVRjon0+EB1hbpMsg/ eA9i0R1QOo/CfkxaA8RxlQpaz+av+HcUiuUIvhzt3QC0pF3gFqr8fvvT4gpm6aEKYkvO ldwCIpyjrjvhUcWoQjUvVP9v49rtM8E/zAJWZApxqSjlFQdOd3ANYu+sm4wJn1+qun2y UKXIO3EGSx125GsWnPAou+TQfP27NDzTz+uMVvUYTOO4W3lhQLqN0eLIy787AkcSe7P1 Qx4g== X-Gm-Message-State: AC+VfDzl59AAsMZAK3u9Ej0yN8BxAhIF1w+s8990VMvzaB3rZQw27f1R yVp/2EAGQTLVu2aijoXTw2oBWA== X-Google-Smtp-Source: ACHHUZ6KTEX3PoU0t4AzSkFJrRvYcc7s1C5vvyEb440YGE+szTSoYCbadoq/cw/0a/YYcc9DpVEdLg== X-Received: by 2002:a17:907:a06:b0:974:1e0e:9bd4 with SMTP id bb6-20020a1709070a0600b009741e0e9bd4mr20928031ejc.16.1687593539714; Sat, 24 Jun 2023 00:58:59 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id l24-20020a1709060e1800b009783791b1a1sm592525eji.121.2023.06.24.00.58.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jun 2023 00:58:59 -0700 (PDT) Message-ID: <28a5d2e7-d3bf-d373-10ad-73c7590924c4@linaro.org> Date: Sat, 24 Jun 2023 09:58:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 14/45] dt-bindings: crypto: add bindings for sam9x7 in Atmel AES Content-Language: en-US To: Varshini Rajendran , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, tglx@linutronix.de, maz@kernel.org, lee@kernel.org, ulf.hansson@linaro.org, tudor.ambarus@linaro.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linus.walleij@linaro.org, p.zabel@pengutronix.de, olivia@selenic.com, a.zummo@towertech.it, radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com, gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org, wim@linux-watchdog.org, linux@roeck-us.net, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, sre@kernel.org, jerry.ray@microchip.com, horatiu.vultur@microchip.com, durai.manickamkr@microchip.com, andrew@lunn.ch, alain.volmat@foss.st.com, neil.armstrong@linaro.org, mihai.sain@microchip.com, eugen.hristev@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-i2c@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org Cc: Hari.PrasathGE@microchip.com, cristian.birsan@microchip.com, balamanikandan.gunasundar@microchip.com, manikandan.m@microchip.com, dharma.b@microchip.com, nayabbasha.sayed@microchip.com, balakrishnan.s@microchip.com References: <20230623203056.689705-1-varshini.rajendran@microchip.com> <20230623203056.689705-15-varshini.rajendran@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20230623203056.689705-15-varshini.rajendran@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/2023 22:30, Varshini Rajendran wrote: > Add DT bindings for atmel AES. > > Signed-off-by: Varshini Rajendran > --- > .../devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml > index 0b7383b3106b..f0736696c883 100644 > --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml > +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml > @@ -12,7 +12,10 @@ maintainers: > > properties: > compatible: > - const: atmel,at91sam9g46-aes > + oneOf: This is not oneOf. > + - items: And these are not items. You just broke existing users, which points to the fact that you did not test the bindings nor the DTS. You didn't test anything here. This comment applies for entire patchset - please test everything. I expect v3, after testing. Best regards, Krzysztof