From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57A4433345A for ; Thu, 19 Feb 2026 08:09:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771488589; cv=none; b=M4+J7kWsuYY8K35WZHghiPfFLaC8xi+JQG/alV5+lXx5FIZHeupCFtMFrpLSVcqLQoHGSBabtU2i/PIZrWa3me/rlVsv+L4Huu+VF2CGuJoENGfZX5Rx+pMLUP0srziXHz/onqkiqoNIzjpovj0hk0iSScmqwz9f/qC5TOrQaTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771488589; c=relaxed/simple; bh=4NehR4sTHOxsA4wUCf6MLaafUjVEdqAqvefjROThzz8=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=aaXG0vFvyR9qU7WVSVYLWGFH8E5eqKJFBqOsVPHftBshARieuwIzPluJaV0KgemcnI9ydlm7TsWJ979n1gyjyLZ4bDAIgRfRVtfzLMGCA0iUxEfMm5oxwdPCFGwyfM32g3UcgmDQjXGRBOpzLcq9np7SPLwAhBWeFiCB5W8pNoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i3fW7Y8s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U5PR1Now; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i3fW7Y8s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U5PR1Now" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61IKxg3x3133179 for ; Thu, 19 Feb 2026 08:09:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= He9TCtmdJ/Jyli0G3m7/iAi1wToVq9O81jgA5Yqu3aM=; b=i3fW7Y8sEmFuTtK/ t47W8Nbh2HwHQidDlVHrzm5GCoXQqeEIK7URzpYCkPUqxRkpIKduNmRxndGcqHSc +sMiEdnkH4e+dWKdvO3NVcNEihPssC0QuIl8mk2kgHU2o6a7hb5XDQUSSKpDEpq6 nBR+3rhVpcSX3NCGOrk536nnN1ZYDqR5mY9rtH6ROgmOhhp/osHY9OOUU1UWyEsH OjP4kBWzr894+8yEO2FCmj5lk3l8ItefW+b9c9qvws7gvPwjhVW9oGBmcFIKx8/3 NWdJIRujOQp1Jz49BQuZmmmecikfCj+Ctj3GhuYf80ZjPX1tWYYkmVqcGxsZFecM VLiDJA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cdmxvs9y3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 08:09:47 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2a863be8508so7914395ad.2 for ; Thu, 19 Feb 2026 00:09:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771488587; x=1772093387; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=He9TCtmdJ/Jyli0G3m7/iAi1wToVq9O81jgA5Yqu3aM=; b=U5PR1NowaQHMBaQE6RCWYNcJzI4NXvkAjQcic5oGSK/shkVQ92WOT59YndUSpng9gJ Ug8bMFTDoHnhD/Rel2GSkS0FLfxwNwblNmxmMX/hurS5XNO8HVHrMo0qjixg6GdVuDL8 SEE1Ehp1u4eUDsVNZFsgXSF4lxLIpiMJ8OetCcCis5QcNMxDsNqrismVS5TQ+e7jYJwo uc3XK58amaOL2Qf6wD9P1FUb43kzIkU954ecyzoAlMCsmcfDwh4eo5wMUOcdqafvdyh2 0LGeLfH/BHCOoXAxXMoca7gBheVirqugA2+oQAo6Rh+2QK4tvFsgalVvuPxfuzgul+Lf ScrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771488587; x=1772093387; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=He9TCtmdJ/Jyli0G3m7/iAi1wToVq9O81jgA5Yqu3aM=; b=ZApeW9dfpfCvpKbAok+jCZxQNdpumL9WgDbWkH/XIdtu2M7O1mxl4jJge5jjw0ePpV 6XsKfYFrzNh4BEQV3rLxY0CwUcJSKiZiQGkwGTWJf1/QjWLZU3Ys2ifS+/QYH7XIlhuz kfBJ6hcg5bKeN78Ie7NiztA0esYkUzXFP9zdY7VD1yPWVHbzvuy14tpUSgr9VL350HM/ Y8GzHa3vrl42F5oUTQuOdkXUp+8uVxMi2s2QlkPnNUQKjns2VsVnbwjs3v+PqK3SNe4s 4KgwLTwKWv47PU4E5tN+DIg5tN1HguiV16YHgcywrou9PkM/aHQCdukoW390UTEhKPQ/ 6q2g== X-Forwarded-Encrypted: i=1; AJvYcCVJfGAz78k7SJMVENFrWHgB07AvMxcvuJvMxqcuJmO3cD1ziOtYP1Wfjhn0z+AeHAGy32hj7g/cj4pwMHY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzsb2NE+qm5BUEIf5WSioV0gMC9Asu+86+a8DM7r7hVb/Q2KoZG M88P+y03fgnygIjBrMPmBPl7AoEQXJ8BtCQJUYKNy9bBmu8yi6uacfu39FI0N+8CC7SG5QUQgP7 afSlYcdac6SGexsQTwwJ2pJsJ5IWKaOmFfV7TrBvIXN/6gOidMBXTqKU43S9tKcZiqSQ= X-Gm-Gg: AZuq6aIvtE/mishh2v8XH8EXqYSiGXM4S5iG9u1Zc9OKNnk6b1P9UwMXPQVsfMN7aK1 sGg6BVcMFaOcKK5Mumcdx3/CWGIJYVJ4lKkIn7XcItDZ4Jmr4m1FyCs5VKhfxAkVeZfr19/vMgP mitlXMwEF+B/TpcrcI7oVGWDYbzpTf+IEl4YDmvgonUM5CUjUYTymSUBZvW3lOKXiab+FG+kDmW tn0r4lRa5gpPo1B+6Eux2AgfQmoSTsOzOclUG5oYSsQYL7GsBUo2mAq0BrF6SnrFbQ9sg51Xp8K g2hzcxrfyg69GedMg+I1JZ4x/yOyr45giNhjsZfEy9rXvW99wfXlBIoPgblbPmy8iGk7GAVE9pN PDyfQeuAUSZJ2ztoGmm7n2gGWCJsQwI8nr2yV3w+DiF9cSpZtIg== X-Received: by 2002:a17:903:38cd:b0:2a0:c1e4:e25 with SMTP id d9443c01a7336-2ad1759ac22mr202678915ad.54.1771488586934; Thu, 19 Feb 2026 00:09:46 -0800 (PST) X-Received: by 2002:a17:903:38cd:b0:2a0:c1e4:e25 with SMTP id d9443c01a7336-2ad1759ac22mr202678775ad.54.1771488586452; Thu, 19 Feb 2026 00:09:46 -0800 (PST) Received: from [10.217.222.63] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1aadd140sm161116145ad.72.2026.02.19.00.09.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 00:09:46 -0800 (PST) Subject: Re: [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle To: Krzysztof Kozlowski Cc: ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Abhinaba Rakshit References: <20260217052526.2335759-1-neeraj.soni@oss.qualcomm.com> <20260217052526.2335759-2-neeraj.soni@oss.qualcomm.com> <20260217-berserk-puma-of-focus-bcbe82@quoll> <51d75568-5110-4993-b262-71af0a0d4600@kernel.org> From: Neeraj Soni Message-ID: <28a9d23b-69ae-c624-4b2a-1ff719281cd3@oss.qualcomm.com> Date: Thu, 19 Feb 2026 13:39:41 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <51d75568-5110-4993-b262-71af0a0d4600@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: OLJ-J2l6qK6_J5ZwoGOLzp80QNgsgIuT X-Proofpoint-ORIG-GUID: OLJ-J2l6qK6_J5ZwoGOLzp80QNgsgIuT X-Authority-Analysis: v=2.4 cv=XpX3+FF9 c=1 sm=1 tr=0 ts=6996c54b cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=lvwnJXwceCFjUmCDSakA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDA3MyBTYWx0ZWRfX/7ZeqMNFWQJp S7Csu5W1/dKyumhyIVXRX3iViY9dCnvw2/JFciPjcAWLVk0sK3Iup0pqncJjL9juHOrBfezIPsE /qGPD42Zx4f4W9PMKiHwKkx8v3D+xpP/mFpIdhcsFTk16paAJYLLLNSr9pI+Q45TWFyb6KM6iNu FD31LMwUt8mav9kFt8IEWAXXiU3bJns0ILycg04spWo61sm919aOND1MPAd5MK+EL3ij+ZfwMDW yNuRTtrh/MsrwwSfgyPXSR6aK7ntpBRjVqRO/qUv/YL4OfuptBXayc7z+0HoxEnG+14aw2NaMYD fJIRA0qaCYqWbRIMo3MBGc2dYfXQi0yHN42xsYm7slDfE6AxbhSnRQJvYHR7MRf1xu12iY+7FsR G9cOg32OCNE+kE9fHfb9+aypC2qwhK82Qm0z2V54nNeJ9qIa22TTnK+o8YCoLETjfvh4+Jeuva8 OwadKyvEG3X2f8+6Drg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-19_02,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190073 On 2/19/2026 12:50 PM, Krzysztof Kozlowski wrote: > On 19/02/2026 06:38, Neeraj Soni wrote: >>>> + qcom,ice: >>>> + $ref: /schemas/types.yaml#/definitions/phandle >>>> + description: >>>> + phandle to the Inline Crypto Engine (ICE) hardware block for this controller. >>> >>> >>> Srsly, I asked once and not much improved. What is explicitly written in >>> coding style which I asked you twice to read? >>> >> I have attempted to modifiy it as per the comment you gave in v3 here: >> https://lore.kernel.org/all/b6e510da-b369-4c43-b9a1-455478af4948@kernel.org/ >> >> I will rephrase it to explain the usage better in next patch. >> >>> And how long is this line? Why such trivialities cannot be fixed and I >>> need to remind this every time? >>> >> It is 83 character long but i understand now you expect it to be wrapped >> at 75 as per kernel coding style. I missed it and stuck to the limit > > 75? > Apologies for typo. Wanted to right 80: https://www.kernel.org/doc/html/v4.10/process/coding-style.html > > > Best regards, > Krzysztof >