From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Cc: "andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"kieran.bingham@ideasonboard.com"
<kieran.bingham@ideasonboard.com>,
"Himanshu Bhavani" <himanshu.bhavani@siliconsignals.io>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Ricardo Ribalda" <ribalda@chromium.org>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Hans de Goede" <hansg@kernel.org>,
"André Apitzsch" <git@apitzsch.eu>,
"Matthias Fend" <matthias.fend@emfend.at>,
"Tarang Raval" <tarang.raval@siliconsignals.io>,
"Heimir Thor Sverrisson" <heimir.sverrisson@gmail.com>,
"Jingjing Xiong" <jingjing.xiong@intel.com>,
"Dongcheng Yan" <dongcheng.yan@intel.com>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add ov2735 sensor
Date: Thu, 31 Jul 2025 08:39:39 +0200 [thread overview]
Message-ID: <28ae1ac9-68b3-470e-9ec9-982370839207@kernel.org> (raw)
In-Reply-To: <PN3P287MB3519C0DB4796E4D73411A549FF27A@PN3P287MB3519.INDP287.PROD.OUTLOOK.COM>
On 31/07/2025 08:36, Hardevsinh Palaniya wrote:
>> On 31/07/2025 08:09, Hardevsinh Palaniya wrote:
>>> + properties:
>>> + data-lanes:
>>> + items:
>>> + - const: 1
>>> + - const: 2
>>> + link-frequencies: true
>> Nothing improved. My comments from versions before still apply.
>
> I asked you in v4, but you didn’t respond.
>
> Could you please check?
>
> Link:https://lore.kernel.org/linux-media/PN3P287MB351999B4DB533CCA9C6E6567FF51A@PN3P287MB3519.INDP287.PROD.OUTLOOK.COM/
>
> The driver will always rely on the device tree for the link frequency.
> Without it, the driver will fail to probe.
How is it related? I did not ask to remove it from the driver.
>
> So, the bindings need this property, just like other camera sensors do.
The property is already there, you just duplicated it. You added
completely redundant code and instead of ACTUALLY TESTING YOUR DTS you
keep disagreeing.
So test your DTS first.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-31 6:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 6:09 [PATCH v6 0/2] media: i2c: Add ov2735 camera sensor driver Hardevsinh Palaniya
2025-07-31 6:09 ` [PATCH v6 1/2] dt-bindings: media: i2c: Add ov2735 sensor Hardevsinh Palaniya
2025-07-31 6:13 ` Krzysztof Kozlowski
2025-07-31 6:36 ` Hardevsinh Palaniya
2025-07-31 6:39 ` Krzysztof Kozlowski [this message]
2025-07-31 7:10 ` Hardevsinh Palaniya
2025-07-31 7:21 ` Krzysztof Kozlowski
2025-07-31 8:56 ` Hardevsinh Palaniya
2025-07-31 6:09 ` [PATCH v6 2/2] media: i2c: add ov2735 image sensor driver Hardevsinh Palaniya
2025-08-05 22:47 ` Andy Shevchenko
2025-08-06 6:09 ` Hardevsinh Palaniya
2025-08-08 11:42 ` Sakari Ailus
2025-08-08 12:34 ` Hardevsinh Palaniya
2025-08-08 20:21 ` Sakari Ailus
2025-08-08 9:13 ` [PATCH v6 0/2] media: i2c: Add ov2735 camera " Hardevsinh Palaniya
2025-08-08 12:21 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ae1ac9-68b3-470e-9ec9-982370839207@kernel.org \
--to=krzk@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=benjamin.mugnier@foss.st.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongcheng.yan@intel.com \
--cc=git@apitzsch.eu \
--cc=hansg@kernel.org \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=heimir.sverrisson@gmail.com \
--cc=himanshu.bhavani@siliconsignals.io \
--cc=hverkuil@xs4all.nl \
--cc=jingjing.xiong@intel.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthias.fend@emfend.at \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
--cc=tarang.raval@siliconsignals.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®