From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597AbcHZPN3 (ORCPT ); Fri, 26 Aug 2016 11:13:29 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:45920 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbcHZPNZ (ORCPT ); Fri, 26 Aug 2016 11:13:25 -0400 Subject: Re: [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer To: Keith Busch , Christoph Hellwig References: <20160825073810.GA18622@lst.de> <20160826143557.GA21788@lst.de> <20160826151701.GA19986@localhost.localdomain> CC: Andy Lutomirski , , stable , "linux-kernel@vger.kernel.org" From: Jens Axboe Message-ID: <28b99ce0-9008-1f76-72b5-32084688b10d@fb.com> Date: Fri, 26 Aug 2016 09:12:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160826151701.GA19986@localhost.localdomain> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BY2PR01CA0070.prod.exchangelabs.com (10.163.25.38) To BN6PR15MB1186.namprd15.prod.outlook.com (10.172.205.140) X-MS-Office365-Filtering-Correlation-Id: adaf7431-8c08-4875-8b0b-08d3cdc363bc X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;2:jl2uahPsW5fTZ/l0pP4F0oe/oVhiWEo1FlEee0I6R9pQg4L1CvD+cOMT//bXQUvSB+IC3Gx6yZkdGr1NJ7xPeboJ0s0JHb5PZRJdNkdnX/O8VQ5wiEKJgRZgJR6Byj2PuyJRBPJzmGCknKpEXZJycmkWK7D+ga2coNqMF0S6Mf3qqYhvu0Bky0N7YHs1PJD7;3:3ewj6u5ppvzIoZqekCTQmUP6zLQO+dWRAGlXVg1lpnJIbmnFTpFHhxGjMjn+YFuqKSThIn18Kmbw/QnQHr4+2bReOYI0N2GntKwcjt7ucCWFINMyyf/IlQv02omZlHos;25:OXS5ftdpNUf0B7L2stYXwZ3qefew5Mr5DJ+6fJQp4mDtcAY5kI0tIXBG1Uwe3VVsfGSCr6jPSsJOEtwa6Z7syu8SNuQwliMQue9D31KaPF+GWj6CHL53UT7CBNwNDj/apzBRdYwrMnjGwSpPKh+FBbbLhYt7s5ISa5En1NOJbbfOocU1hMiKWrVXOZ1itBJGJk65kW1YaBFcBwf3nO6ReoFfYMeLQ3cXTJl6wb9I2NyO/Tkh3t6RqoAdxVXbh3biwwvX89wgMTPbPVv6DvwVdMKAT0CnRwmMsFA7SXi1JHorSHA1lypXDkf/1HiIgedu96tZVFTD1MQGnGUqlzs0P+j3wFPzSh7J9L3VJcQwbJoQektgOebC2/LcyKwGpimp0mRfd3gCZn8vucEDrU4asJR8K0Idy/8D5Tpeh+tVJy8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1186; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;31:QciAVc8JVNPIo1Jmz5muNw5bshJGr8BkEkD99WUEbeyLd+qSdEE6QNcBMDPg7TnOnObtkV13i7Ffu3CotSrndi72hygl+GdCvGWORdlfNkZFjjxMx1b3O07br8ztJtQmhSMwgJVUxdHNBRDR8i1gmGq850mMYvbkcMsVZ0NnIO73dQDjFOipshF+8CzW++UPT/aNK7wiS2Li2dM0yMzLMNhf3rc5ufYUEChKU+VBEoA=;20:kQaP1VZbymce2iwj4P5CJfDaxyIUAF8JubF+1w2tqwY4QcgvoaYfwjF+8VV55F0CJBk2mPJ1H9FaMNj3fXPgYiERYDvD1uV9nauL1N+ahCKmsAu/7JgLJ2JklKAXUQ85YVEj/+15ByYqVXc8LXqA//yXmoUIew9lOFoNqJV+zC8=;4:KYf/sgLE4kj5Ytu9ne8zzcStBU3EWlk+7E/SLseo4VQtbS8wFRR1S+WJd2At+muWXWF/FK2nwYynC0p+Nbpx/TZYhh4faIIHmUVjXKpgZpc4tTfK8plY73soXmEUX9puQRDWhEk8YfgO8oDilaMdPem7kR7ZuqUD+ZvoESz6iTFO785bVhKCx+caacdGTk1H3VY64fTrD6JWfNUdmMhiipOvXVqu3u76/hTpXIxKZ3z0Xf7ftMrvlkhjsssLj4dP1GKO/D//WxZff4lHtT+yFu3LHaQlL2XqClLEgljeQVBBIRtU0f443T3UFmBkYJkkGfyQJRPe0jxcXl0u+uP6PDytXbxsQm98Pq8xsvh0SuUufZ6AxvwEpA6rE4pMn0TGh+t1uL4/W1rwUtZWlkv1qQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN6PR15MB1186;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1186; X-Forefront-PRVS: 00462943DE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(189002)(24454002)(377454003)(199003)(586003)(81166006)(81156014)(8676002)(64126003)(68736007)(3846002)(7736002)(117156001)(6116002)(93886004)(7846002)(2950100001)(305945005)(31686004)(66066001)(83506001)(42186005)(47776003)(65956001)(2906002)(65806001)(77096005)(4326007)(230700001)(92566002)(105586002)(50466002)(23746002)(5660300001)(101416001)(5001770100001)(36756003)(54356999)(106356001)(50986999)(4001350100001)(33646002)(97736004)(76176999)(86362001)(189998001)(31696002)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1186;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1186;23:XFXMo9g5myA9CBGArIVwAD6Hmj1W9ZPaDXelz?= =?Windows-1252?Q?x/WQt2JQvKntPCSQHBoSFy3796CWMgYoKQfWKf1qHwh2+Xcj3by3OegW?= =?Windows-1252?Q?9qmpC5Xxav9lU8x9rhi7Qe6zR1tl5OYnyM1feCk0WgbHchFI/k4zfXnV?= =?Windows-1252?Q?YHgQTWsai21vdwnjij6LAwf1nTXireWbK0P3Gq676s907KHm7zoeaiOU?= =?Windows-1252?Q?K6h72vSI1RHyzqZlP2Kz8viykCRpS2jYe0nfiB4pNEmMOL3+EHN4C+lR?= =?Windows-1252?Q?mlxWEpCaaLxFjfnb9skM+4/VlwuzAUPPAovBP99QRBsWWcpfbdTOfaip?= =?Windows-1252?Q?MZEJSx0WJB+p/H3R8KScP3ffBKCI0wroIDoJSNNZNSJJ4YiCKLP9QEDE?= =?Windows-1252?Q?Bs6HPcfdmGjU+RKxmprYYlA89Q5wK9TykU5Un818cnffVigkms755L1j?= =?Windows-1252?Q?nZ4WKTWB2eRFRKGwtHHovjHjnFhOHHuA8sSWvJudQPJRRFH8swRJbluq?= =?Windows-1252?Q?x+dxa38bhycVLdcY03hjosE+t3+itX+rxOrgFPqJXEX9tebw7PKfsyyk?= =?Windows-1252?Q?tgSDwza5rogdK42J2vHu0MqUWijVsSvL0wpRbTaCqiCdev0j+yC8cLT6?= =?Windows-1252?Q?Tut1qHclRepgWhSDUqniKCjMGULDh4qwZO6umsVHEFvhiei+za33Pd8q?= =?Windows-1252?Q?mx3RwDbpOPZQY0firUJ58eNx9G6nM9MCB2jxgfZdgtdXBTvJBN4d3fjt?= =?Windows-1252?Q?3lkdZizUidgvwPqiZGaUdp3mUZer57pjIiycgyOU7g+jatk6iFfT7NcT?= =?Windows-1252?Q?Pb33wpzT3osdbDBJ86ViRrWY+qQYeWsInF9PXPml81+OJiYxNHSVU75f?= =?Windows-1252?Q?ZhzMG05SoNGmK95V7B4DT1W0YjvuqOSV6kDKe0PVvDE2Ji072OHArXra?= =?Windows-1252?Q?9CTNdyspTMCQ6MLI5Sbas3JWE1Zi4MoJUDULgAYoW3JzvsxHKMW/yR/M?= =?Windows-1252?Q?KdESJ36kPKzuQZAtddy06cG/LllcAGn/SP/TfHDBUEObsPfjwagYXOE3?= =?Windows-1252?Q?6ezlbfiOgfrLr+SiJuLxIq7hYpUGFAJczsSZY0IYt1DHH7l9rLH8Ali+?= =?Windows-1252?Q?eaSekgthw+ocjCzy8eq7bPT6u+ROOuch9oKTW5Jfzlk2oPH4V88cLHiR?= =?Windows-1252?Q?wMrfO9tjEIqryUIcCGoWLB17SduCxtUCe3p9Mn4dOkNFTN70VwwWHfg4?= =?Windows-1252?Q?wT5qNnxTib0ZnGscQN1U5LClHmFB5yyiB1k08tKdifIineC+vQCUp0V9?= =?Windows-1252?Q?JsDwJUHU+sxE6RFmuyEsRQB3z0yEdrzvIlrBPMCDGcpI7PKLV6SxGKuh?= =?Windows-1252?Q?OjAD8Tqeua9Ypg2Gx33Jq2cy4pf8JeRUw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;6:I99u03D2NNaJCGw7Omb56C1SZ2wVDt+pukXG92jL1ZkLqXwxIHTzzi9hEtULCCuGtX9HTky8rweSh+VN8Anfhce7XGPEFYAo5DGBdf7dLAqd/S6PlT90FeGEWPUZFyOjEY7y+ovQTyW8+12t3G6+a9O6HayWodkQSw0JKrHVX9vD5aPG0mM26hFNoXh8Q6vbEweLo0hAMLqAHNnUrLK+rs/TU8pWuLF2S2CRK/LtwBv68sI1A9BSJeTCyzxb02/31z5yRpdpdeTkw31jNbFyhjpWdex7v/48poh375RL2E0=;5:pPYGTfRnksJp9dMf6C9jL5WMRUYHJ0s5R8mgROAFFVO1coYD2tscGCcYAW+1dWKxn2u62rGWuWD5BaKj1+V6a7rBLAx/+dq9CylbPNTRd5J9CQM9zdTLTVePr1nVrVoaNYttt/BZSmZM5AWbtInuhw==;24:xxNCZrIe+OI9RonRlhmm9vdaRBTin0gIGczHBfKz3+lzkjy3YnJPItIc9ZF9UjVhR5evXG+8Vdr8oz8yI7I0en5v+Ht2uxz9/xmeaIa0R9c=;7:vuWjga9o63yjx5XR+ZN2rxt1OIfQqtO7LRQLOZgZSx2gg1oo6Nc3H2dDCHzNHxJa2keGaKGi3mzg3DDXDnEaX26RWUaV4JIc2jhEkCpQUCk+rE4CfzYZC4nW8MmmPW+/7myqTrt8sbGTQ30i2NYWms8H+0XwGYEqj1AA9ldc2bQwj0FJtZucBgwyZwajXgAMSK+QoJivJytwBgO6Lohpg6jbDfYNhnUF9/RtmShQmGFNfMPX/F+Zzjd807+wlh2O SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;20:kvOnNMgU2AgxZlpykC8o+QMdyZcBIB3f4AChgRV+xdNowGIvDjAkcofgTSFkHgeVMI/olxdQ2su5t0rJIe2/ket0GFNIOv9PiICpXSGzj14BRmmf3A+cRkiRIQZkr+jZgQk2P7LKJP8gfBYYbUDY0wFHU4QHJNl1CBZajFE3Rms= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2016 15:12:25.6572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1186 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-26_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/26/2016 09:17 AM, Keith Busch wrote: > On Fri, Aug 26, 2016 at 04:35:57PM +0200, Christoph Hellwig wrote: >> On Fri, Aug 26, 2016 at 07:31:33AM -0700, Andy Lutomirski wrote: >>> - Consider *deleting* the SCSI translation layer's power saving code. >>> It looks almost entirely bogus to me. It has an off-by-one in its >>> NPSS handling, it hardcodes power state indices which is total BS, it >>> ignores the distinction between operational and non-operational states >>> (which I think matters for non-APST usage). It also seems likely to >>> be that it's never been used, since it's one of the formerly >>> crashy-looking set_features users. >> >> Please go ahead and send a patch to delete it. Adding the whole SCSI >> layer was a mistake to start with, and it's always been horribly buggy. >> Until I started running the libiscsi testsuite even fairly normal I/O >> commands were a sure way to crash it, and crazy things like PM are >> almost guaranteed to a) not actually be used by real application and >> b) horrible buggy (as you've already noticed) > > Ack. If no distros or tools rely on the the SCSI crutch anymore, then > by all means, let's delete it. It's been disabled default for a while > now, and I think/hope everyone we care about has since migrated to > nvme awareness. On the FB management front, we don't depend on it. The only case that has come up where it was needed, was some Intel closed tool ;-) -- Jens Axboe