From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757590AbYGBAub (ORCPT ); Tue, 1 Jul 2008 20:50:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753129AbYGBAuK (ORCPT ); Tue, 1 Jul 2008 20:50:10 -0400 Received: from an-out-0708.google.com ([209.85.132.246]:41376 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759954AbYGBAtu (ORCPT ); Tue, 1 Jul 2008 20:49:50 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=c+JNQA89JSUD3h77AJAZleBOxAi8YA0MPENzoUguP+ubQfqu5nOItxKemWnKgxO7BJ ZBN+DcDXhF7rxIIGjNShQDe29W8502w5HNO1X6G4varjeIrGNCZD0dBMQyzKRNsMfqp8 UvGY92FXmC4oGvDSnDkjJQo1Dalong2zeF6J4= Message-ID: <28c262360807011749i10a77640l4a1d33d5e627c866@mail.gmail.com> Date: Wed, 2 Jul 2008 09:49:49 +0900 From: "MinChan Kim" To: "Rik van Riel" , "KOSAKI Motohiro" Subject: Re: [resend][PATCH -mm] split_lru: fix pagevec_move_tail() doesn't treat unevictable page Cc: LKML , linux-mm , "Lee Schermerhorn" , "Andrew Morton" In-Reply-To: <28c262360807011739w5668920buf7880de6ed30f912@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080701155749.37F8.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080701172223.3801.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080701093840.07b48ced@bree.surriel.com> <28c262360807011739w5668920buf7880de6ed30f912@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, it seems mail sender problem. Resend CPU1 CPU2 shm_unlock scan_mapping_unevictable_pages check_move_unevictable_page ClearPageUnevictable rotate_reclaimable_page PageUnevictable(page) return 0 SetPageUnevictable list_move(LRU_UNEVICTABLE) local_irq_save pagevec_move_tail On Wed, Jul 2, 2008 at 9:39 AM, MinChan Kim wrote: > Hi, Rik and Kosaki-san > > I want to know exact race situation for remaining git log. > As you know, git log is important for me who is newbie to understand source > > There are many possibility in this race problem. > > Did you use hugepage in this test ? > I think that If you used hugepage, it seems to happen following race. > > -------------- > > CPU1 CPU2 > > shm_unlock > scan_mapping_unevictable_pages > check_move_unevictable_page > ClearPageUnevictable rotate_reclaimable_page > > PageUnevictable(page) return 0 > SetPageUnevictable > list_move(LRU_UNEVICTABLE) > > local_irq_save > > pagevec_move_tail > > Do you think it is possible ? > > On Tue, Jul 1, 2008 at 10:38 PM, Rik van Riel wrote: >> On Tue, 01 Jul 2008 17:26:51 +0900 >> KOSAKI Motohiro wrote: >> >>> Signed-off-by: KOSAKI Motohiro >> >> Acked-by: Rik van Riel >> >> Good catch! >> >>> @@ -116,7 +116,7 @@ static void pagevec_move_tail(struct pag >>> zone = pagezone; >>> spin_lock(&zone->lru_lock); >>> } >>> - if (PageLRU(page) && !PageActive(page)) { >>> + if (PageLRU(page) && !PageActive(page) && !PageUnevictable(page)) { >>> int lru = page_is_file_cache(page); >>> list_move_tail(&page->lru, &zone->lru[lru].list); >>> pgmoved++; >> >> -- >> All rights reversed. >> > > > > -- > Kinds regards, > MinChan Kim > -- Kinds regards, MinChan Kim