From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524Ab0CWIrE (ORCPT ); Tue, 23 Mar 2010 04:47:04 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:61853 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752764Ab0CWIrA (ORCPT ); Tue, 23 Mar 2010 04:47:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=PJOhEaKRE+kMAb++2Yc3QphiaYKLC1UQk37gYC2u/zKSibSAO5RLZ5vZ1Nt3UJo6w9 +EhXkWEbWuM0Jisx2l/m79PDa66c+YNiXpNEGnIDL9pw7bGIutAJN4ba0+EL3s2n5HFi TKaQZY2F/uBnSsI+1ZKdRKnkad12LPv5WE7A4= MIME-Version: 1.0 Date: Tue, 23 Mar 2010 17:46:52 +0900 Message-ID: <28c262361003230146o7bca61e6h3af2062b1172fdb2@mail.gmail.com> Subject: data consistency of high page From: Minchan Kim To: Ralf Baechle Cc: lkml , linux-mips , Namjae Jeon Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Ralf. Below is thread long time ago. At that time, we can't end up the problem by some reason. Sorry for that. The problem would occur, again. On Fri, Oct 16, 2009 at 6:24 PM, Ralf Baechle wrote: > On Fri, Oct 16, 2009 at 02:17:19PM +0900, Minchan Kim wrote: > >> Many code of kernel fs usually allocate high page and flush. >> But flush_dcache_page of mips checks PageHighMem to avoid flush >> so that data consistency is broken, I think. > > What processor and cache configuration? > >> I found it's by you and Atsushi-san on 585fa724. >> Why do we need the check? >> Could you elaborte please? > > The if statement exists because __flush_dcache_page would crash if a page > is not mapped. This of course isn't correct but that wasn't a problem > since highmem still is only supported on machines that don't have aliases. > > Ralf > Our system is following as. mips 34ke primary i-cache 32kB VIPT 4way 32 byte line size. primary d-cache 32kB 4way 32 bytes linesize If you have further questions, Namjae, Could you follow question of Ralf? -- Kind regards, Minchan Kim