From: Randy Dunlap <rdunlap@infradead.org>
To: Chetankumar Mistry <chetan.mistry@arm.com>, linux-kernel@vger.kernel.org
Cc: lukasz.luba@arm.com, rafael@kernel.org,
daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2][RFC 1/2] Implement Ziegler-Nichols Heuristic
Date: Fri, 17 Dec 2021 22:07:21 -0800 [thread overview]
Message-ID: <28c7a12e-6d85-d15d-8884-997eb68612e9@infradead.org> (raw)
In-Reply-To: <20211217184907.2103677-1-chetan.mistry@arm.com>
On 12/17/21 10:49, Chetankumar Mistry wrote:
> Implement the Ziegler-Nichols Heuristic algorithm to better
> estimate the PID Coefficients for a running platform.
> The values are tuned to minimuse the amount of overshoot in
> the temperature of the platform and subsequently minimise
> the number of switches for cdev states.
>
> Signed-off-by: Chetankumar Mistry <chetan.mistry@arm.com>
The kernel-doc changes all look good and don't cause any warnings.
Thanks.
> ---
> Changelog v2:
> - Updated Kernel-Docs to use ':' delimiter (asked by Randy Dunlap)
> - Changed divide operation to use div_frac (requested by kernel_test_robot)
>
> drivers/thermal/gov_power_allocator.c | 418 ++++++++++++++++++++++++++
> drivers/thermal/thermal_sysfs.c | 2 +
> include/linux/thermal.h | 7 +
> 3 files changed, 427 insertions(+)
--
~Randy
next prev parent reply other threads:[~2021-12-18 6:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 18:49 Chetankumar Mistry
2021-12-17 18:49 ` [PATCH v2][RFC 2/2] Remove sysfs entry Chetankumar Mistry
2021-12-18 6:07 ` Randy Dunlap [this message]
2021-12-20 9:58 ` [PATCH v2][RFC 1/2] Implement Ziegler-Nichols Heuristic Lukasz Luba
2022-01-06 11:54 ` Lukasz Luba
2022-01-06 12:16 ` Daniel Lezcano
2022-01-06 13:16 ` Lukasz Luba
2022-01-07 11:52 ` Daniel Lezcano
2022-01-07 13:39 ` Lukasz Luba
[not found] ` <DB6PR0802MB22791E85B333050C801ED388F8299@DB6PR0802MB2279.eurprd08.prod.outlook.com>
2022-02-04 11:50 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c7a12e-6d85-d15d-8884-997eb68612e9@infradead.org \
--to=rdunlap@infradead.org \
--cc=amitk@kernel.org \
--cc=chetan.mistry@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®