From: bot+bpf-ci@kernel.org
To: menglong8.dong@gmail.com,andrii@kernel.org
Cc: daniel@iogearbox.net,martin.lau@linux.dev,eddyz87@gmail.com,song@kernel.org,yonghong.song@linux.dev,john.fastabend@gmail.com,kpsingh@kernel.org,sdf@fomichev.me,haoluo@google.com,jolsa@kernel.org,davem@davemloft.net,dsahern@kernel.org,tglx@linutronix.de,mingo@redhat.com,jiang.biao@linux.dev,bp@alien8.de,dave.hansen@linux.intel.com,x86@kernel.org,hpa@zytor.com,bpf@vger.kernel.org,netdev@vger.kernel.org,linux-kernel@vger.kernel.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next v11 10/12] selftests/bpf: add testcases for fsession
Date: Fri, 23 Jan 2026 07:57:51 +0000 (UTC) [thread overview]
Message-ID: <28d092553ad40300324a21ccbc1dfd89f06283ca4801a5196e993f11e1522e71@mail.kernel.org> (raw)
In-Reply-To: <20260123073532.238985-11-dongml2@chinatelecom.cn>
[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]
> diff --git a/tools/testing/selftests/bpf/progs/fsession_test.c b/tools/testing/selftests/bpf/progs/fsession_test.c
> new file mode 100644
> index 000000000000..f504984d42f2
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/fsession_test.c
> @@ -0,0 +1,110 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2025 ChinaTelecom */
> +#include <vmlinux.h>
> +#include <bpf/bpf_helpers.h>
> +#include <bpf/bpf_tracing.h>
> +
> +char _license[] SEC("license") = "GPL";
[ ... ]
> +__u64 test6_entry_result = 0;
> +__u64 test6_exit_result = 0;
> +SEC("fsession/bpf_fentry_test1")
> +int BPF_PROG(test6, int a)
> +{
> + __u64 addr = bpf_get_func_ip(ctx);
> +
> + if (bpf_session_is_return(ctx))
> + test6_exit_result = (const void *) addr == &bpf_fentry_test1;
> + else
> + test6_entry_result = (const void *) addr == &bpf_fentry_test1;
^^^^^^^^^^^^^^^^^^
Is the bpf_fentry_test1 symbol declared somewhere? The code references
&bpf_fentry_test1 but there is no extern declaration with __ksym in this
file.
Other BPF selftests that take addresses of kernel symbols declare them
explicitly, for example get_func_ip_test.c has:
extern int bpf_fentry_test1(int a) __ksym;
And kprobe_multi_session.c has:
extern const void bpf_fentry_test1 __ksym;
Without a similar declaration, will this BPF program compile and load
correctly?
> + return 0;
> +}
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21278745581
next prev parent reply other threads:[~2026-01-23 7:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 7:35 [PATCH bpf-next v11 00/12] bpf: fsession support Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 01/12] bpf: add " Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 02/12] bpf: use the least significant byte for the nr_args in trampoline Menglong Dong
2026-01-23 8:07 ` bot+bpf-ci
2026-01-23 8:29 ` Menglong Dong
2026-01-23 9:21 ` Menglong Dong
2026-01-23 22:57 ` Andrii Nakryiko
2026-01-24 1:14 ` Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 03/12] bpf: change prototype of bpf_session_{cookie,is_return} Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 04/12] bpf: support fsession for bpf_session_is_return Menglong Dong
2026-01-23 8:07 ` bot+bpf-ci
2026-01-23 8:15 ` Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 05/12] bpf: support fsession for bpf_session_cookie Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 06/12] bpf,x86: introduce emit_store_stack_imm64() for trampoline Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 07/12] bpf,x86: add fsession support for x86_64 Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 08/12] libbpf: add fsession support Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 09/12] bpftool: " Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 10/12] selftests/bpf: add testcases for fsession Menglong Dong
2026-01-23 7:57 ` bot+bpf-ci [this message]
2026-01-23 8:05 ` Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 11/12] selftests/bpf: add testcases for fsession cookie Menglong Dong
2026-01-23 7:35 ` [PATCH bpf-next v11 12/12] selftests/bpf: test fsession mixed with fentry and fexit Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28d092553ad40300324a21ccbc1dfd89f06283ca4801a5196e993f11e1522e71@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hpa@zytor.com \
--cc=ihor.solodrai@linux.dev \
--cc=jiang.biao@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®