From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35552C63697 for ; Sat, 14 Nov 2020 15:54:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFA3322254 for ; Sat, 14 Nov 2020 15:54:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cyL8deSC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727148AbgKNPyE (ORCPT ); Sat, 14 Nov 2020 10:54:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38382 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727013AbgKNPyD (ORCPT ); Sat, 14 Nov 2020 10:54:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605369242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WdylbP2NfyT0+ghuXLqODU9fXbydrot5yDDVn5EPhdA=; b=cyL8deSCO7/wqaSw/uWrp3u4Z8tkcZP+JA0ODKZ8MxK7NqogvDA2skNmwheFudRQ4hP1Z7 vMdJCvSdt+B7b0Wyjz41cj36QDT00I0lbXPAwCR+5JBRVYdMj1l4jX50H8kkv0qj/LczvF F77trezAA/ja/lJ2XmR93GOQ48UTG+c= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-8jJLJyzvPPiHvkgRkGSNmg-1; Sat, 14 Nov 2020 10:53:57 -0500 X-MC-Unique: 8jJLJyzvPPiHvkgRkGSNmg-1 Received: by mail-qt1-f198.google.com with SMTP id z14so7686898qto.8 for ; Sat, 14 Nov 2020 07:53:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=WdylbP2NfyT0+ghuXLqODU9fXbydrot5yDDVn5EPhdA=; b=Z/UsrB2vx2k+YB2Q1qNg8YeMdgCEc4cG+rqggziCBqh/+g9MaGi7DYOIihNjeItQ5H Nd3phjiHGYzgtcp27jUQ6poL99QDkSG0Xmv87AZ4iI09Yggy5revE3q1xjhVOPr1ArFN UVYJx2GQgGr6tsXi0AMIov1aX4jePHJVSg/1TDzPQFkZf79YDclk1pQNWgkJH9zYZhl6 X01HpnWZ1LKxHjqUhSaS5TUh41LDK/gqXUAXot8b5kuQDnI4uIdV6GDhN1PMdl+hs36v ely/krFnDgbmQL27iIbs26G3yuQUmvVFWznIX8jGs+o7Sn0f7ZYSUHEz12Hn4PsGPDHG B6Qg== X-Gm-Message-State: AOAM531+p3jRIQNvSlBXRWt8vK6boT0qvdy4j5gF3sPBOUcwUA2DDgcX vE+TnuNaScFss/IY1GAYtr3RmElktfceub/y4oqwhKLzVJDFr/ObWOUYen6km51f4XBBAT25W+Q Dz4Q7JOOhiTvkrS8UJ5eX5CgE X-Received: by 2002:a37:e12:: with SMTP id 18mr4265875qko.179.1605369237482; Sat, 14 Nov 2020 07:53:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJz4r1WeR6yUrgT85N7nd2d0YiKq5XInRkccXpaBEvTZ7tazPNx+ZgS7E0GahK+l8SJ4hcyh8g== X-Received: by 2002:a37:e12:: with SMTP id 18mr4265861qko.179.1605369237249; Sat, 14 Nov 2020 07:53:57 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id c199sm506723qke.111.2020.11.14.07.53.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Nov 2020 07:53:56 -0800 (PST) Subject: Re: [PATCHv1 1/4] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag To: Richard Gong , mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dinguyen@kernel.org, sridhar.rajagopal@intel.com, Richard Gong References: <1605204403-6663-1-git-send-email-richard.gong@linux.intel.com> <1605204403-6663-2-git-send-email-richard.gong@linux.intel.com> <4dd9a747-05f3-1cca-22a6-35681677223d@linux.intel.com> From: Tom Rix Message-ID: <28d2ace8-315a-3eaf-75da-88a4e90ea045@redhat.com> Date: Sat, 14 Nov 2020 07:53:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <4dd9a747-05f3-1cca-22a6-35681677223d@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/20 6:30 AM, Richard Gong wrote: > >> A whitespace issue, the new BIT(5) should align with the others, so add two spaces to the others. >> > > There is only one space, also I ran checkpatch with strict option and didn't see any whitespace issue. > > In the original patch, BIT(0) to BIT(4) align themselves. I am not sure why we see differently in email. > >  #define FPGA_MGR_PARTIAL_RECONFIG      BIT(0) >  #define FPGA_MGR_EXTERNAL_CONFIG       BIT(1) >  #define FPGA_MGR_ENCRYPTED_BITSTREAM   BIT(2) >  #define FPGA_MGR_BITSTREAM_LSB_FIRST   BIT(3) >  #define FPGA_MGR_COMPRESSED_BITSTREAM  BIT(4) > +#define FPGA_MGR_BITSTREM_AUTHENTICATION BIT(5) > > To align BIT(5) with others, I have to use additional tab to BIT(0) to BIT(4). But I don't think I should make such change on them, agree? The existing table of #defines has aligned values for BIT(0) to BIT(4) Your addition of BIT(5) value has an inconsistent alignment with the others BIT(0) to BIT(4) The alignment of all the values should be consistent. Tom > > Regards, > Richard > >> Tom >> >>>     /** >>>    * struct fpga_image_info - information specific to a FPGA image >> >