From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C695DF49 for ; Thu, 2 Jan 2025 17:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735840165; cv=none; b=rlmMsaNAFcajyhBujhi4JHI21Y7MZYJn7sVf89wQibo6DELu82GBMeRz164MR0PtbhqZDqZXOZ16mgT0xrWeKO/sExkDoDEuVAfgR5oAPd1c//Y8LUsvGpcM0EIYm9gOpc6ufk74Bya04pDqtD6dsKDwD7MLYxB9lagmar8fwD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735840165; c=relaxed/simple; bh=Z/tG/88HIGz5gjPu4kyJ/DOR5P0Ck6oNEbyOlAxiXDA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sZIhReYl3a+vxWaRKHkNQMZMO/6qpQDXhOxH1cAjulazpSLZ9eS6X7uWe2XClkJeSpngVGMqjDuBiYGxzbhk/jdL7d3ZHZgNEmUvgDzDrre6g0Z3yxELhs7dG3DTHsBpKQHrZRpGffwAMipZk67+++0Wp8onmZ+rtjhE34GFtPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=a+YGCiwR; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a+YGCiwR" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3862f11a13dso1424858f8f.2 for ; Thu, 02 Jan 2025 09:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735840162; x=1736444962; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BQzXpHKZ38XKWlPQGVkN7bjW5ZJ+69jWQ4BQJv2lDvg=; b=a+YGCiwRbn5iHIsV8dhkahpMTxOIgmh9nOd9j2wKcC5KW+eaKMaP9G4Ka1NmJ/xQiB /Hs6W34lcgZIBiE5rNd51k8Nk8kM3wq9sSo5/clWiCWPBj/Fdmn9lOLTrUX2+sI5FKRq 0Jn7iZlTpmrcMR5agmYd0BTzQEj0pw8XU1hv3PCSVWdHOCUtFj4F97gviWygCOY5az3M ka0O1xc5b+ORXo4S8TaLdgkXHfS+PU2ejAGiw8Rrc1dU74ETTNaFmB7FT1dCi8lCNKIH QVHLLak2X4GYXxKT2ZuBDGVUyKuXApB+EQZM5ggq0zJrNnG7uXECnXi4HCpBtLIm45mJ G4bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735840162; x=1736444962; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BQzXpHKZ38XKWlPQGVkN7bjW5ZJ+69jWQ4BQJv2lDvg=; b=AGC1UnDldULxjiqkAS9oLWgYsgRNNXzMMeakNjiSYecj0YT9rR4j+sAuA3hxmcYf3F 9Tr0LJSbCZ9fNX37TZMQzG0bdqKh6ad8ssJKia8fXOu8NeKJEqwfUemwogcQehJOI/gX R6q6UPL68ohQo/3jO3yMyJ+GuYhDssNdc+9+Q2cWi5APjI0lSz/Uinms9/+q0gBRB09b R4Q10t9sqERZKamt0JYWU5t5F8d+LxnC5eC8npt76peUr9dDSeYqVniyS9jbpz37/yCl d2hrwxU4HAm8GXIY63lDAEEy2daN7Ry+3Mt10iNsCYJXGIXy0YRn1HzsF8D20pDLwfJU jaJg== X-Forwarded-Encrypted: i=1; AJvYcCXWqo+M31D1tDzWuir9SybzN2RoA1V+d/gyUwZUA23+2UiwxQP2FK40lWbpkYFnfsLnhJIMOIzhVj3c/ck=@vger.kernel.org X-Gm-Message-State: AOJu0YwBBfcbv4XNVqWKlPlkBEuAlIx9PffNEkxMeavni+YgbcP0VOOp rkiZRcQ4eJJE5wGGdVZrqU0uabM5y1xTt/0WmkIdeQP76qqPW/qJFTEB9im51ONHPZvqnXCcqSJ V X-Gm-Gg: ASbGncvA0UuMD7O9bsb9ziF7z+Ofs1CXJ0DwT09Xy3IcakJr5A5mbYypTz2WWAEOoOL 7leUqxlBT7vS8FCjlZ3/+J6aetjifmIGWtwhApqflT/Rmp3EAUeuqEvPpucqQXobeXIngUJuoxD VSmNY7wLHU3CvqV9V1d14e1ERfugUlMEk0dO6e3RBCIK7q/7EaoywN37AZ3EdQnZzuVW6A32Uxn Vi7f2N+SOL4/PXo0HKgu47EZmVdt5moKmzjjBnA6Hfu8O9hqIRxayq2F7+ctPBUSOMmba/z X-Google-Smtp-Source: AGHT+IEMAMwuukkLzGiPQ39+VlqPA5uci/lVeQvAMvSYKotrXDL7vVyhPBdae/AizKHwtC9ADf4SVA== X-Received: by 2002:adf:9d84:0:b0:385:ed78:e17d with SMTP id ffacd0b85a97d-38a2213dfc3mr11989392f8f.0.1735840161715; Thu, 02 Jan 2025 09:49:21 -0800 (PST) Received: from [172.16.0.204] ([79.164.49.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8474b6sm38703730f8f.51.2025.01.02.09.49.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 09:49:21 -0800 (PST) Message-ID: <28db1605-e9b9-4b44-8af3-9b7abf0e83a2@linaro.org> Date: Thu, 2 Jan 2025 19:49:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] arm64: dts: qcom: x1e80100: Add CAMCC block definition Content-Language: ru-RU To: Bryan O'Donoghue , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab , Bjorn Andersson , Michael Turquette , Stephen Boyd , Jagadeesh Kona , Konrad Dybcio Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-clk@vger.kernel.org References: <20250102-b4-linux-next-24-11-18-dtsi-x1e80100-camss-v3-0-cb66d55d20cc@linaro.org> <20250102-b4-linux-next-24-11-18-dtsi-x1e80100-camss-v3-4-cb66d55d20cc@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20250102-b4-linux-next-24-11-18-dtsi-x1e80100-camss-v3-4-cb66d55d20cc@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bryan. On 1/2/25 18:32, Bryan O'Donoghue wrote: > Add the CAMCC block for x1e80100. The x1e80100 CAMCC block is an iteration > of previous CAMCC blocks with the exception of having two required > power-domains not just one. > > Signed-off-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index c18b99765c25c901b3d0a3fbaddc320c0a8c1716..5c7b0c048d41a4ba3d74bbf77216ad09b652ed30 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -4647,6 +4648,21 @@ usb_1_ss1_dwc3_ss: endpoint { > }; > }; > > + camcc: clock-controller@ade0000 { > + compatible = "qcom,x1e80100-camcc"; > + reg = <0 0x0ade0000 0 0x20000>; > + clocks = <&gcc GCC_CAMERA_AHB_CLK>, > + <&bi_tcxo_div2>, > + <&bi_tcxo_ao_div2>, > + <&sleep_clk>; > + power-domains = <&rpmhpd RPMHPD_MXC>, > + <&rpmhpd RPMHPD_MMCX>; > + required-opps = <&rpmhpd_opp_low_svs>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; > + > mdss: display-subsystem@ae00000 { > compatible = "qcom,x1e80100-mdss"; > reg = <0 0x0ae00000 0 0x1000>; > Looks good, thank you. Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir