From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B06F232E6BC for ; Thu, 28 May 2026 23:13:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780009993; cv=none; b=QlnkVSxWj+yLhLZOoWy9y5xgFVNn8yxxwwTAxjPk4WVliqnQTRH6J9LJGyNh5sMzx/+22FCi2ggfTsrOlaVWCw2CKVme1w9SQbt0izVtApJCe1dNUWLWDX+64NWoQ2jubg6l5rriG8PCBSnOdYYyJ8J+a6Npn7UfHBPySYzSDik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780009993; c=relaxed/simple; bh=8fuLQJWg8XRRj+k1eGEyKO8eIZ85bvdVbWb3wN3rJGA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CR96/yNkCWXeFqln6WPIvESbX5u7aWHz7IV93bWjs6XFN3+yuw8WMmQqoWANcM4IcCSqEH6VZ6O8z2tCusSVpr+e6M++WC0u8Mn1O5zCgZCB11jK2XpGK8MeAqHcKWgxMfFxl1dfSD8PDLqBvN9CsxdaewbHpB6+rShRxuDwmho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eL/bxPpv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eL/bxPpv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C25EC1F000E9; Thu, 28 May 2026 23:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780009992; bh=IEiBiTIF6bxWlxJuptDnCfTuQUzSkFcxDN1msgpL6rA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=eL/bxPpvg4EeA64lIZxTvlD3Np0KEhiIgKElcTdqkbjvO0E+e5ddOAW5yCZy+lIry G2+A8xJEmGwJbgtoZ0gbJSdWthDgJd/UuZf1X7Dt+aLIc/2MIJC2NAFG7E6eYPFHKy 1OmhdkRGC3XTFm5AmfwwttMBUPKcNS7fEdffa9uCz8MmAM+Jyz9Msp4GjjRGxtuiQf TD4mXwRv4/hf+NFSUftcK5rTrUw8jJxcpX9i4+aHX22KnSeClMSIr3hAfwncva/etr v1vq1OsU8hC1z3ZJKB/l7dyReoizul48bCMZwHQmnmVnX4owuL4OP/WFD+bfhOp8LJ C0IvCEZ+2x6iw== Message-ID: <28dc206a-695d-482f-b434-c27eda960bfe@kernel.org> Date: Thu, 28 May 2026 22:19:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] accel/amdxdna: Disable device buffer exporting Content-Language: en-US To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org, karol.wachowski@linux.intel.com Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com References: <20260526185058.1780869-1-lizhi.hou@amd.com> From: Mario Limonciello In-Reply-To: <20260526185058.1780869-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/26/26 19:50, Lizhi Hou wrote: > Device buffers are never intended to be exported. Disable exporting > support explicitly. > > Signed-off-by: Lizhi Hou Reviewed-by: Mario Limonciello (AMD) > --- > drivers/accel/amdxdna/amdxdna_gem.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/accel/amdxdna/amdxdna_gem.c b/drivers/accel/amdxdna/amdxdna_gem.c > index 2dfdc56ba91d..2727e48afc0a 100644 > --- a/drivers/accel/amdxdna/amdxdna_gem.c > +++ b/drivers/accel/amdxdna/amdxdna_gem.c > @@ -725,9 +725,15 @@ static int amdxdna_gem_dev_obj_vmap(struct drm_gem_object *obj, struct iosys_map > return 0; > } > > +static struct dma_buf *amdxdna_gem_dev_obj_export(struct drm_gem_object *gobj, int flags) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > static const struct drm_gem_object_funcs amdxdna_gem_dev_obj_funcs = { > .free = amdxdna_gem_dev_obj_free, > .vmap = amdxdna_gem_dev_obj_vmap, > + .export = amdxdna_gem_dev_obj_export, > }; > > static const struct drm_gem_object_funcs amdxdna_gem_shmem_funcs = {